unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#46852] doc: Fix reference to the bind package variable name
@ 2021-03-01 16:28 Luis Felipe via Guix-patches via
  2021-03-02 20:22 ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-03-01 16:28 UTC (permalink / raw)
  To: 46852

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

Change "bind" package variable name to the actual variable name, "isc-bind".


---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-Fix-reference-to-the-bind-package-variable-name.patch --]
[-- Type: text/x-patch; name=0001-doc-Fix-reference-to-the-bind-package-variable-name.patch, Size: 1202 bytes --]

From 91f7ec90fbe742de6eb3c092c86d84125a56f51f Mon Sep 17 00:00:00 2001
From: Luis Felipe <luis.felipe.la@protonmail.com>
Date: Mon, 1 Mar 2021 11:15:16 -0500
Subject: [PATCH] doc: Fix reference to the bind package variable name.

* doc/guix.texi (Globally-Visible Packages): Change "bind" variable
name to the actual variable name, "isc-bind".
---
 doc/guix.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index e8fb346d73..8468b2890b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13301,12 +13301,12 @@ of a package:
 
 (operating-system
   ;; ...
-  (packages (cons (list bind "utils")
+  (packages (cons (list isc-bind "utils")
                   %base-packages)))
 @end lisp
 
 @findex specification->package
-Referring to packages by variable name, like @code{bind} above, has
+Referring to packages by variable name, like @code{isc-bind} above, has
 the advantage of being unambiguous; it also allows typos and such to be
 diagnosed right away as ``unbound variables''.  The downside is that one
 needs to know which module defines which package, and to augment the

base-commit: 7ca43b0a1e2215abe0df0708f31decace8e68911
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#46852] doc: Fix reference to the bind package variable name
  2021-03-01 16:28 [bug#46852] doc: Fix reference to the bind package variable name Luis Felipe via Guix-patches via
@ 2021-03-02 20:22 ` Leo Famulari
  2021-03-02 23:53   ` Tobias Geerinckx-Rice via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2021-03-02 20:22 UTC (permalink / raw)
  To: 46852

On Mon, Mar 01, 2021 at 04:28:27PM +0000, Luis Felipe via Guix-patches via wrote:
> Change "bind" package variable name to the actual variable name, "isc-bind".
> 
> 
> ---
> Luis Felipe López Acevedo
> https://luis-felipe.gitlab.io/
> 

> From 91f7ec90fbe742de6eb3c092c86d84125a56f51f Mon Sep 17 00:00:00 2001
> From: Luis Felipe <luis.felipe.la@protonmail.com>
> Date: Mon, 1 Mar 2021 11:15:16 -0500
> Subject: [PATCH] doc: Fix reference to the bind package variable name.
> 
> * doc/guix.texi (Globally-Visible Packages): Change "bind" variable
> name to the actual variable name, "isc-bind".

Is there a reason for this change?

It's okay for packages and variables to have different names.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#46852] doc: Fix reference to the bind package variable name
  2021-03-02 20:22 ` Leo Famulari
@ 2021-03-02 23:53   ` Tobias Geerinckx-Rice via Guix-patches via
  2021-03-03 13:38     ` Luis Felipe via Guix-patches via
  0 siblings, 1 reply; 5+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2021-03-02 23:53 UTC (permalink / raw)
  To: Leo Famulari, Luis Felipe; +Cc: 46852

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Leo!

Leo Famulari 写道:
> Is there a reason for this change?

It's just weird to say ‘...now assume there's a package called 
bind, but there isn't, and then you could write...’ when we could 
use a valid package from the get-go.

It's safe to assume that ‘bind’ was simply a typo, and the fix is 
just and good.

> It's okay for packages and variables to have different names.

Hm, you lose me here.  The snippet clearly intends to refer to 
BIND-the-package (few other packages have a "utils" output), not 
some arbitrary user (eh) binding...

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#46852] doc: Fix reference to the bind package variable name
  2021-03-02 23:53   ` Tobias Geerinckx-Rice via Guix-patches via
@ 2021-03-03 13:38     ` Luis Felipe via Guix-patches via
  2021-06-14  2:34       ` bug#46852: " Maxim Cournoyer
  0 siblings, 1 reply; 5+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-03-03 13:38 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 46852@debbugs.gnu.org, Leo Famulari

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, March 2, 2021 11:53 PM, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> Leo!
>
> Leo Famulari 写道:
>
> > Is there a reason for this change?

Oh, I should have said so in the commit message, sorry. The reason is that if I add (list bind "utils") to the packages field in my operating system definition, reconfiguring the system fails because "bind" is a built-in Guile procedure, and so the package variable for BIND is called "isc-bind" to avoid that conflict.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#46852: doc: Fix reference to the bind package variable name
  2021-03-03 13:38     ` Luis Felipe via Guix-patches via
@ 2021-06-14  2:34       ` Maxim Cournoyer
  0 siblings, 0 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2021-06-14  2:34 UTC (permalink / raw)
  To: Luis Felipe; +Cc: 46852-done, Tobias Geerinckx-Rice, Leo Famulari

Hello,

Luis Felipe <luis.felipe.la@protonmail.com> writes:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Tuesday, March 2, 2021 11:53 PM, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
>> Leo!
>>
>> Leo Famulari 写道:
>>
>> > Is there a reason for this change?
>
> Oh, I should have said so in the commit message, sorry. The reason is
> that if I add (list bind "utils") to the packages field in my
> operating system definition, reconfiguring the system fails because
> "bind" is a built-in Guile procedure, and so the package variable for
> BIND is called "isc-bind" to avoid that conflict.

Applied as 0b5120fb03db5226871b3482a72b1e6fdaa59ead, thank you!

And thanks to Leo and Tobias for getting the matter clarified :-).

Closing,

Maxim




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-14  2:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-01 16:28 [bug#46852] doc: Fix reference to the bind package variable name Luis Felipe via Guix-patches via
2021-03-02 20:22 ` Leo Famulari
2021-03-02 23:53   ` Tobias Geerinckx-Rice via Guix-patches via
2021-03-03 13:38     ` Luis Felipe via Guix-patches via
2021-06-14  2:34       ` bug#46852: " Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).