unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: iyzsong@outlook.com
Cc: 宋文武 <iyzsong@member.fsf.org>, 46587@debbugs.gnu.org
Subject: [bug#46587] [PATCH] gnu: Add libretro-lowresnx.
Date: Thu, 18 Feb 2021 13:52:36 -0500	[thread overview]
Message-ID: <YC63dIkhUSWJtO8X@jasmine.lan> (raw)
In-Reply-To: <OSZP286MB0664F2C5D68E28292F0F096BA3869@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM>

On Wed, Feb 17, 2021 at 06:47:56PM +0800, iyzsong@outlook.com wrote:
> From: 宋文武 <iyzsong@member.fsf.org>
> 
> * gnu/packages/emulators.scm (libretro-lowresnx): New variable.

Thanks for the patch!

> +           (replace 'build
> +             (lambda _
> +               (invoke "make" "-C" "platform/LibRetro"
> +                       (string-append "CC=" ,(cc-for-target)))))

I think it's more idiomatic for Guix to use #:make-flags, maybe like
this (untested!):

(#:make-flags
  (list "-C" "platform/LibRetro"
        (string-append "CC=" ,(cc-for-target))))

... but either way is fine.




  reply	other threads:[~2021-02-18 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 10:47 [bug#46587] [PATCH] gnu: Add libretro-lowresnx iyzsong
2021-02-18 18:52 ` Leo Famulari [this message]
2021-02-20 11:54   ` bug#46587: " 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC63dIkhUSWJtO8X@jasmine.lan \
    --to=leo@famulari.name \
    --cc=46587@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    --cc=iyzsong@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).