From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4LOjMWofD2CgBwAA0tVLHw (envelope-from ) for ; Mon, 25 Jan 2021 19:43:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uDKhLWofD2DHXwAAB5/wlQ (envelope-from ) for ; Mon, 25 Jan 2021 19:43:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8F959404DF for ; Mon, 25 Jan 2021 19:43:34 +0000 (UTC) Received: from localhost ([::1]:36514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l47lt-0006mO-Mh for larch@yhetil.org; Mon, 25 Jan 2021 14:43:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l47lO-0006lo-NT for guix-patches@gnu.org; Mon, 25 Jan 2021 14:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l47lO-0004QS-9i for guix-patches@gnu.org; Mon, 25 Jan 2021 14:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l47lO-0007Nd-7h for guix-patches@gnu.org; Mon, 25 Jan 2021 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jan 2021 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161160376628344 (code B ref 45712); Mon, 25 Jan 2021 19:43:02 +0000 Received: (at 45712) by debbugs.gnu.org; 25 Jan 2021 19:42:46 +0000 Received: from localhost ([127.0.0.1]:40015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47l7-0007N6-VB for submit@debbugs.gnu.org; Mon, 25 Jan 2021 14:42:46 -0500 Received: from mout-p-102.mailbox.org ([80.241.56.152]:25538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47l5-0007Mq-Fw for 45712@debbugs.gnu.org; Mon, 25 Jan 2021 14:42:44 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4DPgHx2Hn2zQjXh; Mon, 25 Jan 2021 20:42:37 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1611603755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CW3Ommd7GUTpZlAh0W8axKU5r8h32dij+ZAmDKBmxeo=; b=sEDwfQLp/9wLZIQYQ5hqV8+auI/ndZ/JGerB0iGvdVWzGJ82u/ibFQXxzG1Q36l8zd4OWX PPfn5cbHHmXj9CzIXA+pQF0H3eXiqD/dQLpPkZ4DGpuhIIcOfmm1CzzsXpujVrt37cyZF/ aEYgJfD7qQsi9QFi9NXuJzykcFVtQcNSbTGepGOHoZcHRgW25r1+gsPhPpCVvods4QG94q A7/9DH7ptE9vgYEtzHEFyBQiDVJxSQ9KjZEf66c5PJrFyiWkmLZg9xLOzfCPiJALx4Jb81 7YJ2+MuxVjN6C1LouRiS4r5qKqFPyemHdm/n7hnUVCfjzhmc96gpOAHHWV5a+w== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id xZ5X98kEz3IQ; Mon, 25 Jan 2021 20:42:33 +0100 (CET) Date: Mon, 25 Jan 2021 20:42:26 +0100 From: Lars-Dominik Braun Message-ID: References: <8735yp3wmb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8735yp3wmb.fsf@gmail.com> X-MBO-SPAM-Probability: X-Rspamd-Score: -7.24 / 15.00 / 15.00 X-Rspamd-Queue-Id: 1CD6C1726 X-Rspamd-UID: 0f4c95 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=sEDwfQLp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D8F959404DF X-Spam-Score: -1.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: 23501XNElJ28 Hi Maxim, > Thanks for the initiative! It looks good, on first sight. One question > I have is this: does it rely on the Python package having been built > with setuptools/distutils? The Python world is moving toward a > plurality of PEP 517 compliant build systems; any idea if the checker > will continue working for these new packages? yes and no. pkg_resources is part of setuptools, so my patch depends on setuptools. But I think dependencies are specified in a standardized format[1], which any tool can (and should?) write. top_level.txt seems to be part of python eggs, which are deprecated[2]. I guess we could just scan for top-level directories under site-packages, which have a __init__.py and try to load them. I can’t find any standard for the entry points, so I’m guessing they’re setuptools-specific too. My assumption is that if no metadata is found the checks are just skipped and nothing bad happens, but we may have to verify this. As for PEP 517, I’m working on updating python-build-system, see https://lists.gnu.org/archive/html/guix-devel/2021-01/msg00294.html I’ll send an updated patch to guix-patches@ as soon as I have the 'check phase working. Cheers, Lars [1] https://packaging.python.org/specifications/core-metadata/#requires-dist-multiple-use [2] https://setuptools.readthedocs.io/en/latest/deprecated/python_eggs.html#top-level-txt-conflict-management-metadata