From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kMsuNG3VD2DAdQAA0tVLHw (envelope-from ) for ; Tue, 26 Jan 2021 08:40:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cPL0L23VD2AuTwAAbx9fmQ (envelope-from ) for ; Tue, 26 Jan 2021 08:40:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58F1E9404CA for ; Tue, 26 Jan 2021 08:40:13 +0000 (UTC) Received: from localhost ([::1]:37744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4JtU-0003IK-Az for larch@yhetil.org; Tue, 26 Jan 2021 03:40:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4JtK-0003I8-2K for guix-patches@gnu.org; Tue, 26 Jan 2021 03:40:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4JtJ-0004KT-R2 for guix-patches@gnu.org; Tue, 26 Jan 2021 03:40:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4JtJ-0007Wc-NY for guix-patches@gnu.org; Tue, 26 Jan 2021 03:40:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jan 2021 08:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161165037628888 (code B ref 45712); Tue, 26 Jan 2021 08:40:01 +0000 Received: (at 45712) by debbugs.gnu.org; 26 Jan 2021 08:39:36 +0000 Received: from localhost ([127.0.0.1]:40689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Jsu-0007Vs-0s for submit@debbugs.gnu.org; Tue, 26 Jan 2021 03:39:36 -0500 Received: from mout-p-202.mailbox.org ([80.241.56.172]:46242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Jsr-0007Va-3T for 45712@debbugs.gnu.org; Tue, 26 Jan 2021 03:39:34 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4DQ0XG6VH1zQlSP; Tue, 26 Jan 2021 09:39:26 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1611650365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MkXmZZGmps772wWZqkFIGPT5fcvnu6v08w5ioHzrKI0=; b=cBfkey35IyhSkUFUngI1RMCgjQlzd7Rm/ZOEL2axmP8XKeTH9Jo/qHYu6LqmurKYDISJZE f/kPYH/lzX2Deoykd1f0iJ/9usNmjujzUNKJwdB5LGUwKPmJKjgNSvzAPYwBOH/YQKViGm 6UbAHYh++c6T0dOehSuGBxb2kzyoEPc1oROxkUQJSQu7jZ266YY2G/tONr9sgyfAoDusWv LdyBySAhP9anOOBVKnwi6+7AsmSZ405HcZA3beZdjU4INDgBKxf+Y5O1UPy2jvDzpwmy/9 27KSbn58HEYNyUbj/pruJhJWH0/NIjUFmVtJPTYCBFI6MrIpgVcXTUEwSVhH6Q== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id haTgF2ammWIM; Tue, 26 Jan 2021 09:39:23 +0100 (CET) Date: Tue, 26 Jan 2021 09:39:22 +0100 From: Lars-Dominik Braun Message-ID: References: <87czxs3jel.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87czxs3jel.fsf_-_@gmail.com> X-MBO-SPAM-Probability: X-Rspamd-Score: -3.91 / 15.00 / 15.00 X-Rspamd-Queue-Id: EA91717A9 X-Rspamd-UID: 529c77 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=6xq.net header.s=MBO0001 header.b=cBfkey35; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 58F1E9404CA X-Spam-Score: -1.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4+ojThKqIPfa Hi Maxim, > Attached is a small rework of your original patch. I've made the Python > script standalone, which should make it easier to maintain. I've also > refactored the tests somewhat and added your copyright information. > Is this OK with you? sure, no problem with the refactoring in gerenal, but I think you used an old patchset. I sent a v2 to this issue, which had some changes to the scripts and tests. I can’t test your patch properly unfortunately, because `make check` does not work on core-updates and trying to build any Python package on core-updates triggers the requirements checker immediately: validating 'attrs' /gnu/store/hdjip92izsf9anfhd6ijgc9glvbi4dzv-python-attrs-bootstrap-19.3.0/lib/python3.9/site-packages ...checking requirements: ERROR: attrs==19.3.0 The 'attrs==19.3.0' distribution was not found and is required by the application”) Maybe that’s an issue with Python 3.9? Cheers, Lars