From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IMuZJaFid2BkyQAAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 23:46:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ANxFH6Fid2DFBAAAbx9fmQ (envelope-from ) for ; Wed, 14 Apr 2021 21:46:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BCF012A22 for ; Wed, 14 Apr 2021 23:46:09 +0200 (CEST) Received: from localhost ([::1]:43544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWnKq-0004E8-Fz for larch@yhetil.org; Wed, 14 Apr 2021 17:46:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWnKl-0004Dx-J7 for guix-patches@gnu.org; Wed, 14 Apr 2021 17:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWnKk-0006Zm-GZ for guix-patches@gnu.org; Wed, 14 Apr 2021 17:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWnKk-0001vJ-Bo for guix-patches@gnu.org; Wed, 14 Apr 2021 17:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1 Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Apr 2021 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47778 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: "47778@debbugs.gnu.org" <47778@debbugs.gnu.org> Received: via spool by 47778-submit@debbugs.gnu.org id=B47778.16184367177327 (code B ref 47778); Wed, 14 Apr 2021 21:46:02 +0000 Received: (at 47778) by debbugs.gnu.org; 14 Apr 2021 21:45:17 +0000 Received: from localhost ([127.0.0.1]:35950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWnK0-0001u7-NK for submit@debbugs.gnu.org; Wed, 14 Apr 2021 17:45:16 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:46464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWnJm-0001t1-M4 for 47778@debbugs.gnu.org; Wed, 14 Apr 2021 17:45:15 -0400 Date: Wed, 14 Apr 2021 21:44:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail3; t=1618436695; bh=QR+/LCofpqOBq95zdmHtJn1yxSKS34+kr5vQ7ab3HdU=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=oi1bMXX6+fAvwHRJ1WWUpaOk9EZ4x88cz8PezqgQJmH/PPfGcEDt1pyTg2h4Aqo+6 +w1Xzy+gigchnRxxce7E0VFlyouhtksftTHKJzEH7WkPV/BSUgh9JneFDWhe6DEioe Ikzfkef80TCV8SIWq0tdaEn9PFZjRKLF6wlpFd3I3bD8zH/8ZNfXAUAE1grSe4J3AT k0ayUkM26SWRYqyotzY8EBgwk/K5BZhcZKhES363qwK88DZuaQE8jOXs/RToUrxfKJ S0SqeTSRyA0MK3eRf04N4qRTj9Km2jXNyu21w2TgvvhhzokFBVCphbJ5sRt4bHbd/0 aKbPJ63BISXsw== From: Ekaitz Zarraga Message-ID: In-Reply-To: <4a8ff1b83b4d4580294833e421e34a52aa88a86e.camel@telenet.be> References: <4a8ff1b83b4d4580294833e421e34a52aa88a86e.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618436769; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QR+/LCofpqOBq95zdmHtJn1yxSKS34+kr5vQ7ab3HdU=; b=R1MenyLNxs0F0wGrdYDgHCkjMzHzeuQ7P3q4nrtL9FQImRkMdHmku1EOlDSB+d6IaxYmnf b9IKdtdQHnWX6/0+jKzQN/UoF1BsqAoJsDFZxTcmJhqBGQQq4k3HHyrJsInbY0IVtBajPn dFtSbq8Y/SPrBlx+/zKJ5L0JzmhX3mSbiuIBo+52xuWgV1O8bOO8jBj1B/PVyBoyxGeEfc DJvEHodH0MKDXLo0931/9OhAS2oaRBChdHcThlMAhM2t6v51AJn1xhPIkbh/LsD4FtDzJG o9wdPIUMhVDs1QmhiPOl3JUAoyLNS2AGn4Upeg0ixNCWadJn2pakNuex0Eq6lQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618436769; a=rsa-sha256; cv=none; b=SskXvJ9TKHTzBVMtnLxv02TyVuwcQJJi0wi0o2l7ZfROHBSmy0NzKwFimOVR5pWGsRzuuH WGpLtWkezW4mByd33kBCqWLFlGYCPreihJJiI4f3n3MBlWaeXNKiNUSJ3ItELkWTXH3T0P VhyMU+5btUKZkK7j+AZQMKYcOMLMvROIkfOZpOUWf6V8WnPnjqrhAEecn5ZmvPdCZ595Li TFXWEXdlFCEkBv/nzk/04+7z1BxS2BhPdtXSBzua3jbKMABvfLevWd6yI15KYOp3pgG2lX XCx0UhNH3HhVF1j86VLozBpoQKFrMOrE/dF+A/aSZkPeNUI7IzJiBU+Iq3Laxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=protonmail3 header.b=oi1bMXX6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=protonmail3 header.b=oi1bMXX6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3BCF012A22 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: EMj7rgdOgjmJ Hi, > > - `(#:tests? #f > > Why's that? =E2=80=98We=E2=80=99 prefer to have tests enabled when possib= le. > Please document why tests are disabled here (with a comment > #:tests? #f ; no tests / tests require dependency X, which is not package= d ...). I'll try to test the package with the tests, but they were disabled before too, so I didn't change that. > > - (add-before 'configure 'restore-pythonpath > > > - (lambda _ > > > - (substitute* "src/Main/MainGui.cpp" > > > - (("_?putenv\\\\(\\"PYTHONPATH=3D\\"\\\\);") "")) > > > - #t)) > > > > The #t can be removed. The warning that results when #t is absent > has been removed on the core-updates branch; we might as well stop > introducing these silly #t now such that we don't have to remove them > later. > > Greetings, > Maxme. Ok, I'll remove that and update the patch. Thanks!