From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iODNKMHKjWPuPQAAbAwnHQ (envelope-from ) for ; Mon, 05 Dec 2022 11:41:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YEvmJ8HKjWP0OwEAG6o9tA (envelope-from ) for ; Mon, 05 Dec 2022 11:41:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CB15A1B6 for ; Mon, 5 Dec 2022 11:41:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p28qO-0002T7-8m; Mon, 05 Dec 2022 05:37:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p28qM-0002Q7-S5 for guix-patches@gnu.org; Mon, 05 Dec 2022 05:37:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p28qM-0000aI-GU for guix-patches@gnu.org; Mon, 05 Dec 2022 05:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p28qM-0002hv-2n for guix-patches@gnu.org; Mon, 05 Dec 2022 05:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 10:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59661@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167023659210398 (code B ref 59661); Mon, 05 Dec 2022 10:37:02 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 10:36:32 +0000 Received: from localhost ([127.0.0.1]:35182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28pr-0002he-Sy for submit@debbugs.gnu.org; Mon, 05 Dec 2022 05:36:32 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:45762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28pp-0002hX-Bp for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 05:36:30 -0500 Received: by mail-ej1-f45.google.com with SMTP id fc4so19713267ejc.12 for <59661@debbugs.gnu.org>; Mon, 05 Dec 2022 02:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=HfhSojpXrrXW2/9sv67u+18VnuRuugIru0koAs+zXcM=; b=EEvME55sVaJ8iQkXx8UDHuOghKudopD1eREFzQcZIuo+kq4MRtpUju+SVBeKbhRZeH IGEPYoJec37pR5EEsiIMAJnIBWBTcp3jjR78nBcBkpPftGJYWo4y+rULtFF5iZIX9TsP jyqL/G/vdYz8++1gDWJblDCYVwp8VKMclaUbh9E7bIVk2GGxIU/uTjhFC8sk+THdDkC1 b/xl5SUgjPICalrxJ7MqTZ7Qnob0oOfKS24ZQKLnY/1fBxgfTNput2qUTuO/HuEc6QgL w3+2DmsEqQDya3HCKFJFovRlJXJhTKwmdRcREGNunqK7Ds8avBTTca0F3BN+HRPszmrq GHow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HfhSojpXrrXW2/9sv67u+18VnuRuugIru0koAs+zXcM=; b=QOqB1QQtmicIhMGKZtb33dzdcn92kL4Qnfk8GmZoXP5tHRHp2QLugdIjuu4LdzbYrB bzEAWNuVcFsaIi4kUHpv6jg6fsPASLMnWXHX8fryzxpKknPdrUqwQBA4ZCzIR0Qckl4s EtJ35EYaG6i6sK8vWmQZdu17s0hf3R4jWuzTx2O+tzat1zoCjuk2RHP6im87bbPhykAj dIIRvM0lPIeFa43qxd+Apu0AAFhrPZ4NNy3qEkyMIF4uBX+Ffc3AikqYXzQYbhAVi2mZ 6YBCyvE0kXOzhumFXoIurP/MNuuPG/Aq8ZQ+OuzI9Manf63CsqUv5aaE4d5RIQghB20D 1uqA== X-Gm-Message-State: ANoB5plEKDCQ8/AzzswW0WBm+w4eWxKyru5Eyv0fe/gxf6EouBa1hLIK 68GBB2OccPNMi60jxQjpHtA= X-Google-Smtp-Source: AA0mqf6j7jQsSUD24+IBVnBdg8gIaDiGCFsZjAbK4Qa271kFUDdwxjidbO32YACrcnMvPf3vawwcxg== X-Received: by 2002:a17:907:2c45:b0:7b8:bbbe:5ca with SMTP id hf5-20020a1709072c4500b007b8bbbe05camr52002286ejc.544.1670236583304; Mon, 05 Dec 2022 02:36:23 -0800 (PST) Received: from localhost ([2a02:ed3:914:3200:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id n9-20020aa7c449000000b004588ef795easm6098505edr.34.2022.12.05.02.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 02:36:22 -0800 (PST) Date: Mon, 5 Dec 2022 12:36:21 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer , 59661@debbugs.gnu.org References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MbHQEFkFJl1km2Fw" Content-Disposition: inline In-Reply-To: <875yernns5.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670236865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HfhSojpXrrXW2/9sv67u+18VnuRuugIru0koAs+zXcM=; b=iTKCmdgbjq/UP0q0qJwIWjW2SOHXmZNiNCm48tVVS/amWpukoCY+Emg/iWtBYASu3j9mXr cg/fJUicIYlTc927Z/gZQSFuoFDAl8MjG5nm0Y/WBfYx5Q1Rspm3FhlrdA088uDczEgDl/ G00/goX8WZGSIqXf8K8I6ZFtRq8y1DWOgG71U6TOoMaM9Nj/sFq7qSmrYNmd2I1iw+47Vn 1sDt2DSsdrVfPod9M65DvR9LT2x+jWIgD3DSkm1pXsVG0mKBu8iysEFvE88bmR7N2xiS/+ zcTxcw3u0msBRZSTf4Rl6wRXBOahBPr9IPUbB3nBTlbsYiW89O/+C+wBIpL8cw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670236865; a=rsa-sha256; cv=none; b=ENeIKcc58rIpRlJyCBuXlmL4bDAtsgyYf/CYq+APJ70sphB3l5oVI+z/ji5On0HbVhgy3W /5dDwDMc+6rtf8ukoWjSYM/X5feKI/yDDduhsEo7riLTBz9+INe/nc2fS7ZEqeu03a7kA0 kvBgfQLeyOD/PqzS3PqZwRPK1GpmoUAyrjIfG7JwamrB7/B2erw0SKsIXuMGGDsi1dXM4O D5kqsyPFvUjrn2Yc53m1VTUq816+VHgAumBFrML+so459DT0xCohR+ISa1eqARaFjDPAZC YHSqQYvzb9+2Nm98qEjA2kXpVRc3BzmatnlLHTdLxXoBDi8TGbZXS0o7giDkpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=EEvME55s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=EEvME55s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1CB15A1B6 X-Spam-Score: -1.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6e0jYxliu9UM --MbHQEFkFJl1km2Fw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 04, 2022 at 05:20:42PM +0100, Ludovic Court=C3=A8s wrote: > Hi, >=20 > Maxim Cournoyer skribis: >=20 > > Rationale: It is only used in INSTALLATION-OS and doesn't make sense to= be > > used in another context, given that file systems now automatically pull= their > > dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (ser= vices: > > Add file system utilities to profile). > > > > * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename = to... > > * gnu/system/install.scm (%installer-disk-utilities): ... this. > > (installation-os) [packages]: Adjust accordingly. >=20 > Efraim, this variable was added in > e6e076281e62518056987e9ddd3d96fccab20475 and used in > 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay = to > remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99t= create churn.) I looked back through the commits around there. The whole point was the following commit, to divide the longish haphazard list of packages into sets of a sort. If it's only used in (gnu system install) then I don't see a problem with moving it there. The closest I know of to another user of %base-packages-disk-utilities is my gparted guix image=C2=B9. > > +(define-deprecated %base-packages-disk-utilities #f '()) >=20 > =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I=E2= =80=99d make it: >=20 > (define-deprecated %base-packages-disk-utilities %base-packages '()) >=20 > This is not quite accurate but it should convey the idea. Would it be better to do (define-deprecated/alias-public %base-packages-disk-utilities %installer-disk-utilities) And remove the export from the list at the top of (gnu system)? =C2=B9 https://git.sr.ht/~efraim/guix-config/tree/master/item/gparted.scm --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MbHQEFkFJl1km2Fw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmONyaEACgkQQarn3Mo9 g1GjVBAAn3pWezvi0wZEUD6KO0W2mBD4y/bXLeSulmtjYn0iUumXrpjqhKB6k2Vq pMO1tgQlkVyVKbHJyOpeAKB7VNB6B9+g5ufLDjc4DjLFy8caP6m2ljSlHclqDH2C q3Q5U4gO6mRrSMqjUS/mxYO+u6z/mGNZaxQ0Kl0YwhbKUoiHj8vzVGcQ/zDGpKRq ElFztmRujy/unb2VKFTayIAZaAVahidaE8FCmmDJ5hZlrrhJ7i14J6kT3CVqlKiU wNc7H6Pq8uuQzzCrgFGIQ9DQKiUoAvkykw6wTIhTzhOfB9VAhmmDgTYLgrVAYTJi aes1v+EzSvx8w/oe2VRPVywNRTsZp97OEru+2Nb1ukTIXtG5aBoFPd/ZZttLQN8A OFPFGSJKqtRUN543ro96dgf0n+y8/5vhz4TeOAcHw8qwov7A62dZ2uzI2LAsIBVQ 9eInOHTzBzE6dgZyoN4Qa2718/Tibl++lc8vFRdyMAKMrUfawZ2t0S9HI4ZAtQqt WPciC8UACKpUPfOkhk7Ez0wrgp3xzltAbaFxLNAZg3xrqSHtlpwZhmnpsSbYCvDl r4Rfg/znyEaLFCZvdkTh5xb/QS60yc+3HpRItJ6gHrTqYHqAVqQfE7n0lW1xmgdE lxO2L6r/o9fN5iOYRr9naKnPdjQGlGM+koPGkLm35FvF7jLuA4k= =TKgl -----END PGP SIGNATURE----- --MbHQEFkFJl1km2Fw--