From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YCPtIB8eVmNUwwAAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 07:09:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MMK/IB8eVmPTBwEAauVa8A (envelope-from ) for ; Mon, 24 Oct 2022 07:09:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 240C62A9EB for ; Mon, 24 Oct 2022 07:09:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omlC5-00087t-3H for larch@yhetil.org; Sun, 23 Oct 2022 20:19:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omWpu-0006vf-IE for guix-patches@gnu.org; Sun, 23 Oct 2022 05:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omWpu-0000gU-9j for guix-patches@gnu.org; Sun, 23 Oct 2022 05:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omWpt-0001KD-Uk for guix-patches@gnu.org; Sun, 23 Oct 2022 05:00:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58614] [PATCH 000/187] Remove unused crates Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Oct 2022 09:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: Christopher Baines , 58614@debbugs.gnu.org Received: via spool by 58614-submit@debbugs.gnu.org id=B58614.16665155685017 (code B ref 58614); Sun, 23 Oct 2022 09:00:01 +0000 Received: (at 58614) by debbugs.gnu.org; 23 Oct 2022 08:59:28 +0000 Received: from localhost ([127.0.0.1]:42832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omWpL-0001Ir-RY for submit@debbugs.gnu.org; Sun, 23 Oct 2022 04:59:28 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:41853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omWpC-0001IV-Dy for 58614@debbugs.gnu.org; Sun, 23 Oct 2022 04:59:26 -0400 Received: by mail-wr1-f43.google.com with SMTP id bu30so11133492wrb.8 for <58614@debbugs.gnu.org>; Sun, 23 Oct 2022 01:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=WNw+aaDvqwk4y62CExbPnrAZaCb6RFUgTQHXkJyfe4s=; b=Er4y4ZECTcs/CNlXnEV0dAo0bvdnT0l63WRX3Xi08R35VCsohSLe1KdqGbqoGtq8CN C8WIp2gmG3hpYgUEInVMFk++PDNhSno9Nw/qXtkmgfoBTaPTwNTItvqr5NMlWMhaBXEA lWRSQTzA2bSi9a2ebRBIIy8soQKIQ7oewX3bODlG5AXB95qTuCXGSI+vhfQaUuULFc4e +kjy66AhdiHswzBvtTorJlFzaX2OAYidRT13qjedDOFWBcBLk5jmKJmq15ViyHwoz8B+ 6Cxbe5kShsTcCDCv+vHKXy8CB3crPt4xv6fWdisITpOLbYC74VXrNh+F0uGh4z+OKIV/ ZQpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WNw+aaDvqwk4y62CExbPnrAZaCb6RFUgTQHXkJyfe4s=; b=EH7kERwOCrYNq1V3YbaNqh5xEVWYNFatKIEjsmxq1pB9EaxLopkgSvvhdqgGC6GkqT BV4OCm98HO1CMyINiRQJeyFIxh4YAUOLnhqy5vyK2Xz6EBL2xHzAhx6xeD5mzlgGVuQC rtEzMdgTMrRDZ9TqnBAepqtDg8AIB5IhzWKciFvWuIfK8xUAYz2iXX/+g76Q+hPX9pBt or6CEp5ICFrM7VIKrq9DHQOc2W3dOE+xxWXsfb/AYE5OuaTc967eZQZp0F20BbVyBHkU NMa1RquN3kvmpBspaaqfCQ9A0ByFJyH27j88sPtw4H26e2X7rZ2WcRhnYAl6dUPrlnZW O/3Q== X-Gm-Message-State: ACrzQf3DfX9bMFcNq286tyw/8rsIKMwsq3XWYzbQNBeHc7/hYUSDfRA/ 79RRyosfBGVVtxFdjEa9XWM= X-Google-Smtp-Source: AMsMyM4vGumBp+N3xXkzp8/SwfDHdDjomgQx61IC3XKCcqR2vkt+qbuwaB/RUn/nHDNR34uiRsY5lQ== X-Received: by 2002:adf:f491:0:b0:235:894e:8d6c with SMTP id l17-20020adff491000000b00235894e8d6cmr11318955wro.209.1666515552237; Sun, 23 Oct 2022 01:59:12 -0700 (PDT) Received: from localhost ([141.226.13.62]) by smtp.gmail.com with ESMTPSA id j18-20020a5d6192000000b002366dd0e030sm693718wru.68.2022.10.23.01.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Oct 2022 01:59:11 -0700 (PDT) Date: Sun, 23 Oct 2022 11:58:57 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Julien Lepiller , Christopher Baines , 58614@debbugs.gnu.org References: <878rl9i1tw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nd/P3F+uiv1Auk0X" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666588191; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WNw+aaDvqwk4y62CExbPnrAZaCb6RFUgTQHXkJyfe4s=; b=uN61KnBFmRBqwdfVm2LFiW/hB5QSOrR4XIlH0Kg838EAUo1FTqgeDBBigFz4+3p79p7qFm /juhSpwgq2po+OekjLFUaQgMVAlAvEUvd+owoHICgsw2VYat+HZhSTt1365JO6EVlYTORp uxaJTAFqaROqzX5x+wPamDrd/BzSMe/JWnnxtid6ZoxYoFM66V4fIzCBlp4S6DfFct0Ptv UN3V9zT6fa1H+6dyWx845wNR3DHRraS/zLtaY7zM47f6m/8LACmupYpXFXleehQm/5D6cS UspY0vLxWrQVL5/TtZBojJ1BPJl+r1GWDFhstmOfJDsS+w8dCEJjVZevcr+MNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666588191; a=rsa-sha256; cv=none; b=rzOmVTw1mfxdUB+mY661eVT/WvQ7TAC/K5eoJCVk9ClXKyQIqESTHgUyxdfTvvpNlPQ5tk BcpSZvibCULObIABQAHp+il8PdcteNhIRLJAlQ0rpJtDkWFtQkjxpiHdeDNOwCHpupYgvx oEJastzoMRKfZcXu1BIUU8RzppMoZY77ItgPJQrrO9SvOypVDr/GbC3yd0baR1+EbNniCH BARgXvHo6IqZx9qBdwaUtZx2iSIyrMYO+L8QT0meykR23J3qX78TBgXbHYUAkm2RIhFa94 nAQ6iIEmoItJbGSG8iTauM+vyV4m1jDAw6q01Noyhm4ng0t91m8U7Kb+XUrZug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Er4y4ZEC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Er4y4ZEC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 240C62A9EB X-Spam-Score: 4.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: aDkTA9Ffiv2r --nd/P3F+uiv1Auk0X Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2022 at 11:26:21PM +0200, Julien Lepiller wrote: > I propably didn't ask my question properly. How were those crates selecte= d for removal? >=20 > From your answer, it seems that being a leaf package was the only criteri= a. But there are useful leaf packages. >=20 > So, are there other criteria, or did you manually review them to ensure t= he packages are no longer useful? Or are crates generally not useful if not= hing depends on them, in which case, what is a crate? They are all leaf packages. I made sure to only grab packages which were in the crates-* modules, so none of the rust-apps or sequoia or syndication or gnome or others. I took another look through the packages, rust-swc-1 is a typescript transpiler, rust-news-flash-1 is used by a 'NewsFlash feed reader', rust-libpijul-0.12 for pijul VCS repositories. rust-swc-1 was added October 2020 rust-news-flash-1 was added November 2021 rust-libpijul-0.12 was added June 2020 rust-swc-1 doesn't currently build, but can probably be fixed and moved to rust-apps. rust-news-flash-1 is up-to-date with upstream but doesn't currently build rust-libpijul-0.12 doesn't produce a shared or static library and I don't think there's been more work to continue past where it is. so for now let's keep those 3 and move rust-swc-1 to rust-apps (and rename to rust-swc). As far as 'what is a crate', in general it is a source tarball which can be built on its own or used (in source form) to build another package. In order to track dependencies we've been using #:cargo-inputs and #:cargo-development-inputs as a rough translation from inputs and native-inputs. I hope by removing enough leaf crates we can untangle some of the dependency circles, disable some tests on some crates to clear other dependency circles, and try to bring the explosion of crates under control, so we mostly have "useful crates" and not "historical crates". > Le 22 octobre 2022 21:35:22 GMT+02:00, Efraim Flashner a =C3=A9crit=C2=A0: > >On Sat, Oct 22, 2022 at 07:49:34AM +0200, Julien Lepiller wrote: > >> I'm wondering why we want to do that? Are those outdated maybe? At thi= s rate we'll remove all crates :) > > > >Would it be that bad? :) > > > >The cargo ecosystem relies pretty heavily on semver and due to the > >upgrade cycle we don't always remove old crates when nothing else > >depends on them. I'd guess that some of them might be part of an > >upstream-all-dependencies move (which I've done before) and most of them > >are probably just outdated. > > > >> Le 21 octobre 2022 18:21:47 GMT+02:00, Christopher Baines a =C3=A9crit=C2=A0: > >> > > >> >Efraim Flashner writes: > >> > > >> >> This is round 1 of removing unreferenced crates. All of the crates > >> >> removed _should_ have no dependencies inside Guix proper. I used the > >> >> command listed below and then manually searched for the lines ending > >> >> with ':1' and made sure the package definition was the only referen= ce to > >> >> that package. > >> >> > >> >> grep define-public gnu/packages/crates-*scm | \ > >> >> awk '{print $NF}' | xargs -I{} sh -c 'echo {} && git grep -c {}' > >> >> > >> >> I then removed all the packages and rebuilt all the modules which u= sed > >> >> the cargo-build-system somewhere inside them and rebuilt all the > >> >> modules. > >> >> > >> >> git grep -c cargo-build-system | cut -f1 -d':' | grep \\.scm$ | \ > >> >> sed -e 's/scm/go/' | xargs -n1 rm > >> >> > >> >> Efraim Flashner (187): > > > >> >> > >> >> gnu/packages/crates-graphics.scm | 187 -- > >> >> gnu/packages/crates-gtk.scm | 59 - > >> >> gnu/packages/crates-io.scm | 4645 --------------------------= ---- > >> >> 3 files changed, 4891 deletions(-) > >> >> > >> >> > >> >> base-commit: 3bb145b6e2a8c84e7739ead9ae76dc4d42bb9850 > >> > > >> >This looks good to me: https://qa.guix.gnu.org/issue/58614 > >> > > >> >Thanks, > >> > > >> >Chris > > > >--=20 > >Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 > >GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > >Confidentiality cannot be guaranteed on emails sent or received unencryp= ted --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --nd/P3F+uiv1Auk0X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmNVAkoACgkQQarn3Mo9 g1HgJA/9GxQGAraswCnW+y5DobmQJQAa2mUu4KhaA8ed5SnQzMs1b59S1XPFYPNX wJVhTVyLM3lENjmeW8bd09XOiaM9hczmMCE+UZDMYvRWtQg+yG5ksZZQrjP3bGzL rNnjtR8CD8Rfjo6U1qafa/ybuR9yWDmLWYzmBx3njEUXHHiHMsZFwiVWpEvG8dW7 0aURgprkV234dFlH8FB8OMNxU+vjVRJVi7dRhStnJCXPR9JlSOUSTxft+s7iIWT/ axCFVTqSDzrAKYSvAzSMcXwSGPbdiLWh8mqJpZVmVs6KpD3yQKJ+5OcrJgQCrttw EGWfqEHGx53eUJ7JsuhoGGPhC05DuPeOPfvdsgZB+KLqvWJwIuc+HrRi4d8lqcsW LdVdRAdhRs1CGvUl1YCsKpsoqSlVgQcjufzqhtg8DG+YJiV+RWhmP1bPV1jHM5N1 G+xJsjDsiy2f10YOdYOgioZMGi2wHzyZ3oKpxOwQyy0ygkVyxtdhBoGFbJfX7uOa dSsVRLS8Al795RS7iYmtIkKlmwAEp+QaCPQLngihU6Ne0mXfHD8latTQRirvq03n PZV3ASqKiqSB0mx1ktKwxouSuSgNVbr7ShQszF9z11BXvwwHqGKdDpUKPKLULDfc bwpf5Z2x7Zvg6+aAeVyVf8F8Y9YGs3C97EneE7xqUs1+E4qC4Uw= =XNx8 -----END PGP SIGNATURE----- --nd/P3F+uiv1Auk0X--