From: Efraim Flashner <efraim@flashner.co.il>
To: Mark H Weaver <mhw@netris.org>
Cc: 57788@debbugs.gnu.org
Subject: [bug#57788] [PATCH] gnu: rust: Disable debug info to reduce build requirements
Date: Sat, 29 Oct 2022 22:39:59 +0300 [thread overview]
Message-ID: <Y12Bj7UVIvHGHqQG@3900XT> (raw)
In-Reply-To: <87wn8kfcy1.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]
On Fri, Oct 28, 2022 at 06:40:27AM -0400, Mark H Weaver wrote:
> Hi Efraim,
>
> I was surprised to see commit 01be1973f464cb81cdece54f7858f0dee46abb50
> attributed solely to me, although I did not actually author that commit.
>
> In the future, please do not attribute commits to me that I did not
> write or approve of. At minimum, if you modify a commit that I
> proposed, please add a "Modified-by" line in the commit log. If you
> made radical changes to a commit that I proposed, better to list
> yourself as author and maybe say "based on a proposal by Mark H Weaver"
> in the commit log.
>
> One important modification that got lost in your simplified commit was
> the change I made to mrustc/tools/minicargo/build.cpp, which I evidently
> found necessary. Without that change, I do not know if Rust can still
> be bootstrapped on a small machine such as mine.
>
> Anyway, thanks for working on it, and for the other important work
> you've done on dramatically shortening the Rust bootstrap.
>
> Regards,
> Mark
Sorry about that, I was modifying as I went and after updating mrustc to
a later commit the "if (true) add '-g'" spots in mrustc got changed to
depend on enabling debug, and I found that after removing -g from the
makefiles it wasn't being added anymore. I'll make sure to be more
careful in the future about commit attribution.
About mrustc/tools/minicargo/build.cpp, it looked to me like that was
specifically about building mrustc using the codeblocks IDE.
I've tried to rebuild rust-1.54 on my pine64, which has 2GB of ram and
4GB of swap and that didn't seem to be enough so I'm retrying that with
just 1 core. I'm also trying on my pinebook pro, with 4GB of ram and 6GB
of swap and I'll see if it works there or if it needs more tuning.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-29 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 23:56 [bug#57788] [PATCH] gnu: rust: Disable debug info to reduce build requirements Mark H Weaver
2022-10-07 10:36 ` Efraim Flashner
2022-10-07 22:04 ` Mark H Weaver
2022-10-12 10:45 ` Efraim Flashner
2022-10-28 10:40 ` Mark H Weaver
2022-10-29 19:39 ` Efraim Flashner [this message]
2022-11-01 5:11 ` Mark H Weaver
2022-11-01 5:13 ` bug#57788: " Mark H Weaver
2022-10-09 12:38 ` [bug#57788] " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y12Bj7UVIvHGHqQG@3900XT \
--to=efraim@flashner.co.il \
--cc=57788@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).