unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Joseph LaFreniere <joseph@lafreniere.xyz>
Cc: 44762@debbugs.gnu.org
Subject: [bug#44762] [PATCH 37/37] gnu: Add ripgrep-all.
Date: Sat, 12 Dec 2020 22:19:12 +0200	[thread overview]
Message-ID: <X9UlwNJnA998UCOf@E5400> (raw)
In-Reply-To: <20201120142716.41949-37-joseph@lafreniere.xyz>

[-- Attachment #1: Type: text/plain, Size: 2351 bytes --]

I've had reviewing these patches on my TODO for a while, finally made it
around to it.

On Fri, Nov 20, 2020 at 08:27:16AM -0600, Joseph LaFreniere wrote:
> * gnu/packages/rust-apps.scm (ripgrep-all): New variable.
> ---
>  gnu/packages/rust-apps.scm | 80 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 79 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
> +         (add-after 'unpack 'enable-unstable-features
> +           (lambda _
> +             (setenv "RUSTC_BOOTSTRAP" "1")
> +             #t)))))

Is this necessary, or is it because we were using an older version of
rust for building packages?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("xz" ,xz)))
> +    (propagated-inputs
> +     `(("ffmpeg" ,ffmpeg)
> +       ("pandoc" ,pandoc)
> +       ("poppler" ,poppler)
> +       ("ripgrep" ,ripgrep)
> +       ("sqlite" ,sqlite)
> +       ("tar" ,tar)
> +       ("unzip" ,unzip)
> +       ("zip" ,zip)))

We prefer to not propagate packages, and in particular I try not to use
pandoc as an input because it limits the package to architectures that
can build haskell programs. Looking through the code a bit it looks like
it shells out to the commands. So it'd be better to substitute the
commands to the full path name of the package (what I'd suggest for
ripgrep) and/or adding a note to the description suggesting that people
also install some of the other packages for more features.

> +    (home-page "https://github.com/phiresky/ripgrep-all")
> +    (synopsis "Wrapper around @code{ripgrep} with support for rich file types")
> +    (description
> +     "ripgrep-all (rga) is a line-oriented search tool that allows you to look
> +for a regex in a multitude of file types.  rga wraps @code{ripgrep} and
> +enables it to search in @file{pdf}, @file{docx}, @file{sqlite}, @file{jpg},
> +movie subtitles (@file{mkv}, @file{mp4}), etc.")
> +    (license license:agpl3+)))
> +
>  (define-public rust-cbindgen
>    (package
>      (name "rust-cbindgen")
> -- 
> 2.29.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2020-12-12 20:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 14:15 [bug#44762] [PATCH 00/37] " Joseph LaFreniere
2020-11-20 14:26 ` [bug#44762] [PATCH 01/37] gnu: Add rust-hashbrown-0.1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 02/37] gnu: rust-anyhow-1.0: Update to 1.0.34 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 03/37] gnu: Add rust-escargot-0.3 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 04/37] gnu: Add rust-predicates-core-0.9 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 05/37] gnu: Add rust-predicates-tree-0.9 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 06/37] gnu: Add rust-normalize-line-endings-0.2 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 07/37] gnu: Add rust-predicates-0.9 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 08/37] gnu: Add rust-assert-cmd-0.9 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 09/37] gnu: Add rust-automod-1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 10/37] gnu: Add rust-bincode-0.8 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 11/37] gnu: Add rust-bindgen-0.46 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 12/37] gnu: Add rust-bzip2-0.4 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 13/37] gnu: Add rust-cachedir-0.1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 14/37] gnu: Add rust-cfg-if-1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 15/37] gnu: rust-chrono-0.4: Update to 0.4.19 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 16/37] gnu: rust-derive-more-0.99: Update to 0.99.11 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 17/37] gnu: Add rust-dirs-sys-next-0.1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 18/37] gnu: Add rust-dirs-next-1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 19/37] gnu: Add rust-directories-next-1 Joseph LaFreniere
2020-11-20 14:26   ` [bug#44762] [PATCH 20/37] gnu: Add rust-exitfailure-0.5 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 21/37] gnu: Add rust-float-cmp-0.4 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 22/37] gnu: Add rust-tabwriter-1 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 23/37] gnu: Add rust-size-format-1 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 24/37] gnu: Add rust-nom-2 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 25/37] gnu: Add rust-lmdb-rkv-sys-0.11 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 26/37] gnu: Add rust-lmdb-rkv-0.14 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 27/37] gnu: Add rust-libsqlite3-sys-0.18 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 28/37] gnu: Add rust-serde-stacker-0.1 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 29/37] gnu: rust-serde-json-1: Update to 1.0.59 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 30/37] gnu: Add rust-rusqlite-0.23 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 31/37] gnu: Add rust-packed-simd-2-0.3 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 32/37] gnu: Add rust-pure-rust-locales-0.5 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 33/37] gnu: Add rust-rkv-0.10 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 34/37] gnu: Add rust-tree-magic-fork-0.2 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 35/37] gnu: rust-encoding-rs-0.8: Update to 0.8.26 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 36/37] gnu: rust-lzma-sys-0.1: Update to 0.1.17 Joseph LaFreniere
2020-11-20 14:27   ` [bug#44762] [PATCH 37/37] gnu: Add ripgrep-all Joseph LaFreniere
2020-12-12 20:19     ` Efraim Flashner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9UlwNJnA998UCOf@E5400 \
    --to=efraim@flashner.co.il \
    --cc=44762@debbugs.gnu.org \
    --cc=joseph@lafreniere.xyz \
    --subject='Re: [bug#44762] [PATCH 37/37] gnu: Add ripgrep-all.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).