From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IKBhM1hn0l9QbAAA0tVLHw (envelope-from ) for ; Thu, 10 Dec 2020 18:22:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yP8mL1hn0l+qMwAAbx9fmQ (envelope-from ) for ; Thu, 10 Dec 2020 18:22:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E79E09400D3 for ; Thu, 10 Dec 2020 18:22:15 +0000 (UTC) Received: from localhost ([::1]:33710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knQZy-0000yK-Ow for larch@yhetil.org; Thu, 10 Dec 2020 13:22:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knQZm-0000xr-RU for guix-patches@gnu.org; Thu, 10 Dec 2020 13:22:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knQZm-00069n-Ke for guix-patches@gnu.org; Thu, 10 Dec 2020 13:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knQZm-0003OW-GV for guix-patches@gnu.org; Thu, 10 Dec 2020 13:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45151] [PATCH 1/1] gnu: Add openfortivpn Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Dec 2020 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45151 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Dashyan Received: via spool by 45151-submit@debbugs.gnu.org id=B45151.160762447112980 (code B ref 45151); Thu, 10 Dec 2020 18:22:02 +0000 Received: (at 45151) by debbugs.gnu.org; 10 Dec 2020 18:21:11 +0000 Received: from localhost ([127.0.0.1]:39254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knQYx-0003NI-8H for submit@debbugs.gnu.org; Thu, 10 Dec 2020 13:21:11 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:46047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knQYs-0003MS-Sb for 45151@debbugs.gnu.org; Thu, 10 Dec 2020 13:21:10 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 930365C004B; Thu, 10 Dec 2020 13:21:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 10 Dec 2020 13:21:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=LJHq9BCV3pFSB8hwMESdMnB85qELfyXcCgA8eT4J6sc=; b=u7jW1HsIlpmQ yCaR8UkZLgZjZZuhlaKu/Yir1oweCoCcLlJnQAl66Wtyv+w0oiANNLmst8vH4W8t mtshUhmVJTHaSFZ9udOHM0ypKIzYvjLn/6ffGAQTFFGIAw3UXKFaNpOpL5CIKnF4 ihU0fSGsBfgXSplNZdyPVSlN1Uwthsg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=LJHq9BCV3pFSB8hwMESdMnB85qELfyXcCgA8eT4J6 sc=; b=UeC5ETR5vYlfgoOuFT2uZTd07ed4djK9l+GcVEPb+m+B512dUNPyo34HF IXdzq9Q+2fRrLXecw+F+T2tEcAlUIahJgtWza/ENyjSburKt77JdDgF07ZA2ZShb kQfqTwG8r+nA2vnau5Qbu10LfkkiuHQ/aCMKiyrkDj6bR45lLpIIyTkCFD+Xtj7U cisf/ec3RWfPi1ktt3wmkD3Iu+FcprUpgd75hCFxBOlFJkk1NVM1DGxKMuYUmCwB wHuxEcsklQPyXoTuFbdq99eTEgw6K2ifF4A+vbUwU9qj7dlAgrX9KJiez9DCa9RX vtpjZJWM648prC50QfEbOgIT5aIUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudektddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtugfgjgesth ekredttddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhu lhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephefgvedvhfeljeetudffleevue eliedtveekfeevhefffeeutdelvedvjeeiffelnecuffhomhgrihhnpehophgvnhhvphhn rdhnvghtnecukfhppeejfedrudeguddruddvjedrudegieenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgr mhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id D819924005A; Thu, 10 Dec 2020 13:20:59 -0500 (EST) Date: Thu, 10 Dec 2020 13:20:58 -0500 From: Leo Famulari Message-ID: References: <20201209214123.27762-1-mail@davie.li> <20201209225553.28596-1-mail@davie.li> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201209225553.28596-1-mail@davie.li> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45151@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=u7jW1HsI; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=UeC5ETR5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E79E09400D3 X-Spam-Score: -1.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: VmL5XJjEEMYF On Thu, Dec 10, 2020 at 01:55:53AM +0300, David Dashyan wrote: > +(define-public openfortivpn Thanks! Overall, looks good to me. > + (native-inputs > + `(("openssl" ,openssl) > + ("autoconf" ,autoconf) > + ("autotools" ,automake) > + ("pkg-config" ,pkg-config))) In general, native-inputs are dependencies that are only used while building the package. Typically, OpenSSL is also used at run-time, so it probably should be a regular input. What do you think? > + (propagated-inputs > + `(("ppp" ,ppp))) Propagated-inputs are dependencies that will be installed along with your package when installing the package with e.g. `guix install openfortivpn`. This is for situations where the dependency is needed at run-time but for which the program lacks the ability to refer to dependencies directly. For example, a shell script that needs to invoke `ls` will need to find it on $PATH. It would not be easy to automatically substitute calls to `ls` to the full store path of `/gnu/store/...-coreutils-8.32/bin/ls`. However, most dependencies can be regular inputs, because the built package will refer to the full "/gnu/store/...-ppp-version/" path wherever it needs to invoke the dependency. So, does the package work if the openssl and ppp dependencies are just 'inputs' rather than native-inputs and propagated-inputs? You can use `guix gc --references $(guix build openfortinet)` to see what store references the built package has kept. These references are literally just strings that look like filenames in /gnu/store, found by scanning when the package build is completed. This tool can help one decide if an input should be propagated — if the built package refers to ppp, it likely can find it without propagation. Of course, practical testing is still the true measure. I hope that helps! > + (home-page "https://openvpn.net/") Is this the "home-page" of this program? Usually this field points to the site where the project is coordinated or marketed. It may even be the GitHub repo page. Can you send a revised patch based on this feedback? Please don't hesitate to ask any followup questions :)