From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id I9aZJTrKy18BHAAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 17:58:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kOzfIDrKy18SOQAAB5/wlQ (envelope-from ) for ; Sat, 05 Dec 2020 17:58:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7C2B94011A for ; Sat, 5 Dec 2020 17:58:16 +0000 (UTC) Received: from localhost ([::1]:34602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klbp1-0003cd-L6 for larch@yhetil.org; Sat, 05 Dec 2020 12:58:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klboo-0003cO-OH for guix-patches@gnu.org; Sat, 05 Dec 2020 12:58:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klboo-0000Xs-Gu for guix-patches@gnu.org; Sat, 05 Dec 2020 12:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klboo-0008NK-GU for guix-patches@gnu.org; Sat, 05 Dec 2020 12:58:02 -0500 Subject: bug#44821: [PATCH v4] gnu: Add diff-so-fancy. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44821 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: EuAndreh Cc: 44821-done@debbugs.gnu.org Mail-Followup-To: 44821@debbugs.gnu.org, leo@famulari.name, eu@euandre.org Received: via spool by 44821-done@debbugs.gnu.org id=D44821.160719102732125 (code D ref 44821); Sat, 05 Dec 2020 17:58:02 +0000 Received: (at 44821-done) by debbugs.gnu.org; 5 Dec 2020 17:57:07 +0000 Received: from localhost ([127.0.0.1]:48167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klbnv-0008M4-BV for submit@debbugs.gnu.org; Sat, 05 Dec 2020 12:57:07 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:45221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klbnt-0008LZ-Rw for 44821-done@debbugs.gnu.org; Sat, 05 Dec 2020 12:57:06 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CB440B70; Sat, 5 Dec 2020 12:56:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 05 Dec 2020 12:57:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=DBJjW8pg7qY1pPjQ7qFIg3h8 nBYeSft4ttNRRhEUei0=; b=KLOlATA1oFb2jhLtXxzhaboEf8XxSjuDzcjLWuKN S/6TCNwW/6mzzdzuMyUgCCZd98jG/HhRAa4orR3nF/cKYKN5hLywoZwkN6E3CG5B 2pa2CMd475z5B2g2npcsvulWECxNM8KyZOoH+THRfWH46KvsZIziEHStU3VYT2WA +KI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DBJjW8 pg7qY1pPjQ7qFIg3h8nBYeSft4ttNRRhEUei0=; b=qUdJwG7ShE90/2pVHZqDFe q8Odwkf08nTeBL50Hf8QBzt38TcP9hpksMh5YT5kAVJhZTaW9bYAJ+0n8yQjFZrW HkB/3ym00743oek+uq8YrC4FNWKx66t2+F/YmNiR+e/VH9a/07g8cqbiCHtrEU7r o75/P5Yk63GJp58V6koc7rYapKK0RUawnO4OUR+PEsCdb6ljIFYgfPsCAbkoWFun cH0AnHE338k4WR2o/fFPW3MLWth1UoWteDTdmgf+7pE33qaDPoqHyTFsCX0r4qbr tqbdXWoEpwTg8FflaVYWNByYayQXa8a+Fp19xAoKe3KddoseiISLty3oXRfiC2tA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejtddguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucfkphepjeefrddugedurdduvdejrddu geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id DB5D024005A; Sat, 5 Dec 2020 12:56:58 -0500 (EST) Date: Sat, 5 Dec 2020 12:56:56 -0500 From: Leo Famulari Message-ID: References: <20201205115542.15427-1-eu@euandre.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201205115542.15427-1-eu@euandre.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=KLOlATA1; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=qUdJwG7S; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A7C2B94011A X-Spam-Score: -1.30 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: BL5agXbKSKjK On Sat, Dec 05, 2020 at 08:55:42AM -0300, EuAndreh wrote: > From: Leo Famulari > > * gnu/packages/version-control.scm (diff-so-fancy): New variable. > --- > Thanks for the revised patch. The only thing missing was the proper > escaping of the substituted path: > (string-append "use lib '" lib "';\n"))) > > The lib path had to be between quotes, with a final semicolon. > > I've taken yours and only fixed this part. I've tested it, and it works. Great! Pushed as 32a3367930844b242b57ea634c2de43e4ea3b57b