From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6HKRBOwnxV/jIgAA0tVLHw (envelope-from ) for ; Mon, 30 Nov 2020 17:12:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ENtfAOwnxV9dEwAA1q6Kng (envelope-from ) for ; Mon, 30 Nov 2020 17:12:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AADB69403EC for ; Mon, 30 Nov 2020 17:12:11 +0000 (UTC) Received: from localhost ([::1]:54978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjmig-0001fC-NF for larch@yhetil.org; Mon, 30 Nov 2020 12:12:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjmiY-0001dc-P4 for guix-patches@gnu.org; Mon, 30 Nov 2020 12:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjmiY-0000Au-FY for guix-patches@gnu.org; Mon, 30 Nov 2020 12:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjmiY-00039t-9S for guix-patches@gnu.org; Mon, 30 Nov 2020 12:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44958] [PATCH 1/2] gnu: Add python-pytaglib. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Nov 2020 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44958 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 44958@debbugs.gnu.org Received: via spool by 44958-submit@debbugs.gnu.org id=B44958.160675629312099 (code B ref 44958); Mon, 30 Nov 2020 17:12:02 +0000 Received: (at 44958) by debbugs.gnu.org; 30 Nov 2020 17:11:33 +0000 Received: from localhost ([127.0.0.1]:56514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjmi5-000394-B8 for submit@debbugs.gnu.org; Mon, 30 Nov 2020 12:11:33 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjmi3-00038m-Ee for 44958@debbugs.gnu.org; Mon, 30 Nov 2020 12:11:32 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2FCA05C0062; Mon, 30 Nov 2020 12:11:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 30 Nov 2020 12:11:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Rvlnht2Z7GkfPmxSirRMon8H 93ryDApyTICA+tZH7Fs=; b=eYZMGH4s1DYK4J3ThcS9eVnrp/k1/rznUC60gwUe T9gVh2P8X2H5MP7PvqX7l4uaaOom9dlzDIS2V8x669KL3jlzxNzWiXCPJVFj8Nvw exLc8/YyUjeVonBAHxH7p4G49GlTyuuK48jLGcr2OE5x9nDtXocH+QlpHhlNK+jw 0Zs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Rvlnht 2Z7GkfPmxSirRMon8H93ryDApyTICA+tZH7Fs=; b=WNV3oWSqcVS2+jxsTfFxCw 56/HdXRa3hJi2gILHyK4+fqYRI7+wRyEtYNqxFp8b0Mv6HLKDEgmXyq9rkl7iaRb s7lrkLfI6Y9p2G61C0IDeYJqte6mmWjga8m9Dvlw/Sk6HVA0heNEvE8yI1O4Atoo BM5VNeNAp89cAhPDq2zjGdbsU56ZLm7BL9/oiQlthhW0dIQ4os9xZkABinFInhTJ sIHwV8tYnT1wW1uOUSPf89GsPe3rfWXXoC6jUWKZpwdNiYskjIh8wYnoymPXIl2G FCJUH5jJzI11aJoFzTuL3znaR+atRmFnpv99EI3c92pvQuxjfbjwoqnpvm0tg0dg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeitddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeehgfelvefhtddtfeehiedtgfehffffffelvdelhffgkedtteehgfeugfehgeet hfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeejfedrudeguddruddvje drudegieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id B87823064AA6; Mon, 30 Nov 2020 12:11:25 -0500 (EST) Date: Mon, 30 Nov 2020 12:11:23 -0500 From: Leo Famulari Message-ID: References: <20201130104752.8601-1-mjbecze@riseup.net> <20201130105047.8755-1-mjbecze@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130105047.8755-1-mjbecze@riseup.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.28 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=eYZMGH4s; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=WNV3oWSq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: AADB69403EC X-Spam-Score: -1.28 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: 7smGilIbImcE On Mon, Nov 30, 2020 at 04:50:46AM -0600, Martin Becze wrote: > * gnu/packages/mp3.scm (python-pytaglib): New variable. Thanks! I applied your patch along with these changes, explained below: ------ diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 487117cc7d..e622f703d3 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -602,17 +602,31 @@ fingerprinting library and the Acoustid API.") (uri (pypi-uri "pytaglib" version)) (sha256 (base32 - "0li970qslfymz4vk1wrij2nfqw3l15cpc3fjjci48mpvg17gbnhn")))) + "0li970qslfymz4vk1wrij2nfqw3l15cpc3fjjci48mpvg17gbnhn")) + ;; Delete file generated by Cython. + (modules '((guix build utils))) + (snippet + '(begin + (delete-file "src/taglib.cpp"))))) (build-system python-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + ;; Ensure that the Cython file is regenerated. + (add-after 'unpack 'setup-environment + (lambda _ + (setenv "PYTAGLIB_CYTHONIZE" "1")))))) (native-inputs - `(("taglib" ,taglib) + `(("python-cython" ,python-cython) ("python-pytest" ,python-pytest))) + (inputs + `(("taglib" ,taglib))) (home-page "https://github.com/supermihi/pytaglib") (synopsis - "Python binding for taglib") + "Python bindings for taglib") (description "This package is a Python audio tagging library. It is cross-platform, works with all Python versions, and is very -simple to use yet fully feature.") +simple to use yet fully featured.") (license license:gpl3+))) ------ In general, we try not to use "pre-built" C and C++ files that are created by Cython. They are not really considered "source code" because they are not in the format preferred for editing. I moved the taglib dependency from native-inputs to inputs, because it is still referred to by the built pytaglib: ------ $ guix gc --references $(./pre-inst-env guix build --no-grafts python-pytaglib) | grep taglib-1.12 /gnu/store/b12szz8wy7wxvfv2jfj5ygqkgqar03ih-taglib-1.12-beta-1 ------ And I made some minor grammatical changes in the synopsis and description. Thanks again!