unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Timotej Lazar <timotej.lazar@araneo.si>
Cc: 44853@debbugs.gnu.org
Subject: [bug#44853] [PATCH] gnu: Add qpdfview.
Date: Wed, 25 Nov 2020 15:33:06 -0500	[thread overview]
Message-ID: <X76/git/aac+WWYb@jasmine.lan> (raw)
In-Reply-To: <87ft4xuvw8.fsf@araneo.si>

On Wed, Nov 25, 2020 at 07:35:51PM +0100, Timotej Lazar wrote:
> This makes sense. I suppose we should wrap all Qt programs like this. I
> tried your patch and it works, but the same icon theme is used
> regardless of what I choose in LXQt appearance settings.

Hm, that's not ideal.

> I think the problem is with the 'qt-wrap phase, which uses "=" instead
> of "suffix" for wrapping variables. Changing this in qt-build-sytem.scm
> gives me correct icons. Now that I think about it, "prefix" might be
> better to ensure the correct versions of plugins are used at runtime;
> both options work for me.

Can you send the patch for qt-build-system? There are only 166 users of
it currently, so we can update it on the master branch. I don't really
know much about it, so I can't judge which is the best way to change it.




  reply	other threads:[~2020-11-25 20:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 18:58 [bug#44853] [PATCH] gnu: Add qpdfview Timotej Lazar
2020-11-25  3:13 ` Leo Famulari
2020-11-25 18:35   ` Timotej Lazar
2020-11-25 20:33     ` Leo Famulari [this message]
2020-11-25 20:38     ` bug#44853: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X76/git/aac+WWYb@jasmine.lan \
    --to=leo@famulari.name \
    --cc=44853@debbugs.gnu.org \
    --cc=timotej.lazar@araneo.si \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).