From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yBusHwdf8l9DZQAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 00:19:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CMaYGwdf8l8ebQAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 00:19:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1590F940222 for ; Mon, 4 Jan 2021 00:19:19 +0000 (UTC) Received: from localhost ([::1]:40860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwDag-0007wp-0Y for larch@yhetil.org; Sun, 03 Jan 2021 19:19:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwDaQ-0007wh-GP for guix-patches@gnu.org; Sun, 03 Jan 2021 19:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwDaQ-0001LD-8Q for guix-patches@gnu.org; Sun, 03 Jan 2021 19:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwDaQ-0002SL-3x for guix-patches@gnu.org; Sun, 03 Jan 2021 19:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45573] [PATCH] Correct freecad runtime errors Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 00:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45573 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga Received: via spool by 45573-submit@debbugs.gnu.org id=B45573.16097195389430 (code B ref 45573); Mon, 04 Jan 2021 00:19:02 +0000 Received: (at 45573) by debbugs.gnu.org; 4 Jan 2021 00:18:58 +0000 Received: from localhost ([127.0.0.1]:38904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwDaM-0002S2-Fx for submit@debbugs.gnu.org; Sun, 03 Jan 2021 19:18:58 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwDaK-0002Ro-FP for 45573@debbugs.gnu.org; Sun, 03 Jan 2021 19:18:56 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 678255C00BD; Sun, 3 Jan 2021 19:18:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 03 Jan 2021 19:18:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=U34F1ZAdi/jtYkT6UvZcgyOk s3+a76c9/UtQfU6qfdQ=; b=L1X/2yZhoHo2zEl7PMvJr4BcpxJTA8n8x4rCzCpc 1G9KeqcYoUbt4iIpy81sH7T/ksQv3mKjCiUWZEYV9rVcxJrTW8GbT+3FAMw/3Dpj lZt1Iwj9Ss/AMBzqBGigJG0uxac3+3ih10huxWjnsZu7Y7X2ZsKgBRBTbFm9XjlF vsk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=U34F1Z Adi/jtYkT6UvZcgyOks3+a76c9/UtQfU6qfdQ=; b=cZasjMgXGj+/nlD7mFfSTj Sn7jFX04B8TILiJKWmiQNGHwqhJD0UHluX5hnqkoGk3yOAEkxEJ/2+rxM/FX4jGD Aaqy1WkUUdC4BQUordRNf6J+tnAjoX28Z/UNuX5VGZqZ1m74NMCMormlCJ4CVIpq KuUVPUTJGTrLMuEGJsk9uS4QWZa9wmXNh9LEQiSVpG7uP26kMERdzWoyrOgVOex0 X4tjHNgl/ZXuKwEiAqEl/d+gyYxRz+pqEQ3bMUDRpW+WdlZKwaQqJItv1Kc+b9rH 04GBZeZz8GffqYxnaEZl4emOlGMpEPWZDSYzKooChI5sqcgGZfUYSoHTd4NXG2fg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefvddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 1146924005D; Sun, 3 Jan 2021 19:18:51 -0500 (EST) Date: Sun, 3 Jan 2021 19:18:49 -0500 From: Leo Famulari Message-ID: References: <6b2IbqX7a-q86Pjb_nOtz_XcCOrATSHf2T7vfIU5qrXWhYtQFsoex3XlfmDVhLt8UXjnOonMiLCS-1oKUzxXpp8x3HSUjNkzUjhUsKGc3Iw=@elenq.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "45573@debbugs.gnu.org" <45573@debbugs.gnu.org> Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=L1X/2yZh; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=cZasjMgX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1590F940222 X-Spam-Score: 0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: jpDvBuP9Bv8U On Fri, Jan 01, 2021 at 02:37:39PM +0000, Ekaitz Zarraga wrote: > Subject: [PATCH 3/6] gnu: Add python-pivy. > > * gnu/packages/python-xyz.scm (python-pivy): New variable. > + `(#:tests? #f ; Tests are broken Can you clarify what you mean, and the overall situation with the tests? Are they actually used upstream? > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-cmake-include-dirs > + (lambda _ > + ;; Patch buildsystem to respect Coin3D include directory > + (substitute* "CMakeLists.txt" > + (("\\$\\{SoQt_INCLUDE_DIRS}") > + "${Coin_INCLUDE_DIR};${SoQt_INCLUDE_DIRS}")) This can probably be fixed with #:configure-flags. I can look into this before pushing. > Subject: [PATCH 4/6] gnu: FreeCad: Update to 0.18.5-1.7616153. > > Fixes Draft module import errors > > * gnu/packages/engineering.scm (freecad): Update to 0.18.5-1.7616153. > [inputs]: Add python-pivy. > Subject: [PATCH 5/6] gnu: freecad: move python-pyside-2-tools to native-inputs > > * gnu/packages/engineering.scm (freecad): > [inputs]: Remove python-pyside-2-tools. > [native-inputs]: Add python-pyside-2-tools. The re-indentation of the package in patch 4/6 is not complete, and I will squash these two patches before pushing. I have this "ready to go" in my Git tree. > Subject: [PATCH 6/6] gnu: freecad: Add qtwebkit input. > > * gnu/packages/engineering.scm (freecad): > [inputs]: Add qtwebkit. > - ;; qtwebkit is optional. We remove it currently, because it takes > - ;; much time to compile and substitutes are often unavailable > - ;;("qtwebkit" ,qtwebkit) > + ("qtwebkit" ,qtwebkit) The comment is still true... I recommend adding a note in the commit message saying what the new dependency enables.