From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QGKuMezthGF1JAEAgWs5BA (envelope-from ) for ; Fri, 05 Nov 2021 09:40:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IKJbLezthGFVUwAAB5/wlQ (envelope-from ) for ; Fri, 05 Nov 2021 08:40:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4462CAA1C for ; Fri, 5 Nov 2021 09:40:12 +0100 (CET) Received: from localhost ([::1]:53906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miule-00069U-Nd for larch@yhetil.org; Fri, 05 Nov 2021 04:40:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miulW-00069M-S3 for guix-patches@gnu.org; Fri, 05 Nov 2021 04:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miulW-0003aV-IO for guix-patches@gnu.org; Fri, 05 Nov 2021 04:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miulW-0002lR-9c for guix-patches@gnu.org; Fri, 05 Nov 2021 04:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49578] [PATCH v3 1/2] gnu: Add bolt. Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Nov 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49578 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49578@debbugs.gnu.org Received: via spool by 49578-submit@debbugs.gnu.org id=B49578.163610155810568 (code B ref 49578); Fri, 05 Nov 2021 08:40:02 +0000 Received: (at 49578) by debbugs.gnu.org; 5 Nov 2021 08:39:18 +0000 Received: from localhost ([127.0.0.1]:44793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miukn-0002kN-O6 for submit@debbugs.gnu.org; Fri, 05 Nov 2021 04:39:18 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:10984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miuki-0002k3-FO for 49578@debbugs.gnu.org; Fri, 05 Nov 2021 04:39:16 -0400 Date: Fri, 05 Nov 2021 08:39:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1636101541; bh=IE1/pQ2XlbxiHtK3ecXWLSw0PyNUNSUf70QEcTlSZz8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=fjxWDfGYbGpedh4XTlzrb78mKSQEQQA0Ilm32e+0UAn7Fw5o0QE565hg8QqdoqBB7 ydGQH+6k6Yxat6HqcNCOH+OwimT3TTtVD/CUDx48EsAsiDengLDL82quHatsV7ugtA AbSEFNGFw+oUFeIjCDDCv3kNVsBBplfDOP4fIGi0= Message-ID: In-Reply-To: <86mto4w0xw.fsf@mgsn.dev> References: <86mto4w0xw.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches From: phodina via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636101612; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IE1/pQ2XlbxiHtK3ecXWLSw0PyNUNSUf70QEcTlSZz8=; b=u0RykH4ehUZk7FO6ktg7KikjHAAgruwqPfOVE5eC6soGMVP32rNDoZs9veICXE82orxgtT lC71oudd+50rTCPyUkmy8ZD7vPXq40mpUQqKk9XdIPqpFaw3RvMvqSCHWeKENdO1E9AkLD fqpkjV+/L9OyyHxg6JKGOD7ulhh+b2aM0LThmEf38hmV1+3/Nn6rxn2Yv5mMKCRdUIq0kI NEH0/hhWc01tbt03YFREmKE9yarpmAZXufrxxjNGCL5eTFY3UvEG09XC3oqHi3KO8lE0au ehEfeCQ5PG25RT3aLeED/YMCjEd1QypX/CWHnFfCnU4F8qGCG2voaN0iCcWMnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636101612; a=rsa-sha256; cv=none; b=L3E1H2RuS8Gj6pymVV9LV57igpHYyKhlKToIiUx5rMyTm/va73LdMkFDTPIPXI6f8AUV3j EhhhcrHfveCnIsqABdDr/KsM2QAv/qUb9EP/tZXkDk2S5Gr8eW0xRF2BN6gX9CF9oDTISs 80wjyDa/w9IdtfBP2rc1ZYrzuPWH8XmxOQ2lpINYFlYjvhU3UHh/L5gO3zQG077LN/EDIq UCHcccxdOHmOgeyNt3w16gI6sw4ssza6vaTLPuYqW5tCzg3I5SfflS1U3zzG+EmQW+cGbq KOJlNjJNpQHbEK4XH0VYcuyAloxrLYlwazFDRMF4CEH9IGZg41+DTES2zFsqZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=fjxWDfGY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=fjxWDfGY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4462CAA1C X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: LlymIA9r73Kf Hi, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Thursday, September 23rd, 2021 at 3:11 AM, Sarah Morgensen wrote: > Hello Petr, > > Thanks for the updated patch :) > > I don't have any experiences with services, so I can't comment on the > > second patch in this series, and I don't have a Thunderbolt controller > > or devices, so I can't test the actual program, but other than the > > commit message/synopsis/description this package LGTM. Thanks Sarah for the review and tips on packaging. > > phodina phodina@protonmail.com writes: > > > - gnu/packages/linux.scm: (bolt): New variable. > > ^ no ":" > > > > - (synopsis "Userspace system daemon for Thunderbolt") > > Consider this instead (taken from their repository tagline, more > > understandable to more users): > > (synopsis "Thunderbolt 3 device manager") > > > - (description "Userspace daemon @code{boltd} exposes devices via D-B= us to clients. > > > > +It stores database of previously authorized devices and depending > > > > +on the policy set for the individual devices, automatically author= ize newly > > > > +connected devices without user interaction. It also adapts its beh= aivour when > > > > +iommu support is detected. > > > > +Command line utility 'boltctl' can be used to manage thundebolt de= vices. > > > > +It can list devices, monitor changes and initiate authorization of= device.") > > Consider this instead: > > (description "This package provides @command{boltd}, a userspace daemon > > for Thunderbolt devices, and @command{boltctl}, a command-line utility fo= r > > managing those devices. > > The daemon @command{boltd} exposes devices via D-Bus to clients. It also > > stores a database of previously authorized devices and will, depending on= the > > policy set for the individual devices, automatically authorize newly conn= ected > > devices without user interaction. > > The command-line utility @command{boltctl} manages Thunderbolt devices vi= a > > @command{boltd}. It can list devices, monitor changes, and initiate > > authorization of devices.") > > > - (home-page "https://gitlab.freedesktop.org/bolt/bolt") > > - (license license:gpl2+))) > > > > (define-public jitterentropy-rngd > > > > (package > > > > (name "jitterentropy-rngd") > > -----------------------------------------------------------------------= - > > > > 2.32.0 > > With those changes, or similar: > > - Package review checklist (WIP) > > Lack of a check is not proof of noncompliance. > > 1. [X] Package builds (guix build package) > > [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le > > [ ] i686 [ ] i586 [ ] mips64le > 2. [X] Build is reproducible (guix build --rounds=3Dn package) > 3. [X] Tests enabled (if available) or disabled with in-source comment > 4. [X] No extraneous dependencies (guix size package) > 5. [X] No unnecessary pre-built binaries/blobs > 6. [X] Dependencies unvendored when available in Guix > 7. [X] Cross-compile friendly (cc-for-target, patches with inputs) > 8. [X] License matches source > 9. [X] No problematic lints (guix lint package) > 10. [X] Formatting follows guidelines > - [X] Lines wrap at 80 characters > - [X] Indentation passes etc/indent-code.el > - [X] Two spaces used between sentences > > For new packages: > 11. [X] Source url is robust > - mirror:// used with url-fetch when possible > - No auto-generated archives from source repo (prefer cloning) > 12. [X] Synopsis is short, descriptive, and meaningful to a wide audienc= e > 13. [X] Description is objective, takes 5-10 lines, uses full sentences, > > and provides the information users need to decide whether the > > software fits their needs. > > There are lints for CVEs, but they are for the Bolt CMS, not this > > project. > > -- > > Sarah Is there somebody who has Thunderbolt on their machine and could test this = patch? Petr