From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IEQeHjz8VGBIBwAA0tVLHw (envelope-from ) for ; Fri, 19 Mar 2021 19:32:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0DsCGjz8VGCgCQAAbx9fmQ (envelope-from ) for ; Fri, 19 Mar 2021 19:32:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF3A821CFD for ; Fri, 19 Mar 2021 20:32:11 +0100 (CET) Received: from localhost ([::1]:56234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNKqx-0002co-16 for larch@yhetil.org; Fri, 19 Mar 2021 15:32:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNKqo-0002bO-6X for guix-patches@gnu.org; Fri, 19 Mar 2021 15:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNKqn-00051n-UW for guix-patches@gnu.org; Fri, 19 Mar 2021 15:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNKqn-0002do-Pq for guix-patches@gnu.org; Fri, 19 Mar 2021 15:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47187] [PATCH] gnu: Add c-lightning. Resent-From: ZmnSCPxj Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Mar 2021 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: "47187@debbugs.gnu.org" <47187@debbugs.gnu.org> Received: via spool by 47187-submit@debbugs.gnu.org id=B47187.161618228910108 (code B ref 47187); Fri, 19 Mar 2021 19:32:01 +0000 Received: (at 47187) by debbugs.gnu.org; 19 Mar 2021 19:31:29 +0000 Received: from localhost ([127.0.0.1]:51029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNKqH-0002cy-8r for submit@debbugs.gnu.org; Fri, 19 Mar 2021 15:31:29 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:34403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNKqD-0002cg-3t for 47187@debbugs.gnu.org; Fri, 19 Mar 2021 15:31:28 -0400 Date: Fri, 19 Mar 2021 19:31:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1616182278; bh=Usn4q2BxuMtk6mGytD/G4SG6Ajz+oWrwi8Q1cFD4ybA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=eIcK0oKRCK7bbKmMAYxi8r6WaYUrETAyC1TDrqPWJj9/mqx8qxXk/PU3/eNh397tr L5BGAXCyRD9h9XuSNIh69Lph+EPot8Numj3igCHr944IOBlIRMiXAmRixoRQn8h92M WDVAuMGT54NXBcdSp6uQSFAw+NN0fixMX2i0Cmbs= Message-ID: In-Reply-To: References: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> <8f7d4c04d96fdf8cf1239c476c4c869f92446ada.camel@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: ZmnSCPxj X-ACL-Warn: , ZmnSCPxj via Guix-patches From: ZmnSCPxj via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616182332; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Usn4q2BxuMtk6mGytD/G4SG6Ajz+oWrwi8Q1cFD4ybA=; b=e5diGyD32yIMyUXFkNP94zdcfK2zZ9i27pX0eQqcGLEkllF94yXNjGacb7zjv6AeadBLUn G4S4ZvLXuPYrmHuixzhQSZiwjlR/3uP66zWD0h0uqLAJBOyZRyNrOLMKMLG11G6u0DFJWo NNkjq99nm1TKUh/LpoC7OtUSUY3ruRkYtF3cYVywuZOg+QWk/Kv7PQgmH6OO967cUM1awu 4U+E0vGNfK5Rm710zrLonbF1mRqQq/DdboT6ZWDO6x12WH09TPl2Uqg+D27J7UtuQGAHoV 3ZITEjmtcFnSmS9l2uhsFwfXHtVEHxnt8vETWTvr4nYgb6i/2JwpbPOwPPNhJg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616182332; a=rsa-sha256; cv=none; b=SJwiGXYfrnjkC6/1kImbv8QbpIkdpkB21tn4i7MBOBesVOqggUTIgjE1iYNGNi30jXy/eg KBMCnX9TUykfh3gTkXc1GNGaQ8qLR1wgE2c3y+SNE0N/DgAu3rzdOuAIU8tdItIjrXh7Pj sPm3+lLzgUz9JqSQzn/GKuhLRrIIjbfmJkCLWmCvrQZ1qWzjuhppfvnL8DhXia7d1ihZZj zP+4zwgwfnyQUtFdilgUJClXx8jJrx0R1SQd9BKP9e1gaMmuxaF0GsepmYxUeyOuCOuAQg b07qYMXxZuk6eFpZ+V6Ky6gjU5VanjSq7U/zN15HfWH2zMSoaafANhmWqjbMPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=eIcK0oKR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=eIcK0oKR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DF3A821CFD X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: YeOyDfK+Vh6n Good morning Leo, > On Thu, 2021-03-18 at 16:54 +0000, ZmnSCPxj wrote: > > > That would not be simple I think, but let me see what can be done. > > For one, it would be fairly difficult to test it outside of a patched > > Guix, as the packages are not usually available in most distros > > (which is why we ship the source build with them); e.g. we do not > > know how to actually find the "system" libbacktrace as no existing > > system I know of actually ships the libbacktrace we use (Debian ships > > a libbacktrace for android development, and is not the same package > > as what we use). > > Of the external packages we use, only libsodium is available on > > Debian (and older Debian/Ubuntu, as mentioned, have an older version > > that does not have a functionality we require, which is why it is > > included in our source build as well), so that is the only external > > we have that we can plausibly say "we can use the system version", > > because all the others are not available on most systems. > > We can package every of those in GNU Guix, there's not as much > bureaucracy as Debian when it comes to inclusion, as long as Free > Software and freedom-non-controversial. The "system" thing is just so > handy for us build-system wise we can just provide it as an input and > it will find things automatically, I don't say that "system" lookup > should imply to take any available library in general, in the context > of GNU Guix we can give it a particular version and stick to it, unlike > Debian's who can't have or with great difficulty, multiple versions of > the same library installed. Okay. It is somewhat unclear to me however how to discover where the library is l= ocated. As far as I understand how autotools does it, it looks at some standard loc= ations on `/`, but I am uncertain if that is how it actually works. For example if `libwally-core` is separately packaged, obviously it would i= nstall into a `/gnu/store/*` via a `--prefix` override. And if the dependent package were using autotools, it is somehow able to ma= gically find where the `lib*.a` file is. However, C-Lightning does not actually use autotools (its build system pred= ated my participation, I offered to port to autotools but this was declined= ), so I somehow need to emulate what autotools does in `--use-system-librar= ies` mode. I probably have to go hack some autotools package that trivially depends on= `libwally-core` and see what the exact shell script is generated. > Also if we want to provide the Python bindings (?) to c-lightning we > also have the option of creating a separate package based on the same > sources but with different build-system (like python-build-system), and > also it can have c-lightning as an input. Note that AFAIK the Python bindings do not actually invoke any of the C-Lig= htning binaries, they just open the UNIX socket to the c-lightning daemon, = so I think there is no need for `c-lightning` itself as an input. Regards, ZmnSCPxj