From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2HQuAgB/qGTW9QAASxT56A (envelope-from ) for ; Fri, 07 Jul 2023 23:09:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mE1fAQB/qGRKKwEAG6o9tA (envelope-from ) for ; Fri, 07 Jul 2023 23:09:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 485C810502 for ; Fri, 7 Jul 2023 23:09:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHshN-0004b7-Eh; Fri, 07 Jul 2023 17:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHshK-0004ZU-60 for guix-patches@gnu.org; Fri, 07 Jul 2023 17:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHshJ-00026m-Ug for guix-patches@gnu.org; Fri, 07 Jul 2023 17:09:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHshJ-0004OJ-Pb for guix-patches@gnu.org; Fri, 07 Jul 2023 17:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64521] [PATCH] gnu: tuba: Fix video-player crash and webp support. References: <41881946b2ae618d37e9c9939bf3d878116a70dc.1688758089.git.lilah@lunabee.space> In-Reply-To: <41881946b2ae618d37e9c9939bf3d878116a70dc.1688758089.git.lilah@lunabee.space> Resent-From: Juliana Sims Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jul 2023 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64521 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: lilah@lunabee.space Cc: 64521@debbugs.gnu.org Received: via spool by 64521-submit@debbugs.gnu.org id=B64521.168876413916871 (code B ref 64521); Fri, 07 Jul 2023 21:09:01 +0000 Received: (at 64521) by debbugs.gnu.org; 7 Jul 2023 21:08:59 +0000 Received: from localhost ([127.0.0.1]:43894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHshH-0004O3-Gm for submit@debbugs.gnu.org; Fri, 07 Jul 2023 17:08:59 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHshE-0004No-Lw for 64521@debbugs.gnu.org; Fri, 07 Jul 2023 17:08:58 -0400 X-GND-Sasl: juli@incana.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=incana.org; s=gm1; t=1688764130; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=UWIRa+iKf5z7Ky0FOTSPABm7b7/9cSSZ2Fo2T5LDeII=; b=N8DAov/DRD1TH6h7ysGzy3MNxyifNN1GEpd/a9Iw3MkSOgxQHtPF/wjTtXqk3rzRX4fZpc 7gMwsq2hSTtk14M8UHmD30hyMEjtmisiGqqU4g034LB5vCc0kj8YsAhZ3wi/05V6hFJnQZ /D+e18wF+sw1/4mLmKzC0E4ktWp4Xm6FSZbSGzz31UiDUdd1bCWF9k7vAVnDT6CIknQYgx +LXoCl2CtMrJGgcM12ughkOe3AqBmAyez3P6ey307Zvr/+yhoksFo8zu1uHUJIX9Zedeyc TN1jUB0v44Wfni1j4w4ULF0m58c0+tyNvgsmW/LyazzBXI3laruT2iu3qcFGNQ== X-GND-Sasl: juli@incana.org Received: by mail.gandi.net (Postfix) with ESMTPSA id 1601260003; Fri, 7 Jul 2023 21:08:48 +0000 (UTC) Date: Fri, 07 Jul 2023 17:08:16 -0400 From: Juliana Sims Message-Id: X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 41881946b2ae618d37e9c9939bf3d878116a70dc.1688758089.git.lilah@lunabee.space Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688764159; a=rsa-sha256; cv=none; b=g5M7ggGVulXW1U1CxMvagxnQ8Rshx28lAZ/FyYV7LHTGbbjiEoGF4t7oyuAtDMjqwJaV31 TlbJyvz7qa5C/4b8lZSPex25BeX+ogtqdoqcrr3NDp2rFUY3NdM1ZWj40mISh25xTjcrPU 6pn4lHDPxAeyU781csTQw2Bhn5hp0asT4Jz1ewKS3yX5JmjXbjIHWmwsnUQNNas2YP87+m RtQ4JR1NWRwa/SuAAHPFUfaIvCH/1kxsp1UUKL+yw+aHAiXa7oaG6s9UkGci149wDYKIDi olQJUSJwFz2NyLEg2oE8xE52LJU+2xyuWLr/Tp0f4rfi+bXqRPoehaXotZgEOQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b="N8DAov/D"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688764159; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=UWIRa+iKf5z7Ky0FOTSPABm7b7/9cSSZ2Fo2T5LDeII=; b=GP6+DTETFHmIGYWalTHb1Ywv5x/BFqWkee8eroaJ2Qjy3TJeRInpqlgoBiYpJcBmXPckLB PJK6uS/gewvsjIHjZMQWBTP7mEeM+IDq+vFx2TCYlZAFCOd2w2FKZAtaoO69OYk7JH9kkX OVQoL1dtQYyV0138czUaEbfMiLhBx+OYryj8rxvLszqZgK6uvYRct7flTIO8m6itPi0oFZ JKEbiNf4ON6KYoD2gczFO+rv8oPMVfLWMIyEXjgi/MH7RayU0inNMPPHR+G9TkSQqsOoIq XHr9oL0YQ5QcIde1aRdcuJN6U8e18cRfrbcfIStfV4udnuhgTzXGjVIbYphk1A== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b="N8DAov/D"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.87 X-Spam-Score: -1.87 X-Migadu-Queue-Id: 485C810502 X-TUID: G3fZ88q0ZAWn Hello, First of all, could you split this into multiple patches? Specifically, could you split the fix apart from the argument modernization? My other major concern is the inclusion of all those gstreamer plugins. Do we really need all of them? Ideally we want to avoid *-ugly and *-bad if we can. I'm not sure if this is an issue with the Guix package, my personal setup, or Tuba itself, but while testing the patch I ran into an issue signing in. Because spaces are used to separate the permissions the application requests, my browser seems to interpret them as indicating new URLs instead. If you're able to fix that, that would be great! Also, feel free to add a copyright line to the top of the file as part of your first patch ;) Thanks, Juli