From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wL68Ge394WFrDwAAgWs5BA (envelope-from ) for ; Fri, 14 Jan 2022 23:49:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mDxkEu394WES9gAAG6o9tA (envelope-from ) for ; Fri, 14 Jan 2022 23:49:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D47C421F51 for ; Fri, 14 Jan 2022 23:49:16 +0100 (CET) Received: from localhost ([::1]:37558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8VNk-0002Iv-0z for larch@yhetil.org; Fri, 14 Jan 2022 17:49:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8VNW-0002IV-G4 for guix-patches@gnu.org; Fri, 14 Jan 2022 17:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8VNW-0006aG-0q for guix-patches@gnu.org; Fri, 14 Jan 2022 17:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8VNV-00026s-Pq for guix-patches@gnu.org; Fri, 14 Jan 2022 17:49:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53222] [PATCH] gnu: autokey fix paths. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Jan 2022 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53222 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53222@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 53222-submit@debbugs.gnu.org id=B53222.16422005058058 (code B ref 53222); Fri, 14 Jan 2022 22:49:01 +0000 Received: (at 53222) by debbugs.gnu.org; 14 Jan 2022 22:48:25 +0000 Received: from localhost ([127.0.0.1]:38515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8VMu-00025u-Nm for submit@debbugs.gnu.org; Fri, 14 Jan 2022 17:48:25 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:24823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8VMp-00025d-Bw for 53222@debbugs.gnu.org; Fri, 14 Jan 2022 17:48:23 -0500 Date: Fri, 14 Jan 2022 22:48:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1642200492; bh=FodndWHquaQ7gwc9uBAdzQcap2bLSsDxZTzsqld3J3w=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=ij2Mz/gioVC+5PfR/X8KldbHtfVg9UOpqsrBt21AgKXeMFLYgpjgkeRWdFm4n7XZf VQ2HYE9VGJUimY60Oh9eV+BYSlLjEWQspC7OduAG0Be8TnrIGJP8fnb/Nds+l44MQB 09AYQiN/32WcLATt5RZJbc1TxQZsAkK57qfnAwIe3xqjJwmGACqIiyiOnsrfEDNSXH /6Eiim3NZlkyddiIGUknOv4VpsKWwoCzRL/EeEm4M21E2eZ9aeFjaSolZirBNDE+Ua vJppbxr+JwTMRAtVRO6i5oDL3rfHxRiVCWMxyBxQ+0Fek+m7Oj6/+DxZxeRreOs4P6 y1uUWttvACbOQ== Message-ID: In-Reply-To: <7459eb594a85d02eb744c9bd5b83941576990aab.camel@telenet.be> References: <7459eb594a85d02eb744c9bd5b83941576990aab.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_uE3XTLzMA5EPkduV46zmWkNFca6eEks5BOm8pBwU" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642200557; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=FodndWHquaQ7gwc9uBAdzQcap2bLSsDxZTzsqld3J3w=; b=UTbb8AYuKeqX7+L2J86TNY9XLDQ/SZ/bCXdSDvXSsL02R5z72ZMaLaCbyvE+3NkqsUb+/q f3pofF6yIRmOfZ70fCCWPXpXppsyrTOZVzuo+nNrpiB8PiocR7N/ghE8lgOLomp5hD270l 9ByEHVPMYcVoZWL5z3GMaY/p3vbhNAoW6TzwBsn5cuUzkhm7p7De6ZsrdFIOtOov478xlU MUygqW4EAa0GNsUcSDgV7Ob3z4e/swOJ1nmeX2+/lsKbBB9fnerIw/IjvCpSQ+fPP0X909 SeZx51DG6uF1DLdqQ7mo9Q/Hm1Qol79RduNVyO9oxxrNL2oTO/JHJ9tN0pfW4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642200557; a=rsa-sha256; cv=none; b=NlXsRGEYPI3usVTCJgbG5+NK92rlFeumwFW/AcLa6R370CRt6Kl7ZrEPYgp4/1XFxyDh9v NjnhxFay+XHzlH2QUjVkjFihDntkj4hng4DiktAKo56EpCg1RMFT6vBJhQAerYTY2PaiDL 7oxjKTrK+h7uNtEndJZGn/cx5QepUlfUisvxm0+WJ/ODtyV+O1PJxis0po6MiJxm6F/atC GSWYZ5SDDaZuiR+JckoohYKPUuQenm0Iqe3qSmpI1obFg6h25W/fwSt4yxqG2lOsjhFQ3a 3Vwj0nvMmqxG29ayApH2yv06sOS1EcKieubvrefKWzr1reLKI+wdca817aVxeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b="ij2Mz/gi"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b="ij2Mz/gi"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D47C421F51 X-Spam-Score: -3.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: SqkT+uoe5hHf This is a multi-part message in MIME format. --b1_uE3XTLzMA5EPkduV46zmWkNFca6eEks5BOm8pBwU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxime, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, January 14th, 2022 at 5:35 PM, Maxime Devos wrote: > > Wouldn't these also need to use use 'search-input-file'? > I think I've mentioned before why 'search-input-file' needs to be > used in these kind of contexts instead of 'which' (something with > cross-compilation), if not I can explain. > That sounds vaguely familiar and makes sense. I've updated it to do that (n= ot sure why I switched, probably since I was using that somewhere else). > Do we need propagation here? I don't quite see the need here > and propagation can cause trouble like profile conflcts during > partial upgrades (i.e. "guix install foo" after "guix pull" > without "guix package -u") > FWIW autokey is never used as library (except for autokey scripts > but I assume autokey scripts are interpreted in the same process > as autokey?)=C2=A0and wrap-program sets GUIX_PYTHONPATH so I think all > python libraries here could be depropagated? Though that might > be getting out of scope of the original patch, so only if you want > to investigate. > None of the inputs are propagated now (might have been confusing looking at= just this patch), all are regular inputs. Runs fine and is a good point I'= ll keep in mind for other python programs versus libraries. > Othderwise, the patch you attached LGTM. > Just to be clear, this patch (most recent version attached) is just to do t= hese final tweaks on top of the original patch which added autokey (as that= was already pushed). So I think everything should be good now? Thanks for the review and instructive changes! John --b1_uE3XTLzMA5EPkduV46zmWkNFca6eEks5BOm8pBwU Content-Type: text/x-patch; name=0001-gnu-autokey-Fix-paths.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-autokey-Fix-paths.patch RnJvbSA0NzEyNmM5NDhlNGZhYTYwODM3ODkwMGMzODQxN2UzZDAyMGMxZTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIEtlaGF5aWFzIDxqb2huLmtlaGF5aWFzQHByb3Rvbm1h aWwuY29tPgpEYXRlOiBGcmksIDE0IEphbiAyMDIyIDE1OjI2OjM2IC0wNTAwClN1YmplY3Q6IFtQ QVRDSF0gZ251OiBhdXRva2V5OiBGaXggcGF0aHMuCgoqIGdudS9wYWNrYWdlcy9weXRob24teHl6 LnNjbSAoYXV0b2tleSk6IEFkZCBjb21tZW50cyBvbiB0aGUgZGlzYWJsZWQgdGVzdHMKYW5kIEdJ X1RZUEVMSUJfUEFUSCB3cmFwcGluZy4KW2lucHV0c106IEFkZCBpcHl0aG9uLgpbcGhhc2VzXXtm aXgtcGF0aHN9OiBVc2UgcGF0aHMgdG8gaXB5dGhvbjMgYW5kIHB5dGhvbjMgaW4gYXV0b2tleS1z aGVsbApzY3JpcHQuCnt3cmFwLWF1dG9rZXl9OiBDaGFuZ2UgbmFtZSB0by4uLgp7d3JhcC1hdXRv a2V5LWdpfTogLi4udGhpcyBhbmQgbW92ZSB0byBiZWZvcmUgd3JhcCBmb3IgY2xhcml0eS4KLS0t CiBnbnUvcGFja2FnZXMvcHl0aG9uLXh5ei5zY20gfCAyNiArKysrKysrKysrKysrKysrKystLS0t LS0tLQogMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3B5dGhvbi14eXouc2NtIGIvZ251L3BhY2thZ2VzL3B5 dGhvbi14eXouc2NtCmluZGV4IGI4NTIzMmYyYjcuLjEzZmU2MGQyOTYgMTAwNjQ0Ci0tLSBhL2du dS9wYWNrYWdlcy9weXRob24teHl6LnNjbQorKysgYi9nbnUvcGFja2FnZXMvcHl0aG9uLXh5ei5z Y20KQEAgLTQxOTcsNyArNDE5Nyw5IEBAIChkZWZpbmUtcHVibGljIGF1dG9rZXkKICAgICAoYnVp bGQtc3lzdGVtIHB5dGhvbi1idWlsZC1zeXN0ZW0pCiAgICAgKGFyZ3VtZW50cwogICAgICAobGlz dAotICAgICAgIzp0ZXN0cz8gI2YgOyBUZXN0cyBhcmUgZGVwcmVjYXRlZC9icm9rZW4gdW50aWwg bmV4dCB2ZXJzaW9uLgorICAgICAgOzsgVGVzdHMgYXJlIGRlcHJlY2F0ZWQgYW5kIGJyb2tlbiB1 bnRpbCBuZXh0IHZlcnNpb24sIHNlZQorICAgICAgOzsgaHR0cHM6Ly9naXRodWIuY29tL2F1dG9r ZXkvYXV0b2tleS9pc3N1ZXMvMzI3CisgICAgICAjOnRlc3RzPyAjZgogICAgICAgIzpwaGFzZXMK ICAgICAgICN+KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwogICAgICAgICAgIChhZGQt YWZ0ZXIgJ3VucGFjayAnZml4LXBhdGhzCkBAIC00MjA2LDggKzQyMDgsMTYgQEAgKGRlZmluZS1w dWJsaWMgYXV0b2tleQogICAgICAgICAgICAgICAgICgoIlwid21jdHJsXCIiKQogICAgICAgICAg ICAgICAgICAoc3RyaW5nLWFwcGVuZCAiXCIiIChzZWFyY2gtaW5wdXQtZmlsZSBpbnB1dHMgImJp bi93bWN0cmwiKSAiXCIiKSkKICAgICAgICAgICAgICAgICAoKCJcInplbml0eVwiIikKLSAgICAg ICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIlwiIiAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRz ICJiaW4vemVuaXR5IikgIlwiIikpKSkpCi0gICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAn d3JhcC1hdXRva2V5CisgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJcIiIgKHNlYXJj aC1pbnB1dC1maWxlIGlucHV0cyAiYmluL3plbml0eSIpICJcIiIpKSkKKyAgICAgICAgICAgICAg KHN1YnN0aXR1dGUqICJhdXRva2V5LXNoZWxsIgorICAgICAgICAgICAgICAgICgoIidpcHl0aG9u MyciKQorICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiJyIgKHNlYXJjaC1pbnB1dC1m aWxlIGlucHV0cyAiYmluL2lweXRob24zIikgIiciKSkKKyAgICAgICAgICAgICAgICAoKCIncHl0 aG9uMyciKQorICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiJyIgKHNlYXJjaC1pbnB1 dC1maWxlIGlucHV0cyAiYmluL3B5dGhvbjMiKSAiJyIpKSkpKQorICAgICAgICAgIDs7IFVzZSAn cHJlZml4JyBpbnN0ZWFkIG9mICc9JyB0byBhbGxvdyB0aGUgdXNlciB0byB1c2UgYWRkaXRpb25h bAorICAgICAgICAgIDs7IEdJIHBhdGhzIGZyb20gdGhlaXIgYXV0b2tleSBzY3JpcHRzLiAgR1VJ WF9QWVRIT05QQVRIIGlzIGFscmVhZHkKKyAgICAgICAgICA7OyB3cmFwcGVkIHdpdGggcHJlZml4 IGluIHB5dGhvbi1idWlsZC1zeXN0ZW0ncyB3cmFwLgorICAgICAgICAgIChhZGQtYmVmb3JlICd3 cmFwICd3cmFwLWF1dG9rZXktZ2kKICAgICAgICAgICAgIChsYW1iZGEgXwogICAgICAgICAgICAg ICAobGV0ICgoZ2ktdHlwZWxpYi1wYXRoIChnZXRlbnYgIkdJX1RZUEVMSUJfUEFUSCIpKSkKICAg ICAgICAgICAgICAgICAoZm9yLWVhY2gKQEAgLTQyMjMsMTQgKzQyMzMsMTQgQEAgKGRlZmluZS1w dWJsaWMgYXV0b2tleQogICAgICAgICAgICBndGtzb3VyY2V2aWV3LTMKICAgICAgICAgICAgbGli YXBwaW5kaWNhdG9yCiAgICAgICAgICAgIGxpYm5vdGlmeQotICAgICAgICAgICB3bWN0cmwKLSAg ICAgICAgICAgemVuaXR5KSkKLSAgICAocHJvcGFnYXRlZC1pbnB1dHMKLSAgICAgKGxpc3QgcHl0 aG9uLWRidXMKKyAgICAgICAgICAgcHl0aG9uLWRidXMKKyAgICAgICAgICAgcHl0aG9uLWlweXRo b24KICAgICAgICAgICAgcHl0aG9uLXB5Z29iamVjdAogICAgICAgICAgICBweXRob24tcHlpbm90 aWZ5CiAgICAgICAgICAgIHB5dGhvbi1weXF0K3FzY2ludGlsbGEKLSAgICAgICAgICAgcHl0aG9u LXhsaWIpKQorICAgICAgICAgICBweXRob24teGxpYgorICAgICAgICAgICB3bWN0cmwKKyAgICAg ICAgICAgemVuaXR5KSkKICAgICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vYXV0b2tl eS9hdXRva2V5IikKICAgICAoc3lub3BzaXMKICAgICAgICJLZXlib2FyZCBhbmQgR1VJIGF1dG9t YXRpb24gdXRpbGl0eSIpCi0tIAoyLjM0LjAKCg== --b1_uE3XTLzMA5EPkduV46zmWkNFca6eEks5BOm8pBwU--