[bug#47399] [PATCH] Add Google's Highway library.

[bug#47399] [PATCH] Add Google's Highway library.

[Isaac Young via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

Hello,

I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.

Thank you,
Isaac Young

[-- Attachment #2: Type: text/html, Size: 636 bytes --]

[bug#47399] [PATCH] Add Google's Highway library.

[Isaac Young via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 389 bytes --]

Oops, I didn't include the patch.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 25, 2021 6:54 PM, Isaac Young <isyoung@pm.me> wrote:

> Hello,
>
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.
>
> Thank you,
> Isaac Young

[-- Attachment #1.2: Type: text/html, Size: 1213 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-google-highway.patch --]
[-- Type: text/x-patch; name=0001-google-highway.patch, Size: 1614 bytes --]

From e01ee85800935100e513cdf4175f238ef77da1fd Mon Sep 17 00:00:00 2001
From: Isaac Young <isyoung@pm.me>
Date: Thu, 25 Mar 2021 18:17:28 -0600
Subject: [PATCH] Add Google's Highway library.

---
 gnu/packages/datastructures.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/datastructures.scm b/gnu/packages/datastructures.scm
index f10a54d376..cb796b17e3 100644
--- a/gnu/packages/datastructures.scm
+++ b/gnu/packages/datastructures.scm
@@ -371,3 +371,27 @@ and tsl::robin_pg_set. The first two are faster and use a power of two growth
 policy, the last two use a prime growth policy instead and are able to cope
 better with a poor hash function.")
     (license license:expat)))
+
+(define-public google-highway
+  (package
+    (name "google-highway")
+    (version "0.11.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/highway")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1zz21pap5qy3a490xy0nqp1p20f9x7zkar3msj5z0155l5fpfr3b"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("googletest" ,googletest)))
+    (arguments
+     `(#:tests? #t
+       #:configure-flags '("-DHWY_SYSTEM_GTEST=ON")))
+    (home-page "https://github.com/google/highway")
+    (synopsis "Highway is a C++ library for SIMD.")
+    (description "Performance-portable, length-agnostic SIMD with runtime dispatch")
+    (license license:asl2.0)))
-- 
2.31.0

[bug#47399] [PATCH] Add Google's Highway library.

[Isaac Young via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]

Sorry, I didn't include the patch.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 25, 2021 6:54 PM, Isaac Young <isyoung@pm.me> wrote:

> Hello,
>
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.
>
> Thank you,
> Isaac Young

[-- Attachment #1.2: Type: text/html, Size: 1214 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-google-highway.patch --]
[-- Type: text/x-patch; name=0001-google-highway.patch, Size: 1614 bytes --]

From e01ee85800935100e513cdf4175f238ef77da1fd Mon Sep 17 00:00:00 2001
From: Isaac Young <isyoung@pm.me>
Date: Thu, 25 Mar 2021 18:17:28 -0600
Subject: [PATCH] Add Google's Highway library.

---
 gnu/packages/datastructures.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/datastructures.scm b/gnu/packages/datastructures.scm
index f10a54d376..cb796b17e3 100644
--- a/gnu/packages/datastructures.scm
+++ b/gnu/packages/datastructures.scm
@@ -371,3 +371,27 @@ and tsl::robin_pg_set. The first two are faster and use a power of two growth
 policy, the last two use a prime growth policy instead and are able to cope
 better with a poor hash function.")
     (license license:expat)))
+
+(define-public google-highway
+  (package
+    (name "google-highway")
+    (version "0.11.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/highway")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1zz21pap5qy3a490xy0nqp1p20f9x7zkar3msj5z0155l5fpfr3b"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("googletest" ,googletest)))
+    (arguments
+     `(#:tests? #t
+       #:configure-flags '("-DHWY_SYSTEM_GTEST=ON")))
+    (home-page "https://github.com/google/highway")
+    (synopsis "Highway is a C++ library for SIMD.")
+    (description "Performance-portable, length-agnostic SIMD with runtime dispatch")
+    (license license:asl2.0)))
-- 
2.31.0

[bug#47399] [PATCH] Add Google's Highway library.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

On Fri, 2021-03-26 at 00:54 +0000, Isaac Young via Guix-patches via wrote:
> Hello, 
> 
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.

A commit message is missing from the patch.  E.g. something like

commit b09967bc587dd61c638da3d6fb5bbda7e87ed85c
Author: Raghav Gururajan <rg@raghavgururajan.name>
Date:   Sun Mar 7 01:47:19 2021 -0500

    gnu: Add psi-plus.
    
    * gnu/packages/messaging.scm (psi-plus): New variable.

(See 16.1 ‘Submitting Patches’ in the manual.)

You should add a ‘Copyright YEAR your-name’ as well at the top of the file.
There is no need to add ‘#:tests? #t’ as tests are enabled by default.

What's HWY_SYSTEM_GTEST=ON for?  Maybe add a comment

;; Prevent the configuration script from trying to download googletest
;; from the network.

or something like that.  Run "./pre-inst-env guix lint google-highway"
if you haven't already.

The "googletest" input does not make much sense when cross-compiling;
maybe move it to native-inputs with something like

  (native-inputs
   ,@(if (%current-target-system)
         '()
         ;; only used by the test suite
         `(("googletest" ,googletest))))

(See 8.2.1 ‘‘package’ reference’.)

(Admittedly, we don't focus much on making packages cross-compilable,
except for packages like gcc, bash, binutils ..., so no big problem
if this package isn't cross-compilable.)

Assuming you're on a system different from "aarch64-linux-gnu",
you can test cross-compilability with
"./pre-inst-env guix build --target=aarch64-linux-gnu google-highway".
(See 9.3.1 ‘Additional Build Options’)

Otherwise no comments, assuming it builds!

> Thank you,
> Isaac Young

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#47399: [PATCH] Add Google's Highway library.

[Vinicius Monego]

Hello,

I packaged highway in f2059169039561ae3b676e50443c14077d1e03db as a
dependency of libjxl. I'll close this issue, but feel free to submit
more packages in the future.