From: Jean Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org>
To: "57146@debbugs.gnu.org" <57146@debbugs.gnu.org>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
"andrewpatt7@gmail.com" <andrewpatt7@gmail.com>
Subject: [bug#57146] [PATCH] gnu: polkit: Fix cross-compiling
Date: Fri, 12 Aug 2022 09:57:04 +0000 [thread overview]
Message-ID: <QrB-kHrnJ8J1-bUGgL1tz97hf2mTdrGe2_92pdo4K41yV0OYfCNDih6DhapeED2snu9OlTChA_mUa-SC3V80B_YyTDmrSU1gETFyE6SE_kI=@jeandudey.tech> (raw)
In-Reply-To: <Jciv8CxPRUw6Hg8JP8fTEowlrEHSia_IaCcSdVfEZT2keFJzas0AClA82LOFVYM8OmqeC3ZEBATSBS7nDhWJwfQa2QT-PM73hXUu6koBNWY=@jeandudey.tech>
However, the patch to introduce G-Expressions is welcome as I did
only fix the inputs/native-inputs usage.
>+ (let ((out (assoc-ref outputs "out")))
Can be removed probably, and replace `out' here:
>+ (string-append "sysconfdir=" out "/etc")
>+ (string-append "polkit_actiondir=" out
>+ "/share/polkit-1/actions")
By #$output. But, rethinking it again, I would investigate if this phase
can be removed and instead use `#:make-flags' if possible directly as
make-flags can be specified as a G-Expression.
>+ (lambda* (#:key outputs #:allow-other-keys)
>+ (let ((out (assoc-ref outputs "out")))
>+ (substitute* (find-files "." "Makefile.in")
>+ (("@INTROSPECTION_GIRDIR@")
>+ (string-append out "/share/gir-1.0/"))
>+ (("@INTROSPECTION_TYPELIBDIR@")
>+ (string-append out "/lib/girepository-1.0/"))))))
Same here. And then:
>+ (lambda* (#:key outputs #:allow-other-keys)
Is just then:
--8<---------------cut here---------------start------------->8---
(lambda _
...)
--8<---------------cut here---------------start------------->8---
>+ (list #:configure-flags `(list "--sysconfdir=/etc" "--enable-man-pages"
>+ ;; Prevent ‘configure: error: cannot check for
>+ ;; file existence when cross compiling’.
>+ ,@(if (%current-target-system)
>+ '("--with-os-type=unknown")
>+ '()))
G-Expressions can be used here too, e.g:
--8<---------------cut here---------------start------------->8---
(list #:configure-flags #~(list "--sysconfdir=/etc"
"--enable-man-pages"
;; Prevent ‘configure: error: cannot check for
;; file existence when cross compiling’.
#$@(if (%current-target-system)
'("--with-os-type=unknown")
'()))
--8<---------------cut here---------------start------------->8---
—
Jean-Pierre De Jesus DIAZ
------- Original Message -------
On Friday, August 12th, 2022 at 11:42 AM, Jean Pierre De Jesus DIAZ <me@jeandudey.tech> wrote:
> This issue is already solved:
>
> https://issues.guix.gnu.org/56252
>
> > Pushed to 'staging' in 7767d30f55, thanks!
>
>
> Was fixed for both polkit-mozjs and polkit-duktape.
>
> —
> Jean-Pierre De Jesus DIAZ
next prev parent reply other threads:[~2022-08-12 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 23:11 [bug#57146] [PATCH] gnu: polkit: Fix cross-compiling Andrew Patterson
2022-08-12 8:29 ` Mathieu Othacehe
2022-08-12 21:24 ` Andrew Patterson
2022-08-12 9:42 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-12 9:57 ` Jean Pierre De Jesus DIAZ via Guix-patches via [this message]
2022-08-12 21:27 ` Andrew Patterson
2022-08-12 22:48 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-14 10:06 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2023-01-03 22:23 ` Maxim Cournoyer
2023-01-04 4:19 ` Andrew Patterson
2023-01-04 5:16 ` bug#57146: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='QrB-kHrnJ8J1-bUGgL1tz97hf2mTdrGe2_92pdo4K41yV0OYfCNDih6DhapeED2snu9OlTChA_mUa-SC3V80B_YyTDmrSU1gETFyE6SE_kI=@jeandudey.tech' \
--to=guix-patches@gnu.org \
--cc=57146@debbugs.gnu.org \
--cc=andrewpatt7@gmail.com \
--cc=me@jeandudey.tech \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).