From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UKD2E1SWUGBkCAAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 11:28:20 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4J63D1SWUGC/HgAAbx9fmQ (envelope-from ) for ; Tue, 16 Mar 2021 11:28:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id D6B7AB1A1 for ; Tue, 16 Mar 2021 12:28:19 +0100 (CET) Received: from localhost ([::1]:57566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lM7s3-0003Zz-1x for larch@yhetil.org; Tue, 16 Mar 2021 07:28:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lM7rm-0003YT-Cj for guix-patches@gnu.org; Tue, 16 Mar 2021 07:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lM7rm-0007An-3i for guix-patches@gnu.org; Tue, 16 Mar 2021 07:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lM7rl-0002rG-WC for guix-patches@gnu.org; Tue, 16 Mar 2021 07:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47187] [PATCH] gnu: Add c-lightning. Resent-From: ZmnSCPxj Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Mar 2021 11:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: "47187@debbugs.gnu.org" <47187@debbugs.gnu.org> Received: via spool by 47187-submit@debbugs.gnu.org id=B47187.161589405210936 (code B ref 47187); Tue, 16 Mar 2021 11:28:01 +0000 Received: (at 47187) by debbugs.gnu.org; 16 Mar 2021 11:27:32 +0000 Received: from localhost ([127.0.0.1]:38354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM7rH-0002qK-Rl for submit@debbugs.gnu.org; Tue, 16 Mar 2021 07:27:32 -0400 Received: from mail-40137.protonmail.ch ([185.70.40.137]:12730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM7rF-0002pz-2Y for 47187@debbugs.gnu.org; Tue, 16 Mar 2021 07:27:30 -0400 Date: Tue, 16 Mar 2021 11:27:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1615894042; bh=N2l3CP59WcYBg24Bn3fTT1Chet9exmgxUzJIly6XLgI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=E7QoKHhzRutHHdypayoDIDTp2n0/AnLyHri1zjsV4uPkFTu0N1scuBwLkfJc4TJut VDgJqCn7DoiR04e/B64MoiNRJ6GnaKDkgA0970hhY70VcjHlL/XO94s4EOqw84wafa L/Y74ZaH9b4HqxzXDstBSdW0qAwZBZ/PxshfQN3w= Message-ID: In-Reply-To: <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> References: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> <9436292ea880757cf47a5ce59879e6e7098ff195.camel@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: ZmnSCPxj X-ACL-Warn: , ZmnSCPxj via Guix-patches From: ZmnSCPxj via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615894099; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=N2l3CP59WcYBg24Bn3fTT1Chet9exmgxUzJIly6XLgI=; b=DSqLGUp5gG9KFlv5dyITjhIHyVT9YtGPMXRvj/wqNp0RlunQ0AljUJmbIXzNKU2KuiP2Ki FGRbXZSoXq8eXeY10aj5pWJtWfdq11BiHNfCSy62dSkagmlBDKv23zE9y2ycGLpUlMyFi0 iWiMiuwZmGyS+tVhdu4AxctvMoLh8h2V/bG8U3VLCl6+46U4T30MkF1CVpWX+IjJ2tlQ58 s7CHZ+qNXwgbAPV+TIhnCcQJQ5zABYnN5sFU/yxs4UjXYIM+GOCUmJ7XpScHtV75y+ph2O 7CS6Kcjug1y4Y5hAfCuE349Tkc/yBTGKB164jG4A29V8gMunG3y96FiwkT03EQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615894099; a=rsa-sha256; cv=none; b=RLCLoCA5xek6vfXtLFvkPy3ElYcx+B76rHhw9tj5NW71DsvoDkg8/XC9muZHBpEoD5+mlL 1Jgr7PT/wADBCj+riHq7uuCJFdBVhW01FQLan3oZZ9e+4kAGN4bCgEW5ImgVGMu5QoUrv9 HUx5sZXnj7Mtb6uiptxk+DQCj5M2K4GYVFOP12fqNigkT9RVFo3T7CJl9VU+vieSjSwZcC KN3ZpQonB0lNcG75jlowkRjDbm6ihY8yzu9sJUVpHB1wVQn2Jutq8erDazq11/R+L7VZZH 3DOpepKwumDN7/TXMiTRxSo6LkHVmPyU63Ug8Ccz7ukTJB3qMhd678uWBfyzYA== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=E7QoKHhz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx2.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=E7QoKHhz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D6B7AB1A1 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: AkopzKyTo3Ly Good morning Leo, > The various hacks in the recipe to get a working build seem troublesome > maintenance-wise, is it possible you think since you are a developer > that you make the build scripts a bit more standard in the project? Already working on that, but 0.10.0 will release soon and I doubt my change= s will make it by then, so Guix might get c-lightning to 0.10.1 or later if= we wait for it. > I see there's some vendored libraries: gheap, jsmn, libbacktrace, > libsodium, libwally-core ; Is it possible to unvendor those and create > separate packages for each of them? Or is there a requirement of strict > behavior here, either way, you could also create separate packages for > each of them even if those are specific to c-lightning. It would make > the main recipe cleaner, since as far as I can see it's also why the > build system is so stubborn to GNU Guix? That it also attempts to build > vendored libraries? I think it is more the custom `configure` script. The custom `configure` script also compiles a ***C*** program that then gen= erates the configuration for the `ccan` library of the project, meaning cro= ss-compilation requires special work for C-Lightning. And `configure` does not call `configure` of the included libraries as well= . Yes, it is true that there is something of a requirement of a strict behavi= or here, I suppose it is possible to use `git-fetch` instead of `url-fetch`= for our external libraries. How do I generate `guix hash` for `git-fetch`ed `source`s? However it also means that every release of C-Lightning I have to go double= -check what git commit to use for each library (though `jsmn` and `libbackt= race` at least seem very stable). But it looks to me that unvendoring will require more extensive patching of= the `Makefile` and an even larger maintenance burden on Guix side? `libwally-core` itself depends on another library `libsecp256k1`, so I supp= ose it must transitively be unvendored as well. > Additionally, please do enable the test suite it's really valuable in > GNU Guix. The test suite is fairly large and can take a significant amount of time to= run in full. In addition, part of the test includes checks which take advantage of `BINT= OPKGLIBEXECDIR` relative path we normally use, which I want to disable for = Guix at least since the relative path only has an advantage if the user wan= ts to move the installation after-the-fact to a different location (and on = Guix the "installation" path cannot be moved anyway). Using an absolute `BINTOPKGLIBEXECDIR` gives an advantage as mentioned in t= he comments that a profile being upgraded from one version of C-Lightning t= o another does not cause problems for daemons currently running off the pro= file. The test can be disabled (but not easily), I suppose. > I can help packaging the necessary Python dependencies, also we have a > Python importer, e.g. "$ guix import pypi -r " to help us go > faster at it. Please do, I am not very familiar with any Python infrastructure and am pri= marily a C programmer here, I just barely hack together some kind of test i= n Python. Regards, ZmnSCPxj