From: "Sergio Pastor Pérez" <sergio.pastorperez@outlook.es>
To: jgart <jgart@dismail.de>, 67755@debbugs.gnu.org
Subject: [bug#67755] [PATCH] gnu: Add imhex.
Date: Mon, 26 Aug 2024 23:51:17 +0200 [thread overview]
Message-ID: <PAXP251MB0348778D33DA5D0855B4EC0DF38B2@PAXP251MB0348.EURP251.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87r0ceqign.fsf@dismail.de>
jgart <jgart@dismail.de> writes:
> Hi Sergio,
>
> It looks like this patch still needs some work from the TODO comments.
>
> Are you planning on resolving those TODO items soonish?
Hi!
I went ahead and unbundled all I could from the package. There are still
some vendored libraries that I think it's unreasonable to pacakge in
Guix, since they won't be useful for other packages. I added multiple
comments explaining why certain libraries remain bundled in the
package. You will see that, although I made Guix packages for most
libraries so they can be used by other users, for others I had to deploy
their source code in-tree. This is due to ImHex not supporting
unbundling them. After some discussions with the maintainers, the effort
required to refactor the build system to support a more modular
compilation, is out of the scope of the protect; the changes you see in
the following patches is the best I could do with a reasonable amount of
effort.
I hope this brings the package up to Guix's standards and
allows us to merge it.
Good night,
Sergio.
next prev parent reply other threads:[~2024-08-26 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 20:06 [bug#67755] [PATCH] gnu: Add imhex Sergio Pastor Pérez
2024-06-29 12:15 ` [bug#67755] [PATCH v2] " Sergio Pastor Pérez
2024-06-30 20:33 ` [bug#67755] [PATCH] " jgart via Guix-patches via
2024-07-01 17:02 ` Sergio Pastor Pérez
2024-08-26 21:51 ` Sergio Pastor Pérez [this message]
2024-08-26 22:32 ` Sergio Pastor Pérez
2024-07-01 16:55 ` [bug#67755] [PATCH v3] " Sergio Pastor Pérez
2024-08-26 22:01 ` [bug#67755] [PATCH v4 1/8] gnu: Add edlib Sergio Pastor Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXP251MB0348778D33DA5D0855B4EC0DF38B2@PAXP251MB0348.EURP251.PROD.OUTLOOK.COM \
--to=sergio.pastorperez@outlook.es \
--cc=67755@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).