From: Nicholas von Klitzing <nicholas@nvk.pm>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 49737@debbugs.gnu.org
Subject: [bug#49737] [PATCH] Update nheko
Date: Thu, 29 Jul 2021 13:29:13 +0000 [thread overview]
Message-ID: <Ovk2O2E1L5fLcMrZJ052hJLd6n5mf6PKAGqdDbq0r3R8Egft4RhMhVuAiET5QBdSJ0dDYImZBKE9YQ0wPRmMOzBldqpy9dmhBSCZ2f-O7HU=@nvk.pm> (raw)
In-Reply-To: <87eebmngta.fsf@guix.i-did-not-set--mail-host-address--so-tickle-me>
[-- Attachment #1.1: Type: text/plain, Size: 1127 bytes --]
Hi Nicolò,
Thanks for informing me of those patches. I had not checked the GNU Bug Tracker.
The patch in bug#46012 looks good to me. It covers everything and more I wanted to address in my patch.
I unfortunately do not have the guix experience to be of much help for the issue relating to the exact specifics how it should be packaged.
What is currently blocking the merge?
Best,
Nicholas
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, July 26th, 2021 at 12:56 AM, Nicolò Balzarotti <anothersms@gmail.com> wrote:
> Nicholas von Klitzing nicholas@nvk.pm writes:
>
> > Hello,
>
> Hi,
>
> > Attached is a patch to update nheko, update 2 nheko dependencies, and add VoIP support to nheko.
>
> Have you taken a look at other patches available on the mailing list?
>
> For example there are bug#46012 and bug#48822 to name a few. It
>
> would be wonderful if somebody could review & merge bug#46012 (which
>
> IIRC it's the best one). Could you compare yours with it and report
>
> back on the other issue?
>
> Thanks,
>
> Nicolò
[-- Attachment #1.2: publickey - nicholas@nvk.pm - 0xE46F87BA.asc --]
[-- Type: application/pgp-keys, Size: 717 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]
next prev parent reply other threads:[~2021-07-29 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 21:31 [bug#49737] [PATCH] Update nheko Nicholas von Klitzing
2021-07-25 22:56 ` Nicolò Balzarotti
2021-07-29 13:29 ` Nicholas von Klitzing [this message]
2021-07-29 13:31 ` Nicolò Balzarotti
2021-07-29 13:53 ` Nicholas von Klitzing
2021-07-30 12:21 ` Nicolò Balzarotti
2022-09-15 8:37 ` bug#49737: " Michael Rohleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='Ovk2O2E1L5fLcMrZJ052hJLd6n5mf6PKAGqdDbq0r3R8Egft4RhMhVuAiET5QBdSJ0dDYImZBKE9YQ0wPRmMOzBldqpy9dmhBSCZ2f-O7HU=@nvk.pm' \
--to=nicholas@nvk.pm \
--cc=49737@debbugs.gnu.org \
--cc=anothersms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).