unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: 宋文武 <iyzsong@outlook.com>
To: rg@raghavgururajan.name
Cc: Leo Prikler <leo.prikler@student.tugraz.at>,
	leo@famulari.name, 47643@debbugs.gnu.org
Subject: [bug#47643] WIP-GNOME: gst-plugins-base
Date: Sat, 10 Apr 2021 18:35:02 +0800	[thread overview]
Message-ID: <OSZP286MB0664A9BA47B725DB977D4A50A3729@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210409183900.24175-3-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Fri, 9 Apr 2021 20:38:51 +0200")

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> From: Raghav Gururajan <rg@raghavgururajan.name>
>
> * gnu/packages/gstreamer.scm (gst-plugins-base)[version]: Update to 1.18.4.
> [arguments](glib-or-gtk): New argument.
> [configure-flags](gl): Remove flag.
> [phases](pre-check): New phase.
> [native-inputs]: Add gettext-minimal, gsettings-desktop-schemas, perl
> and xorg-server-for-tests.
> [propagated-inputs]: Add glib-networking.
> [synopsis]: Fix indentation.

Hello, what 'glib-or-gtk? #t', glib-networking,
gsettings-desktop-schemas and perl are useful for?

Also I think it's better split this into 2 patches, one for update, one
for adding inputs. eg: (I also add some more inputs)


[-- Attachment #2: 0001-gnu-gst-plugins-base-Update-to-1.18.4.patch --]
[-- Type: text/x-patch, Size: 1422 bytes --]

From 31e372eb1a689a94024a8441b825b508aaa2ba37 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <rg@raghavgururajan.name>
Date: Sat, 10 Apr 2021 17:06:22 +0800
Subject: [PATCH] gnu: gst-plugins-base: Update to 1.18.4.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/gstreamer.scm (gst-plugins-base): Update to 1.18.4.

Signed-off-by: 宋文武 <iyzsong@member.fsf.org>
---
 gnu/packages/gstreamer.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a13e7879dd..cc8b29adcf 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -537,7 +537,7 @@ This package provides the core library and elements.")
 (define-public gst-plugins-base
   (package
     (name "gst-plugins-base")
-    (version "1.18.2")
+    (version "1.18.4")
     (source
      (origin
       (method url-fetch)
@@ -545,7 +545,7 @@ This package provides the core library and elements.")
                           name "-" version ".tar.xz"))
       (sha256
        (base32
-        "1b05kg46azrxxvq42c71071lfsnc34pw4vynnkczdqi6g0gzn16x"))))
+        "08w3ivbc6n4vdds2ap6q7l8zdk9if8417nznyqidf0adm0lk5r99"))))
     (build-system meson-build-system)
     (propagated-inputs
      `(("glib" ,glib)              ;required by gstreamer-sdp-1.0.pc
-- 
2.30.0


[-- Attachment #3: 0002-gnu-gst-plugins-base-Enable-more-features.patch --]
[-- Type: text/x-patch, Size: 3299 bytes --]

From 022de6b475411c1ab52fd63c4c12c4327cf2f4eb Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <rg@raghavgururajan.name>
Date: Sat, 10 Apr 2021 18:17:01 +0800
Subject: [PATCH 2/2] gnu: gst-plugins-base: Enable more features.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/gstreamer.scm (gst-plugins-base)
[inputs]: Add graphene, iso-codes, libgudev, libjpeg-turbo, libpng,
libvisual, mesa, wayland-protocols, wayland.
[native-inputs]: Add gettext-minimal and xorg-server-for-test.
[arguments]: Remove '-Dgl=disabled' from configure flags.  Add pre-check phase.

Signed-off-by: Leo Prikler <leo.prikler@student.tugraz.at>
Co-authored-by: 宋文武 <iyzsong@member.fsf.org>
---
 gnu/packages/gstreamer.scm | 37 ++++++++++++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 1e9f5444a7..0b5f14342e 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -559,6 +559,7 @@ This package provides the core library and elements.")
              '()
              `(("orc" ,orc)))))         ;required by gstreamer-audio-1.0.pc
     (inputs
+     ;; TODO: Add libvorbisidec
      `(("cdparanoia" ,cdparanoia)
        ("pango" ,pango)
        ("libogg" ,libogg)
@@ -569,21 +570,43 @@ This package provides the core library and elements.")
        ("libXext" ,libxext)
        ("libxv" ,libxv)
        ("alsa-lib" ,alsa-lib)
-       ("opus" ,opus)))
+       ("opus" ,opus)
+       ("graphene" ,graphene)
+       ("iso-codes" ,iso-codes)
+       ("libgudev" ,libgudev)
+       ("libjpeg" ,libjpeg-turbo)
+       ("libpng" ,libpng)
+       ("libvisual" ,libvisual)
+       ("mesa" ,mesa)
+       ("wayland-protocols" ,wayland-protocols)
+       ("wayland" ,wayland)))
     (native-inputs
-      `(("pkg-config" ,pkg-config)
-        ("glib:bin" ,glib "bin")
-        ("gobject-introspection" ,gobject-introspection)
-        ("python-wrapper" ,python-wrapper)))
+     `(("pkg-config" ,pkg-config)
+       ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("python-wrapper" ,python-wrapper)
+       ("gettext" ,gettext-minimal)
+       ("xorg-server" ,xorg-server-for-tests)))
     (arguments
-     `(#:configure-flags '("-Dgl=disabled")
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          ,@%common-gstreamer-phases
          (add-before 'configure 'patch
            (lambda _
              (substitute* "tests/check/libs/pbutils.c"
                (("/bin/sh") (which "sh")))
+             #t))
+         (add-before 'check 'pre-check
+           (lambda _
+             ;; Tests require a running X server.
+             (system "Xvfb :1 +extension GLX &")
+             (setenv "DISPLAY" ":1")
+             ;; Tests write to $HOME.
+             (setenv "HOME" (getcwd))
+             ;; Tests look for $XDG_RUNTIME_DIR.
+             (setenv "XDG_RUNTIME_DIR" (getcwd))
+             ;; For missing '/etc/machine-id'.
+             (setenv "DBUS_FATAL_WARNINGS" "0")
              #t)))))
     (home-page "https://gstreamer.freedesktop.org/")
     (synopsis
-- 
2.30.0


[-- Attachment #4: Type: text/plain, Size: 28 bytes --]


What do you think, thanks!

  reply	other threads:[~2021-04-10 10:34 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 19:30 [bug#47643] WIP-GNOME Raghav Gururajan via Guix-patches via
2021-04-07 20:42 ` [bug#47643] [PATCH 01/22] gnu: gstreamer: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 02/22] gnu: gst-plugins-base: Fix indentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 03/22] gnu: gst-plugins-base: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 04/22] gnu: gst-plugins-base: Add missing inputs to enable more features Raghav Gururajan via Guix-patches via
2021-04-08 23:22     ` Leo Famulari
2021-04-08 23:32       ` Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 05/22] gnu: gst-plugins-good: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 06/22] gnu: gst-plugins-ugly: " Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 07/22] gnu: ibus: Update to 1.5.24 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 08/22] gnu: ibus: Enable documentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 09/22] gnu: ibus: Enable memconf Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 10/22] gnu: ibus: Enable tests Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 11/22] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 12/22] gnu: gst-libav: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 13/22] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 14/22] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 15/22] gnu: zbar: Update to 0.23.92 Raghav Gururajan via Guix-patches via
2021-04-08 23:18     ` Leo Famulari
2021-04-09  2:21       ` Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 16/22] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-09 10:58     ` Léo Le Bouter via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 17/22] gnu: flite: Update to 2.2 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 18/22] gnu: gst-plugins-bad: Fix indentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 19/22] gnu: gst-plugins-bad: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 20/22] gnu: gst-plugins-bad: Add missing inputs to enable more features Raghav Gururajan via Guix-patches via
2021-04-08 23:20     ` Leo Famulari
2021-04-08 23:29       ` Raghav Gururajan via Guix-patches via
2021-04-09  8:28       ` Leo Prikler
2021-04-07 20:42   ` [bug#47643] [PATCH 21/22] gnu: gst-plugins-bad: Disable few more failing tests Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 22/22] gnu: gst-editing-services: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-09 18:38 ` [bug#47643] [PATCH staging 00/10] Update GStreamer " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 01/10] gnu: gstreamer: Update " Leo Prikler
2021-04-10  8:47     ` [bug#47643] WIP-GNOME 宋文武
2021-04-10 10:38       ` [bug#47643] WIP-GNOME: gstreamer 宋文武
2021-04-09 18:38   ` [bug#47643] [PATCH staging 02/10] gnu: gst-plugins-base: Update to 1.18.4 Leo Prikler
2021-04-10 10:35     ` 宋文武 [this message]
2021-04-10 12:06       ` [bug#47643] WIP-GNOME: gst-plugins-base Raghav Gururajan via Guix-patches via
2021-04-09 18:38   ` [bug#47643] [PATCH staging 03/10] gnu: gst-plugins-base: Add missing inputs to enable more features Leo Prikler
2021-04-10 11:00     ` [bug#47643] WIP-GNOME: gst-plugins-base 宋文武
2021-04-10 12:09       ` Raghav Gururajan via Guix-patches via
2021-04-09 18:38   ` [bug#47643] [PATCH staging 04/10] gnu: gst-plugins-good: Update to 1.18.4 Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 05/10] gnu: gst-plugins-ugly: " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 06/10] gnu: gst-libav: " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 07/10] gnu: gst-plugins-bad: " Leo Prikler
2021-04-09 19:33     ` Maxime Devos
2021-04-09 19:53       ` Leo Prikler
2021-04-10 10:13         ` Maxime Devos
2021-04-09 18:38   ` [bug#47643] [PATCH staging 08/10] gnu: gst-plugins-bad: Add missing inputs to enable more features Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 09/10] gnu: gst-plugins-bad: Disable few more failing tests Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 10/10] gnu: gst-editing-services: Update to 1.18.4 Leo Prikler
2021-04-10 11:24   ` [bug#47643] WIP-GNOME 宋文武
2021-04-10 13:19     ` Leo Prikler
2021-04-12  9:36 ` [bug#47643] [PATCH staging v2 1/9] gnu: gstreamer: Update to 1.18.4 Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 2/9] gnu: gst-plugins-base: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 3/9] gnu: gst-plugins-base: Enable more features Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 4/9] gnu: gst-plugins-good: Update to 1.18.4 Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 5/9] gnu: gst-plugins-ugly: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 6/9] gnu: gst-libav: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 7/9] gnu: gst-plugins-bad: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 8/9] gnu: gst-plugins-bad: Add missing inputs to enable more features Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 9/9] gnu: gst-editing-services: Update to 1.18.4 Leo Prikler
2021-04-12 14:57     ` Maxime Devos
2021-04-12 15:59       ` Leo Prikler
2021-04-14 10:57 ` [bug#47643] [PATCH v2 06/18] gnu: ibus: Update to 1.5.24 Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 07/18] gnu: ibus: Enable documentation Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 08/18] gnu: ibus: Enable memconf Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 09/18] gnu: ibus: Enable tests Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 10/18] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 12/18] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 13/18] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 14/18] gnu: zbar: Update to 0.23.90 Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 15/18] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-14 12:08 ` [bug#47643] [PATCH core-updates 0/5]: Non-topical changes Raghav Gururajan via Guix-patches via
2021-04-14 12:08 ` [bug#47643] [PATCH core-updates 1/5] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 2/5] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 3/5] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 4/5] gnu: zbar: Update to 0.23.90 Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 5/5] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-19 16:58 ` bug#47643: (no subject) Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSZP286MB0664A9BA47B725DB977D4A50A3729@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM \
    --to=iyzsong@outlook.com \
    --cc=47643@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=leo@famulari.name \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).