unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Carl Dong <accounts@carldong.me>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org>
Subject: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc.
Date: Mon, 13 May 2019 02:46:39 +0000	[thread overview]
Message-ID: <O0Vs2q0_-33GQP3OOX7WdpAtozqA5khmB2tPcndkUAbxZaWBx8eRpFIu7Yx82YNoUv5SpAq6AJU-277Q__Wl5pOk-qiiH9JhTkbp-OlpnrM=@carldong.me> (raw)
In-Reply-To: <87woivs660.fsf@gnu.org>

Hi Ludovic,

> Really a detail, but for clarity I would change “xlibc” to “libc”, because
> this argument denotes a C library, not a cross-compiled C library.
>
> Ditto in other places.
>
> You can send an updated patch or I can make this change on your behalf if you
> prefer, let me know!

Ah yes! That does make it more clear. Could you make this change for me? Thanks!

> This procedure is starting to look weird. :-) I wonder if we should inline it
> at the call sites, but we can look into it later.

Haha that's what I thought too... Inlining would probably make the most sense.
I'll submit another patch to this effect at some point!

Thank you so much for your help. Have an excellent day!

Cheers,
Carl Dong
accounts@carldong.me
"I fight for the users"

  reply	other threads:[~2019-05-13  2:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-06 22:21 [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc Carl Dong
2019-05-06 22:34 ` [bug#35611] [PATCH 2/2] gnu: Allow building gcc with non-default libc Carl Dong
2019-05-12 21:41   ` Ludovic Courtès
2019-05-12 21:40 ` [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc Ludovic Courtès
2019-05-13  2:46   ` Carl Dong [this message]
2019-05-13  7:45     ` bug#35611: " Ludovic Courtès
2019-05-13 10:09     ` [bug#35611] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='O0Vs2q0_-33GQP3OOX7WdpAtozqA5khmB2tPcndkUAbxZaWBx8eRpFIu7Yx82YNoUv5SpAq6AJU-277Q__Wl5pOk-qiiH9JhTkbp-OlpnrM=@carldong.me' \
    --to=accounts@carldong.me \
    --cc=35611@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).