unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
* [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package.
@ 2021-11-21 21:15 John Kehayias via Guix-patches via
  2021-11-21 21:23 ` John Kehayias via Guix-patches via
  2021-11-22  1:42 ` bug#52028: " Maxim Cournoyer
  0 siblings, 2 replies; 4+ messages in thread
From: John Kehayias via Guix-patches via @ 2021-11-21 21:15 UTC (permalink / raw)
  To: 52028

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Hello,

After much time spent trying to fix/update python-nautilus failing on core-updates-frozen, I realized this is not actually a package needed by anything in Guix. Packages actually wanted nautilus-python for integration with the nautilus file manager, not this one: https://gitlab.gnome.org/GNOME/nautilus-python

Since the package is unused by other packages then, and dates from 2016 (perhaps inactive), I've gone ahead and removed it. This should fix (or help fix) the related builds failing on core-updates-frozen.

I've tested that one of the packages that have this as an input, syncthing-gtk, builds and runs without it. I have not tried the others but have checked upstream listed nautilus-python as what they wanted which is a different package.

I have a WIP patch that added some python packages that were needed to update python-nautilus, which I'll send as a bug report in case it is helpful to someone later.

Thanks,
John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-python-nautilus-Remove-package.patch --]
[-- Type: text/x-patch; name=0001-gnu-python-nautilus-Remove-package.patch, Size: 4029 bytes --]

From 701b723d9da070c7e1515463b3023b9638c9cef2 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 21 Nov 2021 15:58:38 -0500
Subject: [PATCH] gnu: python-nautilus: Remove package.

This package dates from 2016 and looks inactive. The packages that used this
as an input actually wanted nautilus-python (not currently packaged),
for (optional) integration with the nautilus file manager.

* gnu/packages/python-xyz.scm (python-nautilus): Remove variable.
* gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect)[inputs]: Remove
it.
* gnu/packages/sync.scm (nexcloud-client)[inputs]: Remove it.
* gnu/packages/syncthing.scm (syncthing-gtk)[inputs]: Remove it.
---
 gnu/packages/gnome-xyz.scm  |  1 -
 gnu/packages/python-xyz.scm | 33 ---------------------------------
 gnu/packages/sync.scm       |  1 -
 gnu/packages/syncthing.scm  |  1 -
 4 files changed, 36 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 6ba9656cdd..087dd97f7d 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -437,7 +437,6 @@ (define-public gnome-shell-extension-gsconnect
        ("nautilus" ,nautilus)
        ("openssh" ,openssh)
        ("openssl" ,openssl)
-       ("python-nautilus" ,python-nautilus)
        ("python-pygobject" ,python-pygobject)
        ("upower" ,upower)))
     (native-inputs
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index f7189e0ddd..2e54bf7758 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16991,39 +16991,6 @@ (define-public python-graphene
 with an associated set of resolve methods that know how to fetch data.")
     (license license:expat)))
 
-(define-public python-nautilus
-  (package
-    (name "python-nautilus")
-    (version "0.4.9")
-    (source
-      (origin
-        (method url-fetch)
-        (uri (pypi-uri "nautilus" version))
-        (sha256
-         (base32
-          "01hwzjc1zshk4vvxrcghm398fpy4jls66dyz06g07mrwqif8878p"))))
-    (build-system python-build-system)
-    (arguments `(#:tests? #f)) ; fails to import test modules
-    (propagated-inputs
-     `(("python-bcrypt" ,python-bcrypt)
-       ("python-click" ,python-click)
-       ("python-consul" ,python-consul)
-       ("python-graphene" ,python-graphene)
-       ("python-jinja2" ,python-jinja2)
-       ("python-peewee" ,python-peewee)
-       ("python-pika" ,python-pika)
-       ("python-tornado" ,python-tornado)
-       ("python-wtforms" ,python-wtforms)))
-    (native-inputs
-     `(("python-nose2" ,python-nose2)))
-    (home-page "https://github.com/AlecAivazis/nautilus")
-    (synopsis "Library for creating microservice applications")
-    (description
-     "Nautilus is a framework for flux based microservices that looks to
-provide extendible implementations of common aspects of a cloud so that you can
-focus on building massively scalable web applications.")
-    (license license:expat)))
-
 (define-public python-random2
   (package
     (name "python-random2")
diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index ad264a0fe3..946b64b452 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -190,7 +190,6 @@ (define-public nextcloud-client
        ("libcloudproviders" ,libcloudproviders)
        ("libzip" ,libzip)
        ("openssl" ,openssl)
-       ("python-nautilus" ,python-nautilus)
        ("qtbase" ,qtbase-5)
        ("qtdeclarative" ,qtdeclarative)
        ("qtgraphicaleffects" ,qtgraphicaleffects)
diff --git a/gnu/packages/syncthing.scm b/gnu/packages/syncthing.scm
index 4deb60bee2..8880801adb 100644
--- a/gnu/packages/syncthing.scm
+++ b/gnu/packages/syncthing.scm
@@ -191,7 +191,6 @@ (define-public syncthing-gtk
          ("python-dateutil" ,python-dateutil)
          ("python-pycairo" ,python-pycairo)
          ("python-pygobject" ,python-pygobject)
-         ("python-nautilus" ,python-nautilus)
          ("psmisc" ,psmisc)
          ("syncthing" ,syncthing)))
       ;; (native-inputs
-- 
2.34.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package.
  2021-11-21 21:15 [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package John Kehayias via Guix-patches via
@ 2021-11-21 21:23 ` John Kehayias via Guix-patches via
  2021-11-22  1:42 ` bug#52028: " Maxim Cournoyer
  1 sibling, 0 replies; 4+ messages in thread
From: John Kehayias via Guix-patches via @ 2021-11-21 21:23 UTC (permalink / raw)
  To: 52028

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Rather than open a bug report for a soon-to-be-removed package, I'm attaching the diff here. Please do not apply it.

I added a few packages that were needed as I made changes and updates, in case this is useful to someone down the line. I also did a hacky workaround of python-nautilus having some template files getting compiled that probably should be skipped. Copying them to /tmp and back afterward was probably not how we should do it, but again, in case someone wants to revive this package. I should note that build failure was new on core-updates-frozen and this diff fails on the sanity-check.

Again, the actual patch is in the first message, this is just a diff in case someone wants to revive python-nautilus (though check again, probably want nautilus-python from Gnome).

John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nautilus-wip.diff --]
[-- Type: text/x-patch; name=nautilus-wip.diff, Size: 6711 bytes --]

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e882659d4b..c9801f14f1 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15321,14 +15321,14 @@ (define-public python2-tabulate
 (define-public python-kazoo
   (package
     (name "python-kazoo")
-    (version "2.4.0")
+    (version "2.8.0")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "kazoo" version))
        (sha256
         (base32
-         "16y213k7r8shyn2zw1k6lkzjgcrvm441pqv8scvcjixhvpbx3hm7"))))
+         "1zpj5cc8624w6i0pxgcxqkjwbkm4pkrv19d7wh5df3jais32g3jq"))))
     (build-system python-build-system)
     (arguments '(#:tests? #f)) ; XXX: needs zookeeper
     (propagated-inputs
@@ -16948,31 +16948,151 @@ (define-public python-graphene
 with an associated set of resolve methods that know how to fetch data.")
     (license license:expat)))
 
+(define-public python-aiohttp-session
+  (package
+    (name "python-aiohttp-session")
+    (version "2.9.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiohttp-session" version))
+       (sha256
+        (base32 "0x7b5bl36d045l320v0g5rm0c000zdy626cpl1y0xqw4id31754m"))))
+    (build-system python-build-system)
+    (propagated-inputs (list python-aiohttp python-cryptography python-pynacl))
+    (home-page "https://github.com/aio-libs/aiohttp_session/")
+    (synopsis "sessions for aiohttp.web")
+    (description "sessions for aiohttp.web")
+    (license #f)))
+
+(define-public python-aiohttp-jinja2
+  (package
+    (name "python-aiohttp-jinja2")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiohttp-jinja2" version))
+       (sha256
+        (base32 "02wiky2ra4nbdxgb5lpb29bsg8pwg4nsyd05wps93dk0q3maafvw"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     (list python-aiohttp python-jinja2 python-typing-extensions))
+    (native-inputs
+     (list python-pytest))
+    (home-page "https://github.com/aio-libs/aiohttp_jinja2/")
+    (synopsis
+     "jinja2 template renderer for aiohttp.web (http server for asyncio)")
+    (description
+     "jinja2 template renderer for aiohttp.web (http server for asyncio)")
+    (license #f)))
+
+(define-public python-aiohttp-cors
+  (package
+    (name "python-aiohttp-cors")
+    (version "0.7.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiohttp_cors" version))
+       (sha256
+        (base32 "0pczn54bqd32v8zhfbjfybiza6xh1szwxy6as577dn8g23bwcfad"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ; some (all?) tests need http access
+    (propagated-inputs (list python-aiohttp
+                             python-selenium ; for tests
+                             python-typing))
+    (native-inputs
+     (list python-pytest python-pytest-cov python-pytest-runner)) ; for tests
+    (home-page "https://github.com/aio-libs/aiohttp-cors")
+    (synopsis "CORS support for aiohttp")
+    (description "CORS support for aiohttp")
+    (license license:asl2.0)))
+
+(define-public python-kafka-python
+  (package
+    (name "python-kafka-python")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "kafka-python" version))
+       (sha256
+        (base32 "1qypm52iv81kvb2khrj0fj6n17bhdvca4y9ydz6jcdxnlbzfgpq4"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ; need to manually copy tox.ini?
+    (native-inputs (list python-tox))
+    (home-page "https://github.com/dpkp/kafka-python")
+    (synopsis "Pure Python client for Apache Kafka")
+    (description "Pure Python client for Apache Kafka")
+    (license #f)))
+
+(define-public python-aiokafka
+  (package
+    (name "python-aiokafka")
+    (version "0.7.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "aiokafka" version))
+       (sha256
+        (base32 "15ih5hn7jin0vliqjk5g7pv5fm5zgsp97jxfhfa8gn1ihz8l3z58"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ; some (all?) tests need http access
+    (propagated-inputs (list python-dataclasses python-kafka-python))
+    (home-page "http://aiokafka.readthedocs.org")
+    (synopsis "Kafka integration with asyncio.")
+    (description "Kafka integration with asyncio.")
+    (license #f)))
+
 (define-public python-nautilus
   (package
     (name "python-nautilus")
-    (version "0.4.9")
+    (version "0.5.2")
     (source
       (origin
         (method url-fetch)
         (uri (pypi-uri "nautilus" version))
         (sha256
          (base32
-          "01hwzjc1zshk4vvxrcghm398fpy4jls66dyz06g07mrwqif8878p"))))
+          "1phdams5zqjfmaaf0dzcp37rndcrfb78qxx3lhqmwvswq60hnibj"))))
     (build-system python-build-system)
-    (arguments `(#:tests? #f)) ; fails to import test modules
+    (arguments
+     `(#:tests? #f ; fails to import test modules
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'move-templates
+           (lambda _
+             (copy-recursively "nautilus/management/templates" "/tmp/naut")
+             (delete-file-recursively "nautilus/management/templates")
+             #t))
+         (add-after 'install 'restore-templates
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((lib (string-append (assoc-ref outputs "out") "/lib/python3.9/site-packages/nautilus/management/templates")))
+               (copy-recursively "/tmp/naut" lib))
+             #t)))))
     (propagated-inputs
-     `(("python-bcrypt" ,python-bcrypt)
+     `(("python-aiohttp" ,python-aiohttp)
+       ("python-aiohttp-cors" ,python-aiohttp-cors)
+       ("python-aiohttp-jinja2" ,python-aiohttp-jinja2)
+       ("python-aiokafka" ,python-aiokafka)
+       ("python-aiohttp-session" ,python-aiohttp-session)
+       ("python-pykafka" ,python-pykafka)
+       ("python-bcrypt" ,python-bcrypt)
        ("python-click" ,python-click)
        ("python-consul" ,python-consul)
+       ("python-cryptography" ,python-cryptography)
        ("python-graphene" ,python-graphene)
        ("python-jinja2" ,python-jinja2)
        ("python-peewee" ,python-peewee)
-       ("python-pika" ,python-pika)
-       ("python-tornado" ,python-tornado)
-       ("python-wtforms" ,python-wtforms)))
+       ("python-pyjwt" ,python-pyjwt)
+       ("python-uvloop" ,python-uvloop)))
     (native-inputs
-     `(("python-nose2" ,python-nose2)))
+     `(("python-nose2" ,python-nose2)
+       ("python-pytest" ,python-pytest)))
     (home-page "https://github.com/AlecAivazis/nautilus")
     (synopsis "Library for creating microservice applications")
     (description

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52028: [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package.
  2021-11-21 21:15 [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package John Kehayias via Guix-patches via
  2021-11-21 21:23 ` John Kehayias via Guix-patches via
@ 2021-11-22  1:42 ` Maxim Cournoyer
  2021-11-22  1:49   ` [bug#52028] " John Kehayias via Guix-patches via
  1 sibling, 1 reply; 4+ messages in thread
From: Maxim Cournoyer @ 2021-11-22  1:42 UTC (permalink / raw)
  To: John Kehayias; +Cc: 52028-done

Hello,

John Kehayias <john.kehayias@protonmail.com> writes:

> Hello,
>
> After much time spent trying to fix/update python-nautilus failing on
> core-updates-frozen, I realized this is not actually a package needed
> by anything in Guix. Packages actually wanted nautilus-python for
> integration with the nautilus file manager, not this one:
> https://gitlab.gnome.org/GNOME/nautilus-python

Good catch!

> Since the package is unused by other packages then, and dates from 2016 (perhaps inactive), I've gone ahead and removed it. This should fix (or help fix) the related builds failing on core-updates-frozen.
>
> I've tested that one of the packages that have this as an input,
> syncthing-gtk, builds and runs without it. I have not tried the others
> but have checked upstream listed nautilus-python as what they wanted
> which is a different package.
>
> I have a WIP patch that added some python packages that were needed to update python-nautilus, which I'll send as a bug report in case it is helpful to someone later.
>
> Thanks,
> John
>
> From 701b723d9da070c7e1515463b3023b9638c9cef2 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias@protonmail.com>
> Date: Sun, 21 Nov 2021 15:58:38 -0500
> Subject: [PATCH] gnu: python-nautilus: Remove package.
>
> This package dates from 2016 and looks inactive. The packages that used this
> as an input actually wanted nautilus-python (not currently packaged),
> for (optional) integration with the nautilus file manager.
>
> * gnu/packages/python-xyz.scm (python-nautilus): Remove variable.
> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-gsconnect)[inputs]: Remove
> it.
> * gnu/packages/sync.scm (nexcloud-client)[inputs]: Remove it.
> * gnu/packages/syncthing.scm (syncthing-gtk)[inputs]: Remove it.

Applied.  Thanks!

Maxim




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package.
  2021-11-22  1:42 ` bug#52028: " Maxim Cournoyer
@ 2021-11-22  1:49   ` John Kehayias via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: John Kehayias via Guix-patches via @ 2021-11-22  1:49 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: 52028-done

Hi Maxim,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Sunday, November 21st, 2021 at 8:42 PM, Maxim Cournoyer wrote:
...
>
> Applied. Thanks!
>

Great, thanks! That was the last piece of core-updates-frozen for my system (other than Wine needing i686 dependencies). A little slower on the sprint, but looks like we're getting there now.

John




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-22  1:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-21 21:15 [bug#52028] [core-updates-frozen] [PATCH] gnu: python-nautilus: Remove package John Kehayias via Guix-patches via
2021-11-21 21:23 ` John Kehayias via Guix-patches via
2021-11-22  1:42 ` bug#52028: " Maxim Cournoyer
2021-11-22  1:49   ` [bug#52028] " John Kehayias via Guix-patches via

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).