From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0B+hIwfVo2FD1AAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 20:14:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iD4kHwfVo2FAAQAAbx9fmQ (envelope-from ) for ; Sun, 28 Nov 2021 19:14:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2187FFEE0 for ; Sun, 28 Nov 2021 20:14:15 +0100 (CET) Received: from localhost ([::1]:35514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrPcs-0002tB-8s for larch@yhetil.org; Sun, 28 Nov 2021 14:14:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrPch-0002sv-1b for guix-patches@gnu.org; Sun, 28 Nov 2021 14:14:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrPcg-0000zB-P6 for guix-patches@gnu.org; Sun, 28 Nov 2021 14:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrPcg-0001Ws-IU for guix-patches@gnu.org; Sun, 28 Nov 2021 14:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51920] [PATCH v2] gnu: Add inkbox. Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51920 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 51920@debbugs.gnu.org X-Debbugs-Original-Cc: 51920@debbugs.gnu.org, phodina via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.16381267875807 (code B ref -1); Sun, 28 Nov 2021 19:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Nov 2021 19:13:07 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrPbi-0001VR-KN for submit@debbugs.gnu.org; Sun, 28 Nov 2021 14:13:07 -0500 Received: from lists.gnu.org ([209.51.188.17]:37168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrPbZ-0001Un-Jj for submit@debbugs.gnu.org; Sun, 28 Nov 2021 14:12:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrPbY-0002ps-LL for guix-patches@gnu.org; Sun, 28 Nov 2021 14:12:53 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:44500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrPbV-0000vW-Ma for guix-patches@gnu.org; Sun, 28 Nov 2021 14:12:52 -0500 Date: Sun, 28 Nov 2021 19:12:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1638126761; bh=Nq9gJqVQPRN3s/b1THFMOlETUlXHpzIe5lOtrCzJtTA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=xyHNAFuKesPJ1LuxWGV4VysJegiPbFyW+q76cJPAW9oxgnUCXZuozSDvN4rPtYf1y V2bdCUSq6fuemP21ID2O+XOZEHWcyaS6Zcwzs95ws96mB+OrrEKjCaNEF/SHL7bs/Y xOyJlVecqoMjx4UnHvhlgVKBCQjOo5vs3kLhSxIg= Message-ID: In-Reply-To: <878rxhut7a.fsf@nicolasgoaziou.fr> References: <878rxhut7a.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_WJGAEthZzjiQv2VqKd2KqDu3s9979iwsTpCOTizWSA" Received-SPF: pass client-ip=185.70.40.134; envelope-from=phodina@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches From: phodina via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638126855; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Nq9gJqVQPRN3s/b1THFMOlETUlXHpzIe5lOtrCzJtTA=; b=sGMC5aK4SS7auT6FXPRLahbz8KeTSo2mnG6Es7t0MayDHVj4cAuj07Dp1mVoWzL94iv/OM Q6MODY77woPJ226H8MugXqZjIvZ0K2X3hLh6n0Br4mYjfyg1TUqYTRVSybyOQ+krrHpkdF ElBKPYCd7qIeTZljYgn9QUzXsspYvXe74hhKeAG1jKxoVsyRvjQKRbAvS8AJBh2PZI1b/G eF22loSj7522yqzIvfpioup2YLdmrDYOSeWQv68StuhGI3nd8XFQ2Uepoqzn1be1XzheV7 ud5srfZAadt1VVrYT2pM71KNYYk0iJmE9RvzzQzPd15Aov831IPzIRDW9FIAlA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638126855; a=rsa-sha256; cv=none; b=SlzzsyKcUi/EDw1deoOa09idlTL20x2WNMw3KTlZbbl4sTj/BqDn8+NsbahbZ8OnLGtnue 0OVoP+kJP3Q7McFqQifWTe/k2H4DNbwTwM322/+IcSKVI5zQ+TFgRXz9WPMA/bOtE+Qa5L Q79rkuaajhcWA6FmD/Q4WATwsEWEu9bvh8y6+7tjPsYADGh6Ac8XOutGmI2y8crprGITzw TdhLk+y5G7TGzf1WRmBp+gK1p/6ExO0F4Hm/Npld2H6SQUe/ZiLSol9LBwIS7+vfDrSLJK gspOeLirkfgrNMhNGdfVbUJ8GxGi7mDjBThTHZKkq/2YyruaPS5kje/jpz+tWg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=xyHNAFuK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=xyHNAFuK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2187FFEE0 X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: z4O+oMvTm8Ho This is a multi-part message in MIME format. --b1_WJGAEthZzjiQv2VqKd2KqDu3s9979iwsTpCOTizWSA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Nicolas, > Hello, > > phodina via Guix-patches via guix-patches@gnu.org writes: > > > - gnu/packages/qt.scm (inkbox): New variable. > > Thank you. Some comments follow. > > First, this should go to "ebook.scm" instead of "qt.scm". Thanks, that is a better place to put it. > > > - (source (origin > > You should instead a newline before "(origin". Fixed. > > > - (method git-fetch) > > > > > > - (uri > > > > > > - (git-reference > > > > > > - (url "https://alpinekobox.ddns.net/InkBox/inkbox/") > > > > > > - (commit version))) > > > > > > - (file-name (git-file-name name version)) > > > > > > - (sha256 > > > > > > - (base32 > > > > > > - "126cqn0ixcn608lv2hd9f7zmzj4g448bnpxc7wv9cvg83qqajh5= n")))) > > > > > > Nitpick: hash should go on the same line as base32. Fixed. > > > - (build-system qt-build-system) > > - (arguments > > - '(#:tests? #f > > > > > > You should add a comment explaining why tests are disabled (i.e.: there > > is no tests). Fixed. > > > - #:phases > > > > > > - (modify-phases %standard-phases > > > > > > - (add-after 'unpack 'prefix-opt > > > > > > - (lambda* _ > > > > > > - (substitute* "inkbox.pro" > > > > > > - (("/opt/\\\\$\\\\$\\\\{TARGET\\\\}") (string-append (= assoc-ref %outputs "out")))))) > > > > > > You should use (lambda* (#:key outputs #:allow-other-keys) ...) and then > > (assoc-ref outputs "out") instead. > > > - (replace 'configure > > > > > > - (lambda* (#:key make-flags #:allow-other-keys) > > Thanks, that is the correct syntax. > > > > - (apply invoke (cons "qmake" make-flags))))))) > > > > > > - (native-inputs > > - `(("qtbase" ,qtbase-5))) > > > > > > Does it fail with qtbase 6? Unfortunately it does not compile though it shouldn't be that hard to port = it. But here it is about packaging. > > > - (license license:gpl1))) > > License is actually gpl3, according to LICENSE file. Sorry, my mistake. > > Could you send an updated patch? > > Regards, > -------------------------------------------------------------------------= ------------------------- > > Nicolas Goaziou Thanks for the remarks! ---- Petr --b1_WJGAEthZzjiQv2VqKd2KqDu3s9979iwsTpCOTizWSA Content-Type: text/x-patch; name=v2-0001-gnu-Add-inkbox.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=v2-0001-gnu-Add-inkbox.patch RnJvbSA5ZGUwY2Q3MTEwMDY3MjhiZmJhYWY2ZjBiYzM5YmM3Y2QyYzIyOTE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogV2VkLCAxMCBOb3YgMjAyMSAyMjoyNDozMyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggdjJd IGdudTogQWRkIGlua2JveC4KCiogZ251L3BhY2thZ2VzL3F0LnNjbSAoaW5rYm94KTogTmV3IHZh cmlhYmxlLgoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9lYm9vay5zY20gYi9nbnUvcGFja2Fn ZXMvZWJvb2suc2NtCmluZGV4IGFiYjA0YjZkOTMuLmIyYmY0ZTZkZmIgMTAwNjQ0Ci0tLSBhL2du dS9wYWNrYWdlcy9lYm9vay5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Vib29rLnNjbQpAQCAtOSw2 ICs5LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCwgMjAyMSBWaW5pY2l1cyBNb25lZ28gPG1v bmVnb0Bwb3N0ZW8ubmV0PgogOzs7IENvcHlyaWdodCDCqSAyMDIwIFpoZW5nIEp1bmppZSA8ODcz MjE2MDcxQHFxLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMSBsYSBzbmVzbmUgPGxhc25lc25l QGxhZ3VucG9zcHJhc2lob3ByZS5vcmc+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjEgUGV0ciBIb2Rp bmEgPHBob2RpbmFAcHJvdG9ubWFpbC5jb20+CiA7OzsKIDs7OyBUaGlzIGZpbGUgaXMgcGFydCBv ZiBHTlUgR3VpeC4KIDs7OwpAQCAtMzUsNiArMzYsNyBAQCAoZGVmaW5lLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGVib29rKQogICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGdudSkKICAg Izp1c2UtbW9kdWxlIChndWl4IGJ1aWxkLXN5c3RlbSBtZXNvbikKICAgIzp1c2UtbW9kdWxlIChn dWl4IGJ1aWxkLXN5c3RlbSBweXRob24pCisgICM6dXNlLW1vZHVsZSAoZ3VpeCBidWlsZC1zeXN0 ZW0gcXQpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzKQogICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBhdXRvdG9vbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGNvbXBy ZXNzaW9uKQpAQCAtMzc2LDYgKzM3OCw0MiBAQCAoZGVmaW5lLXB1YmxpYyBlYm9vay10b29scwog YWNjZXNzaW5nIGFuZCBjb252ZXJ0aW5nIHZhcmlvdXMgZWJvb2sgZmlsZSBmb3JtYXRzLiIpCiAg ICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQogCisoZGVmaW5lLXB1YmxpYyBpbmtib3gKKyAg KHBhY2thZ2UKKyAgICAobmFtZSAiaW5rYm94IikKKyAgICAodmVyc2lvbiAiMS43IikKKyAgICAo c291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAo dXJpCisgICAgICAgIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAodXJsICJodHRwczovL2FscGlu ZWtvYm94LmRkbnMubmV0L0lua0JveC9pbmtib3gvIikKKyAgICAgICAgIChjb21taXQgdmVyc2lv bikpKQorICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAg ICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjEyNmNxbjBpeGNuNjA4bHYyaGQ5Zjd6bXpq NGc0NDhibnB4Yzd3djljdmc4M3FxYWpoNW4iKSkpKQorICAgIChidWlsZC1zeXN0ZW0gcXQtYnVp bGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgJygjOnRlc3RzPyAjZiAgICAgICAgICAg ICAgICAgICAgICA7IG5vIHRlc3Qgc3VpdGUKKyAgICAgICAjOm1ha2UtZmxhZ3MKKyAgICAgICAo bGlzdCAoc3RyaW5nLWFwcGVuZCAiUFJFRklYPSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoYXNzb2MtcmVmICVvdXRwdXRzICJvdXQiKSkpCisgICAgICAgIzpwaGFzZXMKKyAgICAgICAo bW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoYWRkLWFmdGVyICd1bnBh Y2sgJ3ByZWZpeC1vcHQKKyAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxv dy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAiaW5rYm94LnBybyIKKyAg ICAgICAgICAgICAgICgoIi9vcHQvXFwkXFwkXFx7VEFSR0VUXFx9IikgKHN0cmluZy1hcHBlbmQg KGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkpKSkpCisgICAgICAgICAocmVwbGFjZSAnY29uZmln dXJlCisgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBtYWtlLWZsYWdzICM6YWxsb3ctb3RoZXIt a2V5cykKKyAgICAgICAgICAgICAoYXBwbHkgaW52b2tlIChjb25zICJxbWFrZSIgbWFrZS1mbGFn cykpKSkpKSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgicXRiYXNlIiAscXRiYXNlLTUp KSkKKyAgICAoaG9tZS1wYWdlICJodHRwczovL2FscGluZWtvYm94LmRkbnMubmV0L0lua0JveC9p bmtib3gvIikKKyAgICAoc3lub3BzaXMgIkVCb29rIHJlYWRlciIpCisgICAgKGRlc2NyaXB0aW9u ICJUaGlzIHBhY2thZ2UgcHJvdmlkZXMgSW5rQm94IGVCb29rIHJlYWRlci4iKQorICAgIChsaWNl bnNlIGxpY2Vuc2U6Z3BsMykpKQorCiAoZGVmaW5lLXB1YmxpYyBsaWJsaW5lYnJlYWsKICAgKHBh Y2thZ2UKICAgICAobmFtZSAibGlibGluZWJyZWFrIikKLS0gCjIuMzMuMAoK --b1_WJGAEthZzjiQv2VqKd2KqDu3s9979iwsTpCOTizWSA--