From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WGfJDfXxAWAYGAAA0tVLHw (envelope-from ) for ; Fri, 15 Jan 2021 19:50:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yLGaCfXxAWDKOwAA1q6Kng (envelope-from ) for ; Fri, 15 Jan 2021 19:50:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADE509403EB for ; Fri, 15 Jan 2021 19:50:12 +0000 (UTC) Received: from localhost ([::1]:32874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0V6p-0006FR-HQ for larch@yhetil.org; Fri, 15 Jan 2021 14:50:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0V6g-0006F6-Oz for guix-patches@gnu.org; Fri, 15 Jan 2021 14:50:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0V6g-00065o-HI for guix-patches@gnu.org; Fri, 15 Jan 2021 14:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0V6g-0004gK-FP for guix-patches@gnu.org; Fri, 15 Jan 2021 14:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Jan 2021 19:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44249-submit@debbugs.gnu.org id=B44249.161074016817945 (code B ref 44249); Fri, 15 Jan 2021 19:50:02 +0000 Received: (at 44249) by debbugs.gnu.org; 15 Jan 2021 19:49:28 +0000 Received: from localhost ([127.0.0.1]:41779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0V68-0004fN-4c for submit@debbugs.gnu.org; Fri, 15 Jan 2021 14:49:28 -0500 Received: from mail-bn7nam10olkn2056.outbound.protection.outlook.com ([40.92.40.56]:33760 helo=NAM10-BN7-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0V64-0004f6-CP for 44249@debbugs.gnu.org; Fri, 15 Jan 2021 14:49:27 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O35Og1s8qx7mIdTFJiMog54JRz36HB5ZStmnnAaSbGirDXwkL5PostIftAqYhDCMqh2qjrAi1uU6elTfjqZb8aCvKPBY10mZ2A7drNfp/1LM9dqZJLNeKB1ibDyC8kt9NkCq9XJ64b+PydEujZ8urCR+0uFCgcn7cBQnzWJ0+egn4zU7Bs+v7AmwVJVFO7p+uZ9qZjYXLjX87eZZAiSDYASEkyTzGY2brY3LgPCfGG4Vtk1Iadv3C0xrP+FoksIZ42j/4/fJu3HJvRX6EZXQl2/m3V5A8XS2KhlqHqXiVdClu8UfV5pibPlUfFiOEsIJCZoAaKKHnjldzgeyiGOQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6W4G3X5TENhiNemjKwz2me6ZHjg7GtgOQ4A0Lp0/wnc=; b=hfYtpM5gq8NXqifJXbNuz5NzJpCDOYd+tczBn1vLVwfvxQOaZgJBdeZNIZBl62RdZsAcyJUxgNNE3EJE1jzuRulGFsspoowO9RawUJp66NSPQU8nTtBxheFDcOKAQUnYn6NKJ50kvSilsRn/M505N/5fmVYPz2sDLx/X5SOjVvXBooZAj+46Hwb5YmNztGj3wxgCqoKw5jBDoHdrQcWg231s21ccfPfskvtcHki5x/EmB249Fyn3gSC30xIvhef1CKkhM/qzDn3QEJDnpLlGG/dTva5VL0F3Hp1Fp+ZlNZk4AnX+pPTh7AAlfVvY0tKCAAhQxhAKncooFiB4zKF/dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6W4G3X5TENhiNemjKwz2me6ZHjg7GtgOQ4A0Lp0/wnc=; b=PYEoDRHYAUM5juRdXQWMKm7zK6RFjV6N52EGzuLJg19wGVR5j7TnFHO5nEIuIB2erBMXGrb07hjjSLjsyjVhpCQcpBH697bu1ETIz9ofeVePvzCiJSLA3o9YmENwcfS3FZyk5KAMrIHbKnohRceNRkkeF+nC9u1lphXKKnJP0qiW6sfdcAt2ZxgIPRUvSbbWPr/XhysjpaYP9nIiYcKMWmsw9KZNoJjFoBv9g8lJkErdm/RpXFpNkOzM87ZX4ZUyhmX6uwdpOxXgv4yPEVwRPNcbiURGo3ANVLTh043pqXeeC3FnsHGHhnznsa5ZOVuYiGt6sT1931GhrV+epWGSkg== Received: from DM6NAM10FT014.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::45) by DM6NAM10HT015.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e86::84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12; Fri, 15 Jan 2021 19:49:18 +0000 Received: from MWHPR0801MB3675.namprd08.prod.outlook.com (2a01:111:e400:7e86::4a) by DM6NAM10FT014.mail.protection.outlook.com (2a01:111:e400:7e86::281) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12 via Frontend Transport; Fri, 15 Jan 2021 19:49:18 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:870DAD861EFE1E59815EDE7E773FAFF2450E18D8BDB3B4D2F7B26E8A3D8A5182; UpperCasedChecksum:1919D1392E1D883809F1D6C53DA835ECDB62C02C221CB304241C32995052FFA8; SizeAsReceived:8840; Count:48 Received: from MWHPR0801MB3675.namprd08.prod.outlook.com ([fe80::b060:e3df:1e35:f237]) by MWHPR0801MB3675.namprd08.prod.outlook.com ([fe80::b060:e3df:1e35:f237%7]) with mapi id 15.20.3742.013; Fri, 15 Jan 2021 19:49:18 +0000 References: <874kjiz5vp.fsf_-_@gnu.org> From: Morgan Smith Message-ID: Date: Fri, 15 Jan 2021 14:49:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.0 In-Reply-To: <874kjiz5vp.fsf_-_@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TMN: [1N5Efk35nlj6tMnap5ojwlPppunoEd2W] X-ClientProxiedBy: YTOPR0101CA0064.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:14::41) To MWHPR0801MB3675.namprd08.prod.outlook.com (2603:10b6:301:7c::24) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.37] (70.30.20.141) by YTOPR0101CA0064.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:14::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Fri, 15 Jan 2021 19:49:17 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 29475bb9-87d1-458c-b029-08d8b98ea4ff X-MS-TrafficTypeDiagnostic: DM6NAM10HT015: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qa7fVV64o6jvRTXK+rkQn/3efGY3ZkYr+IbyoGtOuk8923RstEshBd/p3Vi3GBalvNRFsZwAoO9ZD5a3Qc3svG4DcZTDfwRxteZhWxo2Jr6d9dYkl7jI1namTWqWVOw2AcFKtJFhwHQQb1Jurifp/v2ijfyUCdyESnIos8oeBPpWg6EuD3Aow3n3KUJx3fJ3I5JQoN7bz251DCpU18LEYpetU6Mi+QVQUOGkmMpA26M33R2fy8e3A6W0O+HmSaXE X-MS-Exchange-AntiSpam-MessageData: vFDNfX8izYO5uFjmStH4uwvE9XLJoYsLbYFDvzPsLkGpkYxyzQgAHk05j7N5h7ib9wylrxi5cEWzVG0Gc64rZnCTt7aGTEekhcMynOTAIWQVGXc90oKcFmGfAkRSG9h9xUbyfY8chaGNB3sBL1RZeg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29475bb9-87d1-458c-b029-08d8b98ea4ff X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2021 19:49:18.1008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT014.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT015 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44249@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.74 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=outlook.com header.s=selector1 header.b=PYEoDRHY; arc=reject (signature check failed: fail, {[1] = sig:microsoft.com:reject}); dmarc=fail reason="SPF not aligned (relaxed)" header.from=outlook.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ADE509403EB X-Spam-Score: 0.74 X-Migadu-Scanner: scn1.migadu.com X-TUID: QTui55yfc5b/ I've actually been sorta half working on this for a while now. The problem is exactly that the modules field is inherited. See each build system includes its own module in the modules field. The various emacsen are built with different build systems. So emacs is going to need to import (guix build glib-or-gtk-build-system) and emacs-minimal is going to want (guix build gnu-build-system). By setting the modules to be the glib-or-gtk-build-system, we override the default modules in each inherited package. This means building emacs-minimal would result in this error: no code for module (guix build glib-or-gtk-build-system) I'm not entirely certain why it worked for you but it looks like maybe you included the gnu-build system instead of the glib-or-gtk-build-system. I think to solve this issue proper, we need to come up with a way to use %default-modules. Currently this variable isn't usable in this context, but as gnu/packages/code.scm:791 says: ";; FIXME use %default-modules"