From: Jean Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org>
To: "56354@debbugs.gnu.org" <56354@debbugs.gnu.org>,
"poptsov.artyom@gmail.com" <poptsov.artyom@gmail.com>
Subject: [bug#56354] [PATCH] gnu: engineering: Add candle.
Date: Mon, 11 Jul 2022 11:55:52 +0000 [thread overview]
Message-ID: <M7JKaZZ3AMO61QYlYKULMbrhV6ckNohCUBt_vyaGBKaMsQv3uZqHxtrn9ZJPOErEC7WobqLtq436qf4LPIWGQpVhIT9hz3ER60XjEagErQk=@jeandudey.tech> (raw)
In-Reply-To: <87o7y74zic.fsf@gmail.com>
Hello Artyom,
>It seems to me from the message that the issue is not in the candle
>package itself.
Probably one of the dependencies can't (currently) be cross-compiled,
anyway, thanks for setting the QMAKE_CC variable in the qmake invocation,
once perl build system gains cross-compilation (if possible) then it
would be easier to cross-compile later without modifications to the
package.
>+ (lambda* (#:key outputs #:allow-other-keys)
>+ (let ((out (assoc-ref outputs "out")))
>+ (chdir "src")
>+ (invoke "qmake"
>+ (string-append "QMAKE_CC="
>+ #$(cc-for-target))))))
The `out' variable is not used, so the let can be safely removed and the lambda
simplified, also instead of `chdir', `with-directory-excursion' could be used,
but's a matter of preference (don't know if one or other style is preferred
inside GNU Guix).
For example:
(lambda _
(with-directory-excursion "src"
(invoke "qmake"
(string-append "QMAKE_CC="
#$(cc-for-target)))))
>+ (replace 'install
>+ (lambda* (#:key outputs #:allow-other-keys)
>+ (let ((out (assoc-ref outputs "out")))
>+ (install-file "Candle"
>+ (string-append out "/bin"))))))))
The `out' binding can be also replaced by `#$output', e.g.:
(lambda* _
(install-file "Candle"
(string-append #$output "/bin")))
Other than that the package definition looks good to me, and did a quick pass
over the Candle source code to check that it doesn't contain any malware.
Only a bundled font is present (src/fonts/Ubuntu-Regular.tff), but that one is
not provided by GNU Guix (don't know the specific reasons, but got added then
removed) so no need to replace it with provided ones.
—
Jean-Pierre De Jesus DIAZ
next prev parent reply other threads:[~2022-07-11 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 9:47 [bug#56354] [PATCH] gnu: engineering: Add candle Artyom V. Poptsov
2022-07-04 3:36 ` Artyom V. Poptsov
2022-07-09 13:43 ` Artyom V. Poptsov
2022-07-05 12:16 ` [bug#56354] Review Jean Pierre De Jesus DIAZ via Guix-patches via
2022-07-11 11:55 ` Jean Pierre De Jesus DIAZ via Guix-patches via [this message]
2022-07-11 18:39 ` [bug#56354] [PATCH] gnu: engineering: Add candle Artyom V. Poptsov
2022-07-12 21:59 ` bug#56354: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='M7JKaZZ3AMO61QYlYKULMbrhV6ckNohCUBt_vyaGBKaMsQv3uZqHxtrn9ZJPOErEC7WobqLtq436qf4LPIWGQpVhIT9hz3ER60XjEagErQk=@jeandudey.tech' \
--to=guix-patches@gnu.org \
--cc=56354@debbugs.gnu.org \
--cc=me@jeandudey.tech \
--cc=poptsov.artyom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).