From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39307) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQXz7-0003OD-Jt for guix-patches@gnu.org; Fri, 01 Nov 2019 10:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQXz6-0000cN-7p for guix-patches@gnu.org; Fri, 01 Nov 2019 10:33:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47950) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQXz5-0000c5-Pg for guix-patches@gnu.org; Fri, 01 Nov 2019 10:33:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQXz5-0004dq-L2 for guix-patches@gnu.org; Fri, 01 Nov 2019 10:33:03 -0400 Subject: [bug#37912] [PATCH] gnu: elixir: Update to 1.9.2. Resent-Message-ID: Date: Fri, 1 Nov 2019 14:45:04 +0100 (CET) From: Oskar =?UTF-8?Q?K=C3=B6=C3=B6k?= Message-ID: In-Reply-To: <875zk4plty.fsf@devup.no> References: <875zk4plty.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2957_727507438.1572615904682" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 37912 <37912@debbugs.gnu.org> ------=_Part_2957_727507438.1572615904682 Content-Type: multipart/alternative; boundary="----=_Part_2958_1817126105.1572615904682" ------=_Part_2958_1817126105.1572615904682 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thank you for your response! You were right, /bin/sh was the issue. I did some grepping and found Elixir= was generating files that depend on /bin/sh. I am now able to build Elixir= 1.9.2 on Guix. I am attaching the patch to this e-mail. Please format/fix the code as nece= ssary, I am not too familiar with Guile and other Scheme/Lisp languages. Oskar Nov 1, 2019, 00:54 by mbakke@fastmail.com: > Oskar K=C3=B6=C3=B6k writes: > >> Sorry, first time using Guix. >> >> Some Elixir tests are failing, caused by a new feature. I have locally f= ixed most of the issues related to this (I can now manually run the Makefil= e in the generated Guix folder without any tests failing), but I am stuck o= n a part where the tests spawn binaries and wait for a certain file to be c= reated in a certain location. This does not work during the Guix build. >> > > Perhaps it requires a network connection? Or /bin/sh? Those are the > most common sources of things failing in the build container but not on > a "regular" system. > >> I will examine further over the weekend. If I can not fix these tests, i= s it acceptable to disable them? I can verify that the behaviour being test= ed works manually. >> > > We should find out why they are failing in either case. :-) > ------=_Part_2958_1817126105.1572615904682 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thank you for your response!

You were right, /bin/sh was the issue. I did some greppin= g and found Elixir was generating files that depend on /bin/sh. I am now ab= le to build Elixir 1.9.2 on Guix.

I am attaching = the patch to this e-mail. Please format/fix the code as necessary, I am not= too familiar with Guile and other Scheme/Lisp languages.

Oskar


Nov 1, 2019, 00:54 by mbakke@fastmail.com:
Oska= r K=C3=B6=C3=B6k <oskar@maatriks.ee> writes:
Sorry, first time using Guix.

Some Elixir tests are failing, caused by a new feature. I h= ave locally fixed most of the issues related to this (I can now manually ru= n the Makefile in the generated Guix folder without any tests failing), but= I am stuck on a part where the tests spawn binaries and wait for a certain= file to be created in a certain location. This does not work during the Gu= ix build.
Perhaps it requires a networ= k connection? Or /bin/sh? Those are the
most common sources of things failing in the build containe= r but not on
a "regular" s= ystem.
I will examine further over the weekend. If I c= an not fix these tests, is it acceptable to disable them? I can verify that= the behaviour being tested works manually.

= We should find out why they are failing in either case. :-)

------=_Part_2958_1817126105.1572615904682-- ------=_Part_2957_727507438.1572615904682 Content-Type: text/x-patch; charset=us-ascii; name=0001-gnu-elixir-Update-to-1.9.2.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-elixir-Update-to-1.9.2.patch >From f2eb88f567f93e578e3c2df76046fed4f45645f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20K=C3=B6=C3=B6k?= Date: Thu, 24 Oct 2019 23:37:38 +0300 Subject: [PATCH] gnu: elixir: Update to 1.9.2. * gnu/packages/elixir.scm (elixir): Update to 1.9.2. --- gnu/packages/elixir.scm | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm index 88ada71aea..144a8cc4e7 100644 --- a/gnu/packages/elixir.scm +++ b/gnu/packages/elixir.scm @@ -33,7 +33,7 @@ (define-public elixir (package (name "elixir") - (version "1.8.2") + (version "1.9.2") (source (origin (method git-fetch) @@ -42,7 +42,7 @@ (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1n77cpcl2b773gmj3m9s24akvj9gph9byqbmj2pvlsmby4aqwckq")) + (base32 "19yn6nx6r627f5zbyc7ckgr96d6b45sgwx95n2gp2imqwqvpj8wc")) (patches (search-patches "elixir-path-length.patch")))) (build-system gnu-build-system) (arguments @@ -63,9 +63,21 @@ "lib/mix/lib/mix/scm/git.ex") (("(cmd\\(['\"])git" _ prefix) (string-append prefix (which "git")))) + (substitute* '("lib/mix/lib/mix/release.ex" + "lib/mix/lib/mix/tasks/release.init.ex") + (("#!/bin/sh") + (string-append "#!" (which "sh")))) (substitute* "bin/elixir" - (("ERL_EXEC=\"erl\"") - (string-append "ERL_EXEC=" (which "erl")))) + (("ERTS_BIN=") + (string-append + "ERTS_BIN=" + ;; Elixir Releases will prepend to ERTS_BIN the path of a copy of erl. + ;; We detect if a release is being generated by checking the initial ERTS_BIN + ;; value: if it's empty, we are not in release mode and can point to the actual + ;; erl binary in Guix store. + "\nif [ -z \"$ERTS_BIN\" ]; then ERTS_BIN=" + (string-drop-right (which "erl") 3) + "; fi"))) (substitute* "bin/mix" (("#!/usr/bin/env elixir") (string-append "#!" out "/bin/elixir")))) -- 2.21.0 ------=_Part_2957_727507438.1572615904682--