From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sNZhHDax719tFQAA0tVLHw (envelope-from ) for ; Fri, 01 Jan 2021 23:33:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qUgSGDax71/9awAAbx9fmQ (envelope-from ) for ; Fri, 01 Jan 2021 23:33:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C91339402D4 for ; Fri, 1 Jan 2021 23:33:09 +0000 (UTC) Received: from localhost ([::1]:59050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvTuu-0007X0-Mb for larch@yhetil.org; Fri, 01 Jan 2021 18:33:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvTuo-0007Wu-LM for guix-patches@gnu.org; Fri, 01 Jan 2021 18:33:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvTuo-0000DI-EL for guix-patches@gnu.org; Fri, 01 Jan 2021 18:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvTuo-0004eS-Ax for guix-patches@gnu.org; Fri, 01 Jan 2021 18:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45584] [PATCH 0/2] system: image: Fix root fs corruption from certain u-boot. Resent-From: Caliph Nomble Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Jan 2021 23:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45584 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "45584@debbugs.gnu.org" <45584@debbugs.gnu.org> Received: via spool by 45584-submit@debbugs.gnu.org id=B45584.160954397617868 (code B ref 45584); Fri, 01 Jan 2021 23:33:02 +0000 Received: (at 45584) by debbugs.gnu.org; 1 Jan 2021 23:32:56 +0000 Received: from localhost ([127.0.0.1]:35038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvTui-0004e8-LZ for submit@debbugs.gnu.org; Fri, 01 Jan 2021 18:32:56 -0500 Received: from mail-40137.protonmail.ch ([185.70.40.137]:24795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvTuf-0004dt-Pd for 45584@debbugs.gnu.org; Fri, 01 Jan 2021 18:32:54 -0500 Date: Fri, 01 Jan 2021 23:32:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609543967; bh=EucyJif3MgERbVlmN1ks+UbpFIi9cly8KHmw8Qj7OKQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Lj6UvQaLBAjSg+PzA30C9nQG8rZs7grqxphZlobYQdbEmMVZqSxQ79noclR9oKghl ASjom06FGefeSXfdcejPJpp4xWgaaDsTOhKraNL9DuE3gV8ky7sD5cM5RW9uXkB12T sqKuRisFVy+ylVi/3221BiWxiAlHYGOXvyzjtN1E= Message-ID: In-Reply-To: <87zh1swsch.fsf@gnu.org> References: <87zh1swsch.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "othacehe@gnu.org" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Caliph Nomble , Caliph Nomble via Guix-patches From: Caliph Nomble via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=Lj6UvQaL; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C91339402D4 X-Spam-Score: -2.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: TJw6PnmdFAdp Hi, > This seems reasonable to me. We could also turn "arm32-disk-image" and > "arm64-disk-image" into procedures and pass the root offset as argument > to avoid multiplying image types. Danny, Vagrant, any opinion? I was originally considering doing something like that, but I was unsure ho= w that'd interact with --image-type (unless there's another way to specify an image that I don't know of)? Would there still just be multiple image-types= but with procedural disk-images? > Were you able to actually use the generated image on a pinebook-pro? I > added support for this machine without being able to test it. I just tried to use it on one, but I was unable to get it to boot. I'm not = sure why, exactly, as I didn't have a chance to open it up to enable serial. Cou= ld just be the kernel, seeing as wip-pinebook-pro has its own patched linux-li= bre (which I was unable to get working with an inferior on the main branch, but I don't really know how to use them anyway). I did, however, test these changes on a rockpro64 (both pinebook-pro and rockpro64 use the rk3399 SoC), and it did fix fs corruption preventing prop= er boot. Thanks!