[bug#56377] [PATCH] gnu: pipe-viewer: Add dependency.

[bug#56377] [PATCH] gnu: pipe-viewer: Add dependency.

[Sughosha via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 91 bytes --]

Without mpv this application gives the following error:
sh: line 1: mpv: command not found.

[-- Attachment #1.2: Type: text/html, Size: 267 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-pipe-viewer-Add-dependency.patch --]
[-- Type: text/x-patch; name=0001-gnu-pipe-viewer-Add-dependency.patch, Size: 864 bytes --]

From 0b0e66ba091ed2b4871f855e6ef271cda276aaf0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Mon, 4 Jul 2022 04:01:12 +0200
Subject: [PATCH] gnu: pipe-viewer: Add dependency.

* gnu/packages/video.scm (pipe-viewer): Add dependency.

  This application calls mpv to play audios or videos, so mpv as dependency is required.
---
 gnu/packages/video.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 40c31cdaec..07f9e94d34 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1183,7 +1183,8 @@ (define-public pipe-viewer
            wget
            xdg-utils
            youtube-dl
-           yt-dlp))
+           yt-dlp
+           mpv))
     (propagated-inputs
      (list dconf))
     (home-page "https://github.com/trizen/pipe-viewer")
-- 
2.36.1

[bug#56377] [PATCH] gnu: pipe-viewer: Add dependency.

[Sughosha via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 64 bytes --]

Sorry for the ignorance, mpv has to be propagated-input to work.

[-- Attachment #1.2: Type: text/html, Size: 215 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-pipe-viewer-Add-dependency.patch --]
[-- Type: text/x-patch; name=0001-gnu-pipe-viewer-Add-dependency.patch, Size: 927 bytes --]

From 0258642badcb5efa9426b8d03ca1226dd7a5d8b1 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Mon, 4 Jul 2022 04:15:59 +0200
Subject: [PATCH] gnu: pipe-viewer: Add dependency.

* gnu/packages/video.scm (pipe-viewer): Add dependency.

This application calls mpv to play audios or videos, so mpv as dependency is required.
---
 gnu/packages/video.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 40c31cdaec..eee1f63d4a 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1185,7 +1185,7 @@ (define-public pipe-viewer
            youtube-dl
            yt-dlp))
     (propagated-inputs
-     (list dconf))
+     (list dconf mpv))
     (home-page "https://github.com/trizen/pipe-viewer")
     (synopsis "CLI+GUI YouTube Client")
     (description "Pipe-Viewer is a lightweight application for searching and
-- 
2.36.1

[bug#56377] [PATCH] gnu: pipe-viewer: Add dependency.

[Liliana Marie Prikler]

Hi

Am Montag, dem 04.07.2022 um 02:21 +0000 schrieb Sughosha:
> Sorry for the ignorance, mpv has to be propagated-input to work.
Rather than propagating mpv, could you patch the place in which it is
invoked?  It doesn't matter if mpv is used as a "fallback" or whatever,
if it calls mpv we might as well make sure it finds mpv.

Cheers

[bug#56377] (No Subject)

[Sughosha via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Sorry, again, as using the app I understood that mpv is not hardcoded, in the settings I can use any video player. So it doesn't make sense to add mpv as a dependency. I would request to ignore this issue and close it.

[-- Attachment #2: Type: text/html, Size: 298 bytes --]

[bug#56377] (No Subject)

[Maxime Devos]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 677 bytes --]

On 04-07-2022 04:33, Sughosha via Guix-patches via wrote:

> Sorry, again, as using the app I understood that mpv is not hardcoded, 
> in the settings I can use any video player. So it doesn't make sense 
> to add mpv as a dependency. I would request to ignore this issue and 
> close it.

Assuming that mpv isn't overly large, I think it would be nice if 
pipe-viewer can always find its default player -- the user can still 
override what player to use when desired.

Looking at "guix size mpv pipe-viewer" and "guix size pipe-viewer", mpv 
adds 20.1 MiB; I don't know if that's worth it (I'm leaning towards 
'not' but I'm undecided).

Greetings,
Maxime.


[-- Attachment #1.1.1.2: Type: text/html, Size: 1257 bytes --]

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]