From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mNtjLVtD81+KaAAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 16:33:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GEE3KVtD8187KAAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 16:33:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30E109403CD for ; Mon, 4 Jan 2021 16:33:31 +0000 (UTC) Received: from localhost ([::1]:59572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwSnS-0001wT-3S for larch@yhetil.org; Mon, 04 Jan 2021 11:33:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwSn1-0001lH-AX for guix-patches@gnu.org; Mon, 04 Jan 2021 11:33:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwSn1-0003vY-46 for guix-patches@gnu.org; Mon, 04 Jan 2021 11:33:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwSn1-0002fJ-1C for guix-patches@gnu.org; Mon, 04 Jan 2021 11:33:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45403 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic X-Debbugs-Original-Cc: Tobias Geerinckx-Rice , "45403@debbugs.gnu.org" <45403@debbugs.gnu.org>, Tobias Geerinckx-Rice via Guix-patches via Received: via spool by 45403-submit@debbugs.gnu.org id=B45403.160977794910186 (code B ref 45403); Mon, 04 Jan 2021 16:33:02 +0000 Received: (at 45403) by debbugs.gnu.org; 4 Jan 2021 16:32:29 +0000 Received: from localhost ([127.0.0.1]:60049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSmT-0002eD-Di for submit@debbugs.gnu.org; Mon, 04 Jan 2021 11:32:29 -0500 Received: from mail-40135.protonmail.ch ([185.70.40.135]:24218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwSmR-0002ds-Fq for 45403@debbugs.gnu.org; Mon, 04 Jan 2021 11:32:28 -0500 Date: Mon, 04 Jan 2021 16:32:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609777941; bh=xzxxAnyky9Dp1doIdZ8+0tdAtCnzPF74TB8Ah9vdQik=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=VGz4Enh/ui6B4UOyGANl0a+Xxh6h8mjuT8xQQIJEgyrNHmRshwDTELRV0u29dvvGe Smff1rGN6eKUWq6mtUejhZviR2yYaoP8W1wGhcvj30gyVGB9Zdv29q+DDCnzmv3sNr Zu6OwjXYoxXDfpr/d5H7c9ihXwwBRVHo1qsrvbSc= Message-ID: In-Reply-To: References: <87tusaa5mf.fsf@nckx> <20210104145818.0fcd9a0d@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45403@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: raid5atemyhomework , raid5atemyhomework via Guix-patches From: raid5atemyhomework via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=protonmail.com header.s=protonmail header.b=VGz4Enh/; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 30E109403CD X-Spam-Score: -2.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: EqRoR5lwq78I > Here's another alternative: > > - Remove the separate "module" output and put the `.ko` file in the "ou= t" output. > - Create a separate `zfs-guix-tools` which provides `zpool`, `zfs`, `ze= d`, `arc_summary`, `arcstat`, `dbufstat`, `raidz_test`, `zgenhostid`, `zvol= _wait`, `fsck.zfs`, `mount.zfs`, `zdb`, `zhack`, `zinject`, `zstreamdump`, = `ztest`. > - What the provided binaries do is: > - It looks at `/run/booted-system/kernel/manifest` and looks fo= r a `"zfs"` package. > - It `exec`s into the corresponding file in the `/gnu/store` fo= r that package. > > This way, we can have a separate package for ZFS userspace to= ols, which just calls the corresponding tools in the actual ZFS that gets i= nstalled. > It's somewhat magical, though. > Unfortunately, this confounds `bash-completion`. We want the bash-completi= on from the actual compiled ZFS, not the shim `zfs-guix-tools`. We could t= ry digging for it too in the `kernel/manifest`, but that just adds more com= plexity and maintenance headaches. It's also an extra layer of complexity and maintenance burden to create thi= s shim wrapper that digs through your kernel manifest to look for the userl= and tools you need to manage ZFS in the same package that contains the actu= al ZFS kernel module. I think it's better to just expose a `make-zfs-packa= ge` that overrides the `#:linux` and creates a new package that you can ins= tall in `(packages ...)` **and** in `(kernel-loadable-modules ...)`. See https://issues.guix.gnu.org/45643 for my current latest patchset. Thanks raid5atemyhomework