From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oB6CHqWSbWH+hAEAgWs5BA (envelope-from ) for ; Mon, 18 Oct 2021 17:28:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iEsrGqWSbWF7YAAA1q6Kng (envelope-from ) for ; Mon, 18 Oct 2021 15:28:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CF0B39148 for ; Mon, 18 Oct 2021 17:28:37 +0200 (CEST) Received: from localhost ([::1]:60136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcUZ2-0002Vk-6f for larch@yhetil.org; Mon, 18 Oct 2021 11:28:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcUYW-0002T1-7C for guix-patches@gnu.org; Mon, 18 Oct 2021 11:28:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcUYU-0006jx-J6 for guix-patches@gnu.org; Mon, 18 Oct 2021 11:28:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcUYU-0006AJ-EB for guix-patches@gnu.org; Mon, 18 Oct 2021 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH] guix: git-authenticate: Also authenticate the channel intro commit. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Oct 2021 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.163457084023640 (code B ref 50814); Mon, 18 Oct 2021 15:28:02 +0000 Received: (at 50814) by debbugs.gnu.org; 18 Oct 2021 15:27:20 +0000 Received: from localhost ([127.0.0.1]:48291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcUXo-00069E-DU for submit@debbugs.gnu.org; Mon, 18 Oct 2021 11:27:20 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:11072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcUXi-00068v-JG for 50814@debbugs.gnu.org; Mon, 18 Oct 2021 11:27:19 -0400 Date: Mon, 18 Oct 2021 15:27:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1634570827; bh=C43fa0MHvmfpRFh1Q1gqHfZXs2vdWvw0WVJmQiCNk4U=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=JQ59H86Z4HqwKm2nzqYfp87UJ8HTAdN7G7oF1wg6RY5O4iwiHszzncpownsH3ywuL QPhoP/yVAkd55xNS1NYAtw+zk+lSE+zUsqVaGmYgBbzvr+mYvJ8Qyg9x2tCAgP4QUZ 5HMAbhuVn3G66NwRAQJQ8iTLGxf2OgOiGuyx0knxDvRWaswXC0yIsHTN/jYUDdWpsV Sbu1blYCHuDnWGtP04Z3SB30p19G1P1wh9ku6P4jxgaMyv1HpQMbEPGFBanE1nOKkd FCrGksVjq7hH7Ny0RO1GM1WrScSwhJ7loct4cFaaRhpYI37UNrn7yXdhnD+tXN3FQw NfCS2EWvxVY7g== From: Attila Lendvai Message-ID: In-Reply-To: <878ryqbsvk.fsf@gnu.org> References: <20210926101928.3877-1-attila@lendvai.name> <878rz2xq23.fsf@gnu.org> <878ryqbsvk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634570917; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=C43fa0MHvmfpRFh1Q1gqHfZXs2vdWvw0WVJmQiCNk4U=; b=Rd1uVMyLB0G53JRG9vI/vIiZba2WsqJ5STI5CQZBdFn8Gana1cyAbPljUFDqe/76hmC7yp qVyEBXoYEsCaXIjOnjVour3d7+QcvZob3BqoYlAjp+ssk6dd0BfL6GixpOODDEwspvZtFM 8zTqUgd2jUPxPz9alYbFw3985hPArdfe0o7zgcb6eFCUIXGE0pqivD9qCrKwEHlzvyeX62 pRts/OBEwtzdBtPBIESVSffCr//+ykoFBFatGl6M6YQrB00ncEwXfQQSTv+CcWitKd0PFD XL45ttkbVPYZha6kYMSx2M/0m7+b+T52MjdvjTKXRQ1ToR0KSdEZOnCTraQNrw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634570917; a=rsa-sha256; cv=none; b=BDF6Vo5m2bR5B1i/wEj6eaJ0sltz8ggt2kD2Aom3lN7hw1Zlnpd+ew1g4d5Jsz2TGj1zJ9 SxJJBHq62B6+5peSiw7io4gHX+8K7aQKT30MjgWR9J6oOST5Pup5hCwWoQNvkJYKWISRJe ie2UPJMthMARZ7oe01FDZuyJqkyB7Se0k64texfUziQlarXxyjPgDtzq4RqjcjevmvqQAM 3Lu6FL+BUH70z+cKTIg+N19a9dmKxgnmolokxE9x6mzZ7oKcruS9xpQQekAWp9zMGq04V+ SuQvLuB/j8EwCaUSnoUWLuZZBQPqW2l9/b6/7PKDuesTCjZ8uL7C06vySS5vdw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=JQ59H86Z; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=JQ59H86Z; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1CF0B39148 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: Hhu8qAMXnwTq hi Ludo, > > i ran the test without my fix, and indeed it fails at two points: > > Sorry, which test is failing? Is that part of the patches you sent? > > I need more context. :-) i have sent 5 patches. three of them are prefixed with 'test:', and two of those are test idempotent test infrastructure changes. the third of them adds a new test that tests git-authenticate. this is the test that i'm talking about. if you apply only these 3 test related commits, and run the new test on the unpatched codebase, then you'll see the two failures that i'm talking about in my previous mail. search the test log for 'FAILURE' (the test runs fully, but fails in case any of the tests fail). one of the two failures is a more serious issue because a channel intro commit is accepted while it shouldn't be. > > > Alright. Please next time open one issue per topic: that=E2=80=99s a = good > > > way to maximize the chances that review happens in a timely fashion. > > > > > > :-) > > > > can i mark dependencies between issues/patchsets? > > because all that i could do here is split this into two sets of > > commits (because of the dependencies between the commits): > > > > 1. the 3 test commits, and > > 2. the 2 guix commits. > > > > i thought that separating the test that is exhibiting the bug, from > > the fix that fixes it, would only hinder the process. > > Yes, in general it=E2=80=99s best to have the test and the fix in the sam= e > commit. i cut the fix and the test in separate commits (but sent them in the same patchset/issue), so that it's possible to partially apply only the test commits, and study its behavior on the current codebase. > However, at this point, I=E2=80=99m not sure which =E2=80=9Cbug=E2=80= =9D we=E2=80=99re talking about. > > What you described in your initial message is not a bug in my view: > > https://issues.guix.gnu.org/50814#28 the bug is described, formally, by the test that i have added (unless the test itself is wrong, that is). IIRC, i started putting together this new test to expose the bugs that i have suspected while reviewing the implementation of git-authenticate, and then to support my effort to fix them afterwards. i think the best next-action is for someone qualified to take a look at the test that i have added, and see if any of the assumptions encoded in it is wrong. i think i understand this part of the codebase pretty well now, but i may have erred. if the test seems to be valid, then proceed to review the rest of the commits. > I=E2=80=99m not saying that we should not change anything, but rather tha= t it=E2=80=99s > not like a simple usability/UX issue. > > I hope this makes sense! yes, it does! actually, i welcome the reluctance to haphazardly apply patches to this part of the codebase. i was kinda expecting this, and that's why i have prepared the commits so that the test can be applied and tried separately. hope this clarifies the situation, -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CEverything can be taken from a man but one thing: the last of the = human freedoms=E2=80=94to choose one=E2=80=99s attitude in any given set of= circumstances, to choose one=E2=80=99s own way.=E2=80=9D =09=E2=80=94 Viktor E. Frankl (1905=E2=80=931997), 'Man's Search for Meanin= g' (1946)