From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id pouoH0C102CLNgEAgWs5BA (envelope-from ) for ; Thu, 24 Jun 2021 00:27:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SDbQGkC102DERgAA1q6Kng (envelope-from ) for ; Wed, 23 Jun 2021 22:27:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF0271EDA9 for ; Thu, 24 Jun 2021 00:27:11 +0200 (CEST) Received: from localhost ([::1]:44552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwBKw-0004FQ-QQ for larch@yhetil.org; Wed, 23 Jun 2021 18:27:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwB4M-0002kr-H0 for guix-patches@gnu.org; Wed, 23 Jun 2021 18:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwB4M-0004ga-4f for guix-patches@gnu.org; Wed, 23 Jun 2021 18:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwB4L-0007JV-VM for guix-patches@gnu.org; Wed, 23 Jun 2021 18:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49199] [PATCH core-updates] add package-db to runhaskell (haskell-build-system) Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Jun 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49199@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.162448615828051 (code B ref -1); Wed, 23 Jun 2021 22:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2021 22:09:18 +0000 Received: from localhost ([127.0.0.1]:42003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwB3e-0007IN-HP for submit@debbugs.gnu.org; Wed, 23 Jun 2021 18:09:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:59462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwB3c-0007IF-Dc for submit@debbugs.gnu.org; Wed, 23 Jun 2021 18:09:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwB3b-0002iO-VE for guix-patches@gnu.org; Wed, 23 Jun 2021 18:09:16 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:52910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwB3Z-00048k-FW for guix-patches@gnu.org; Wed, 23 Jun 2021 18:09:15 -0400 Date: Wed, 23 Jun 2021 22:09:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1624486147; bh=YN4vnqp+2uYJmlPSI+k6y9Ku0EVdM8xPo46tVwlxMY4=; h=Date:To:From:Reply-To:Subject:From; b=rbfohS1JkkC1JaWM/vq1nLr37mbYSUddKmBiVU1R5F4HkWfu6kmLPvHzEOvnpaxl7 a8hPRdRojsmN7knSSiYvK8e2vwX+F+rSadVcnqB1V5DTDxBqAvuZDeb247tbC5Rwar bp9WtIhU07ooJNdoFzpTJu4ts2gNlJ5Trq23O4x8= Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_PRX7x5f4c4W9lUlM1wKnA74r1u62yuIRRIEgg64" Received-SPF: pass client-ip=51.77.79.158; envelope-from=john.kehayias@protonmail.com; helo=mail-0201.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Wed, 23 Jun 2021 18:26:58 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624487231; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=YN4vnqp+2uYJmlPSI+k6y9Ku0EVdM8xPo46tVwlxMY4=; b=XCVvoo+hA7BD+frfmRAZytSP5yvFQ312JEMbKJsgYvZ32lKaP+7awWgjk9Im/5lV/74Ucr xgc2nyB3SyNuLPxibaJwv4wUbPM3USmZEt5Prnx8DV20s0xixdZpPWjMZy4etdOzoCo9ao 2HiQHGWG8UKXK3FRQGlAYr6uTHJes2tE3OKZAr1khqEIn9ZXQzDlM1T0/uE5nSoA7WmD4s 62RhepCjYRCo0i7RiIRlTi/QtyZ5b23DwMSzDi1+PBWeDb3Yq+KjqMldFTtAoA0kyVTvWc q1yR5wePYh0p2eXAokQVvibX1Ab6KzUORoPE3nGyAeZnh197vTf6dOKIFiRDCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624487231; a=rsa-sha256; cv=none; b=La0eTRxoe67KEvLlICnNaFRxpD0UJtEb/YHm7kR1fst0pf+3fhE8AtOKu3Do9OkAhdbugZ 5i7PQJg9uWh0LQACfZsu2nuNeZAcxlNM2KvTcoJA6/OfMY3DeSZxJOXcFy74dq5IPMSkU1 Rn8xmih+MVvJijXAG1/pVinreORzmckmGoVf+QsRiDdHHzh7x6GdOlnkuZJwDBCoYGiqUv o97511SLEPpas4RYjIgghNNLyAivDyckwyPwcv41xAEkDVpYCOxqT0Rpn9+iVpthcRg4t+ 0CmJZtOSs7hIoBDLUaRefoxxBvmtEOOcnBfzYoCaLuysNJdrs6rIkVMwywXrRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=rbfohS1J; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=rbfohS1J; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BF0271EDA9 X-Spam-Score: -1.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: cCKlkNHvIBtC This is a multi-part message in MIME format. --b1_PRX7x5f4c4W9lUlM1wKnA74r1u62yuIRRIEgg64 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, This is a patch to fix issue #48944 as well as more broadly an issue of Has= kell packages that need modules at the configure step. Currently the packag= e database is not passed to runhaskell directly, which means runhaskell Set= up.hs configure does not have outside modules available. This blocks packag= es that need things like cabal-doctest or gtk2hs-buildtools like ghc-cairo = (which has a custom build process in the package currently, for this reason= ). Comments in ghc-cairo and for other packages with this need, suggest the= change made in this patch. The simplest change I saw was to make the package database passed to runhas= kell on any command; not sure if this would be better for just configure. I= t may be possible to do this just passing the actual needed packages with -= package-id, as suggested in https://github.com/tweag/rules_haskell/issues/1= 314 However, I have not tried that and seemed more complicated than needed.= Also, I did not modify the message printed as it already has the package-d= b in params, but perhaps better to be clear the exact command being run? I have built many Haskell packages with this change and it works well for m= e, fixing the reported issue and packages I'm building not yet in guix. Giv= en this changes the build command for all Haskell packages, would be happy = for other tests to be run. John --b1_PRX7x5f4c4W9lUlM1wKnA74r1u62yuIRRIEgg64 Content-Type: text/x-patch; name=runhaskell-add-pkgdb.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=runhaskell-add-pkgdb.patch ZGlmZiAtLWdpdCBhL2d1aXgvYnVpbGQvaGFza2VsbC1idWlsZC1zeXN0ZW0uc2NtIGIvZ3VpeC9i dWlsZC9oYXNrZWxsLWJ1aWxkLXN5c3RlbS5zY20KaW5kZXggMjgyNTNjZTJmMC4uYmUyMGYxM2Ux MCAxMDA2NDQKLS0tIGEvZ3VpeC9idWlsZC9oYXNrZWxsLWJ1aWxkLXN5c3RlbS5zY20KKysrIGIv Z3VpeC9idWlsZC9oYXNrZWxsLWJ1aWxkLXN5c3RlbS5zY20KQEAgLTYzLDEzICs2MywxNCBAQAog ICAgICAgICAgICAgICAgICAgICAgKChmaWxlLWV4aXN0cz8gIlNldHVwLmxocyIpCiAgICAgICAg ICAgICAgICAgICAgICAgIlNldHVwLmxocyIpCiAgICAgICAgICAgICAgICAgICAgICAoZWxzZQot ICAgICAgICAgICAgICAgICAgICAgICNmKSkpKQorICAgICAgICAgICAgICAgICAgICAgICNmKSkp CisgICAgICAgIChwa2dkYiAoc3RyaW5nLWFwcGVuZCAiLXBhY2thZ2UtZGI9IiAldG1wLWRiLWRp cikpKQogICAgIChpZiBzZXR1cC1maWxlCiAgICAgICAgIChiZWdpbgogICAgICAgICAgIChmb3Jt YXQgI3QgInJ1bm5pbmcgXCJydW5oYXNrZWxsIFNldHVwLmhzXCIgd2l0aCBjb21tYW5kIH5zIFwK IGFuZCBwYXJhbWV0ZXJzIH5zfiUiCiAgICAgICAgICAgICAgICAgICBjb21tYW5kIHBhcmFtcykK LSAgICAgICAgICAoYXBwbHkgaW52b2tlICJydW5oYXNrZWxsIiBzZXR1cC1maWxlIGNvbW1hbmQg cGFyYW1zKSkKKyAgICAgICAgICAoYXBwbHkgaW52b2tlICJydW5oYXNrZWxsIiBwa2dkYiBzZXR1 cC1maWxlIGNvbW1hbmQgcGFyYW1zKSkKICAgICAgICAgKGVycm9yICJubyBTZXR1cC5ocyBub3Ig U2V0dXAubGhzIGZvdW5kIikpKSkKIAogKGRlZmluZSogKGNvbmZpZ3VyZSAjOmtleSBvdXRwdXRz IGlucHV0cyB0ZXN0cz8gKGNvbmZpZ3VyZS1mbGFncyAnKCkpCi0tIAoyLjMyLjAKCg== --b1_PRX7x5f4c4W9lUlM1wKnA74r1u62yuIRRIEgg64--