From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GMRtC0rZVGHIgwEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 23:23:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EPsGB0rZVGFkGAAAB5/wlQ (envelope-from ) for ; Wed, 29 Sep 2021 21:23:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CAF8612CBF for ; Wed, 29 Sep 2021 23:23:21 +0200 (CEST) Received: from localhost ([::1]:50452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVh2u-00064q-Tr for larch@yhetil.org; Wed, 29 Sep 2021 17:23:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVh2c-00064Z-QC for guix-patches@gnu.org; Wed, 29 Sep 2021 17:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVh2c-00041O-JH for guix-patches@gnu.org; Wed, 29 Sep 2021 17:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVh2c-0007Zo-Aw; Wed, 29 Sep 2021 17:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH 4/5] guix: Prepare the UI for continuable &warning exceptions. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 21:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.163295056629063 (code B ref 50814); Wed, 29 Sep 2021 21:23:02 +0000 Received: (at 50814) by debbugs.gnu.org; 29 Sep 2021 21:22:46 +0000 Received: from localhost ([127.0.0.1]:50476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVh2M-0007Yh-49 for submit@debbugs.gnu.org; Wed, 29 Sep 2021 17:22:46 -0400 Received: from mail-4317.protonmail.ch ([185.70.43.17]:59462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVh2H-0007YO-IP for 50814@debbugs.gnu.org; Wed, 29 Sep 2021 17:22:45 -0400 Date: Wed, 29 Sep 2021 21:22:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1632950553; bh=xIZ983uEEPBKPYoKYhZ8gUvI3b915/T7DvQfvhGKLwE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=CKi+DSP0Y/GPgI/uosTU/J8G4fDVhCqOsYBGNjq8mM9jTxWQUzD/qErx1J0a8Kffr GqfraV6kC53L+uHfk6yvpRnfS+DnQ4VHy1n5lRGFqi4kpUBcfdeMj90rfMJhhD9i8A l+r3GrKKV4xRORqTrrD26qG5CkDHeaWAULAZL8PjheTg6pMcIRkVxqOTDxMSmHFh9O 8wW7YPzBe9JTK9sw24K6kf/k2xgG44XNYbDIzDmRR3K1zb+nGzXIcLBpL553UjA+Ba ql59uxWH57V2q5Axranl1jKS/qBvK7CqFn7tkX/aAEJh+cj8GxC7t2KgZnEDat5WtV BuJZX15hpCQYQ== From: Attila Lendvai Message-ID: In-Reply-To: <929da16ca45605a5bed718dea5d76db7176cf985.camel@telenet.be> References: <20210928162406.27205-1-attila@lendvai.name> <20210928162406.27205-4-attila@lendvai.name> <9c093db2d9019ef2fe9b27979a3b51848f179a3b.camel@telenet.be> <929da16ca45605a5bed718dea5d76db7176cf985.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632950601; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xIZ983uEEPBKPYoKYhZ8gUvI3b915/T7DvQfvhGKLwE=; b=ibFTNDTZ3OIAGI1jlstbNHtB6gTfBg/OdIcYzHmofGs8zQzCs+ta6rEbq0yk4AiclJb11s B96fu4SLDxnCsBimXJs5a3jnjIDov1dEmJ/lOzhkl0ioLocIWMo3QXV9hOl9ZPlMjTRX2z hLsnvSrOHi4wN7zAMhKQdFC6qgi3p2z6HibM/ygsQHl0222j/ceAvzmFfTyoTUZqcIy8X2 kRJDMFxntlYhMYYCKkZlp8h09nEVbUgJ+hlFHrdGsKeCQynCQ6VC/6+GkeZp5mdqRKvRt+ 11M1vDi+Y0zltB78oC+ezqCAVJw0v+N0YGRroPBKtaOPVDlDWQ8Wj8ntKOa6oQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632950601; a=rsa-sha256; cv=none; b=j/kZLFWNnwLt71wmAYEKBoOPsCEfBb3ujHHCAcOGPs8vOUWglrNHSkOTDO1lonaADWjlH7 jp1Dc3U+emma8stKl9rARp3q2GL8XBqg+WW0EWyP1F07FCS1858OMpmpZjUaJJyTvzfi3v ouH8/Pd79nzXbPTBFbBO02vxTe2KeymM9sLHj2CDxvEjLkvcEjTrfA5IW8wFQK8zl2IgeX MP+qdSfmdYa7Kp1jkptxhBXRCbj3sfUufkT2NHDPsIMC5m64LcUypoudJN5qcR5Pa6posZ ds70SZMOP54zSN2vqWfT3omEuvaEIw6SmOpMWAJuZUO4rqMJZ50CraFSVR9NkA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=CKi+DSP0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=CKi+DSP0; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CAF8612CBF X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: DCCyQ9s6eKUS > About 1): which 'wind part' of dynamic-wind are you referring to? > > The in-guard or the out-guard? > > If the out-guard is empty, then the reference to the old connection will > be overwritten when the fiber is paused and resumed, so the old connectio= n > will eventually be GC'ed, thus the daemon forgets some GC roots, leading > to a rare GC bug. > > If the in-guard is empty, then the after pausing the fiber and resuming i= t, > the connection will be closed while the fiber might still need it. ok, so this is a no-go. thanks for the clarification! > Conventionally, to emit warnings, the procedure 'warning' from > (guix diagnostics) is used. See e.g. (guix ci), (guix deprecation), (guix= gexp), > (guix import ...), various modules under (guix scripts ...), (guix upstre= am) ... > > Is there any reason not to use this pre-existing procedure? in a more advanced UI it might be a different story, but in the current setup the only reason is to be able to assert for the warning in the tests. is that worth it? shall i just user WARNING and forget about the test? - attila PGP:=C2=A05D5F 45C7 DFCD 0A39