From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yH2WGTu8qWL2XAAAbAwnHQ (envelope-from ) for ; Wed, 15 Jun 2022 13:02:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sAWBGTu8qWKlCAEA9RJhRA (envelope-from ) for ; Wed, 15 Jun 2022 13:02:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1ED58464F2 for ; Wed, 15 Jun 2022 13:02:19 +0200 (CEST) Received: from localhost ([::1]:42202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Qmw-0005XZ-AH for larch@yhetil.org; Wed, 15 Jun 2022 07:02:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1Qf2-0005I9-GA for guix-patches@gnu.org; Wed, 15 Jun 2022 06:54:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42731) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1Qew-00026w-N9 for guix-patches@gnu.org; Wed, 15 Jun 2022 06:54:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1Qew-0003Hg-Gp for guix-patches@gnu.org; Wed, 15 Jun 2022 06:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55979] [PATCH] gnu: Add java-commons-text Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 15 Jun 2022 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" , 55979@debbugs.gnu.org Received: via spool by 55979-submit@debbugs.gnu.org id=B55979.165529042212590 (code B ref 55979); Wed, 15 Jun 2022 10:54:02 +0000 Received: (at 55979) by debbugs.gnu.org; 15 Jun 2022 10:53:42 +0000 Received: from localhost ([127.0.0.1]:36625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Qec-0003Gv-8a for submit@debbugs.gnu.org; Wed, 15 Jun 2022 06:53:42 -0400 Received: from lepiller.eu ([89.234.186.109]:40448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1QeV-0003Gf-LK for 55979@debbugs.gnu.org; Wed, 15 Jun 2022 06:53:41 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 15a59f1f; Wed, 15 Jun 2022 10:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=uLW7XtpZ/HyJ LEa9xGv0EPUsV1NDHQfmih7wo5ejcCA=; b=AF1zpy6g2OnGwCWEz9Tw0+A0+vX1 CNYWabAP7R7x50bh7nmA8ob5Tp8J2DidWAVwOirLytr4fYXUEgswe4p7PSZZ9kmv GpyTzi2EP0ga07Y1letILAsSd8mku2N2yPgsdqlIRGSAUYpcq6NhkCeM1CdaUiNX x+sxw0BkzmYR8sbAbncnuuC6FcFRqy17mZrFw750LDKoniqVMp+geKmQZVEL70Wj iKF2wSfnEkQCdju7tsX/RT0CnqfjFzKkkJaUrpNYmqqBKjHoY9DWn2gnJlF5jj7S XkCQ1Lqnp21dybT3tWPAtKfi6TiS/QOpUccS1kbo62ZPbJLvfJduKfLKRw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id d5dba421 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 15 Jun 2022 10:53:32 +0000 (UTC) Date: Wed, 15 Jun 2022 12:53:19 +0200 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <87edzrw0e7.fsf@gmail.com> References: <87edzrw0e7.fsf@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----AJKYAXN3CHRFFF19FDUD9HGAX2N6NC Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655290939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uLW7XtpZ/HyJLEa9xGv0EPUsV1NDHQfmih7wo5ejcCA=; b=ge/q0CUC3pX8jdjNQd9Yh3cAOBXkZ/qoFCedPUffi8x5JKXGulVGQ4Td/DqGGEjICwlob5 krju2nekUrHjPUmJ82OEM9iZVXPfsh7Kl33QE4LVVIV6h58yUsKuLYoPoHfzvGnJxaF6pE Pjn3UJNwP5LacwfVJ0rAbmSCHfisAq9D++kiyofZYrEZBpfpC0+Wg+Oh+4hknt0m6NYu1L S4gIEkcF5oUwzkm37yZH9+j9SWw3d7x/+ywJPm47GxBJtv49IRTCQ0dMfmpt7vlHCxX7qX VMTRoBHGWQsnJUJhQpSqvOco2XIy6n5Ekhad1Qg4qGxunHiHVs2ATAz+ZUXljA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655290939; a=rsa-sha256; cv=none; b=jYUELu2VpvnhI+R8aHeVVWdNFxKW3sZUuOOW7Y294S/mlZfNYOUls1xqH56aGavfITeTFX 99eHZz0C0Yi/JifZpCkIvvxKrveAvL92TBqrRGlspMPCGTkX02f0hr190ogjqv8XFFdM6R q4i8DuBQkZw1KEwfMsRvaTphI1VVmBR5dwiGMjn09NMrLYgpRqRnRmA6EmMKR6ZiyOp3Qn cE0vNxSIZcePIZ5ajjeIrkALJk6Z4w7D/R8YrwS/JSmdo12N28B/j37+Wo3707KosCck0+ EP5Mlj5fmLYqHVirM10V9rbiiqgJvY4q03Wv6vv5SHRsl1E21j6Xf+Mam3sZyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=AF1zpy6g; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=AF1zpy6g; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1ED58464F2 X-Spam-Score: 5.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: ihS6ZTGUL0w2 ------AJKYAXN3CHRFFF19FDUD9HGAX2N6NC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! The patch looks good to me=2E I would just change some things for style: n= o need for a new line between a keyword and it value in the arguments list,= and use a quote or semi-quote instead of list=2E I think the comments are = a bit too much, but I'm not sure what's the riggt amount=2E If it were me, = I would only add a comment to #:tests? saying it depends on junit5 which is= not packaged=2E Maybe more important, you say it's a dependency for maven-plugin-plugin=2E= In that case, we need to install it with its pom file, to lib/m2=2E This i= s done by install-from-pom=2E Maybe at this point we should mandate using it for java packages? We can a= lways go back and fix them when needed, but it's much less work to do the r= ight thing from the start=2E Just thinking out load, maybe we could add a #:pom argument to the ant-bui= ld-system, so we don't have to modify the phases all the time? On June 14, 2022 8:44:16 PM GMT+02:00, "Artyom V=2E Poptsov" wrote: >Hello, > >here's the patch that adds 'java-commons-text'=2E [1] > >Unfortunately I had to disable tests as they require JUnit5 (which is >missing from GNU Guix at the moment=2E) > >Also many thanks to Julien Lepiller who helped me to update >'java-commons-lang3' to 3=2E12=2E0, which in turn was required to package >'java-commons-text'=2E > >- Artyom > >References: >1=2E https://commons=2Eapache=2Eorg/proper/commons-text/ > ------AJKYAXN3CHRFFF19FDUD9HGAX2N6NC Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi!

The patch looks good to me=2E I would j= ust change some things for style: no need for a new line between a keyword = and it value in the arguments list, and use a quote or semi-quote instead o= f list=2E I think the comments are a bit too much, but I'm not sure what's = the riggt amount=2E If it were me, I would only add a comment to #:tests? s= aying it depends on junit5 which is not packaged=2E

Maybe more impor= tant, you say it's a dependency for maven-plugin-plugin=2E In that case, we= need to install it with its pom file, to lib/m2=2E This is done by install= -from-pom=2E

Maybe at this point we should mandate using it for java= packages? We can always go back and fix them when needed, but it's much le= ss work to do the right thing from the start=2E

Just thinking out lo= ad, maybe we could add a #:pom argument to the ant-build-system, so we don'= t have to modify the phases all the time?


On June 14, 2022 8:44:16 PM GMT+02:00, "Artyom V=2E Poptsov" <popts= ov=2Eartyom@gmail=2Ecom> wrote:
Hello,

here's the patch that add= s 'java-commons-text'=2E [1]

Unfortunately I had to disable tests as= they require JUnit5 (which is
missing from GNU Guix at the moment=2E)
Also many thanks to Julien Lepiller who helped me to update
'java-= commons-lang3' to 3=2E12=2E0, which in turn was required to package
'jav= a-commons-text'=2E

- Artyom

References:
1=2E https://commons=2Eapache= =2Eorg/proper/commons-text/

------AJKYAXN3CHRFFF19FDUD9HGAX2N6NC--