From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:40795)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hsHCJ-00066Z-QM
 for guix-patches@gnu.org; Mon, 29 Jul 2019 21:45:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hsHCI-0005fc-R5
 for guix-patches@gnu.org; Mon, 29 Jul 2019 21:45:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40553)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hsHCI-0005ek-NM
 for guix-patches@gnu.org; Mon, 29 Jul 2019 21:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hsHCI-000305-Go
 for guix-patches@gnu.org; Mon, 29 Jul 2019 21:45:02 -0400
Subject: [bug#36841] [PATCH] build/cargo-build-system: Patch cargo checksums.
Resent-Message-ID: <handler.36841.B36841.156445108211491@debbugs.gnu.org>
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Ivan Petkov <ivanppetkov@gmail.com>
In-Reply-To: <20190729190422.6834-1-efraim@flashner.co.il>
Date: Mon, 29 Jul 2019 18:44:31 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <FD0B92BC-A390-46AB-9AD4-2A3536BD681D@gmail.com>
References: <20190729190422.6834-1-efraim@flashner.co.il>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36841@debbugs.gnu.org

Hi Efraim,

> On Jul 29, 2019, at 12:04 PM, Efraim Flashner <efraim@flashner.co.il> =
wrote:
>=20
> +;; After patching the 'patch-generated-file-shebangs phase any =
vendored crates
> +;; will have a mismatch on their checksum.
> +(define* (patch-cargo-checksums #:key
> +                                (vendor-dir "guix-vendor")
> +                                #:allow-other-keys)

[snip]

> +    (replace 'install install)
> +    (add-after 'patch-generated-file-shebangs 'patch-cargo-checksums =
patch-cargo-checksums)))

I can=E2=80=99t quite remember the order the phases run in off the top =
of my head. Would it be possible to
make the configure/checksum generation phase run after shebang-patching =
(or ensure the patching
happens first)? It would avoid having to checksum all the files twice =
that way=E2=80=A6

=E2=80=94Ivan=