From: Ivan Petkov <ivanppetkov@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36841@debbugs.gnu.org
Subject: [bug#36841] [PATCH] build/cargo-build-system: Patch cargo checksums.
Date: Mon, 29 Jul 2019 18:44:31 -0700 [thread overview]
Message-ID: <FD0B92BC-A390-46AB-9AD4-2A3536BD681D@gmail.com> (raw)
In-Reply-To: <20190729190422.6834-1-efraim@flashner.co.il>
Hi Efraim,
> On Jul 29, 2019, at 12:04 PM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
> +;; After patching the 'patch-generated-file-shebangs phase any vendored crates
> +;; will have a mismatch on their checksum.
> +(define* (patch-cargo-checksums #:key
> + (vendor-dir "guix-vendor")
> + #:allow-other-keys)
[snip]
> + (replace 'install install)
> + (add-after 'patch-generated-file-shebangs 'patch-cargo-checksums patch-cargo-checksums)))
I can’t quite remember the order the phases run in off the top of my head. Would it be possible to
make the configure/checksum generation phase run after shebang-patching (or ensure the patching
happens first)? It would avoid having to checksum all the files twice that way…
—Ivan
next prev parent reply other threads:[~2019-07-30 1:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 19:04 [bug#36841] [PATCH] build/cargo-build-system: Patch cargo checksums Efraim Flashner
2019-07-30 1:44 ` Ivan Petkov [this message]
2019-07-30 5:59 ` bug#36841: " Efraim Flashner
2019-07-30 8:17 ` [bug#36841] " Efraim Flashner
2019-07-30 10:46 ` [bug#36841] [PATCH v3] " Efraim Flashner
2019-08-01 3:00 ` Ivan Petkov
2019-08-01 11:15 ` Efraim Flashner
2019-08-04 8:57 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD0B92BC-A390-46AB-9AD4-2A3536BD681D@gmail.com \
--to=ivanppetkov@gmail.com \
--cc=36841@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).