From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KFIFK7639WNI0AAAbAwnHQ (envelope-from ) for ; Wed, 22 Feb 2023 07:35:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id Abg5K7639WPvfQEA9RJhRA (envelope-from ) for ; Wed, 22 Feb 2023 07:35:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D729D209D0 for ; Wed, 22 Feb 2023 07:35:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUiin-00044R-DP; Wed, 22 Feb 2023 01:35:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUiiV-00042P-Qe for guix-patches@gnu.org; Wed, 22 Feb 2023 01:35:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUiiV-0003Gh-Fv for guix-patches@gnu.org; Wed, 22 Feb 2023 01:35:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUiiU-0003kX-JL for guix-patches@gnu.org; Wed, 22 Feb 2023 01:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61680] [PATCH] gnu: podman: Add 'docker' alias script as 'docker' output Resent-From: lWP6SrZsSwhCy5tUxadDfg Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Feb 2023 06:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61680 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 61680@debbugs.gnu.org Received: via spool by 61680-submit@debbugs.gnu.org id=B61680.167704766914369 (code B ref 61680); Wed, 22 Feb 2023 06:35:02 +0000 Received: (at 61680) by debbugs.gnu.org; 22 Feb 2023 06:34:29 +0000 Received: from localhost ([127.0.0.1]:57866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUihv-0003jg-Cm for submit@debbugs.gnu.org; Wed, 22 Feb 2023 01:34:29 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:47765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUi3n-0002U0-Ga for 61680@debbugs.gnu.org; Wed, 22 Feb 2023 00:53:01 -0500 Date: Wed, 22 Feb 2023 05:52:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c0x0o.me; s=protonmail; t=1677045172; x=1677304372; bh=wC2N3Gvcl04DSc5PN0f0AmlY16GwpYCJXAYE1b1z+cs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=P253tFBhepfgjiWUEvpDShfq+CgIET5hSVAxfr/XlGGPwlFw75d0FiG2/LgF9CGU8 MgvAU5B6fTgWKf6eiql3iKPfoO1KK7pwce/epM1ZRjTtGeBQMuDE6UXeLx5S0TNme9 U7f3V8UBqAPiM6eW8TUyRGFpHqNtbMxf5Sv9sAx/0b4bTDqLjZIFbs2QcCGEpEPqNB Zct6wBo9T5N55ebKvcZ8gOYtIArQjU56Q3OwM/Sc8tOpb3nzWbd1x6dg3sy7lcwajV Mlkj1ZWD/lUveU5VqZR7DS4l6JS5Y0Tw8ZjKU40tQNK/yKaRZ6WNpkQiOTZii0tyma eUYTKyqRMk3cg== Message-ID: In-Reply-To: References: <20230221143401.42099-1-zongyuan.li@c0x0o.me> Feedback-ID: 67462066:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 22 Feb 2023 01:34:26 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: lWP6SrZsSwhCy5tUxadDfg X-ACL-Warn: , lWP6SrZsSwhCy5tUxadDfg via Guix-patches From: lWP6SrZsSwhCy5tUxadDfg via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677047742; a=rsa-sha256; cv=none; b=DmLUmoPoAfHvGkzn80gf/zlsHqjSjiM++nviSjB0a2ccgzsRpAubhpOL3OX2iwgdN2+id3 ypxoNoeJOgJ8Iv/yxnnrd95/9R+3yixxuCOEo5SVAz4lxOZLsO9bX1M0dQ2KqgUUlXqZqf J1KIT9JqRaupunSMaI9CPrrZ/VYOV7pCS5oSPrTqqqmLBH6B2e/dAQkbKIIwyOuLnpMJMY scXcfQ8EC5a1il+kfl2vK1MGde3wP8FKulev1BZsQHNKuCQG88Zuqy4c/KCsy+zSjk68AN ahbHI+v6KybjT6r8V7nCSrj7zQ4T705jVzMPS80dUv/kfBb64wMYexMQaEwQGw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=c0x0o.me header.s=protonmail header.b=P253tFBh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677047742; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wC2N3Gvcl04DSc5PN0f0AmlY16GwpYCJXAYE1b1z+cs=; b=elajAeSG6lsRR+A6NfR5K1pERatIfuKhS6Sgn0dk6LLSfY+JxnPPMZfQ0nQGih74CLNBGb fFHHTI/drO0FQhguRvnL2lHVXLbetmzpOGQEfb/x09k77moK2LIoLOvKdIB45h5leIjWof RlYcuNHcRjtWA7ZUr12fKPlYoXb7OAbia8DqAnGyS4dBRHiEfxeavSeXs2H4Nu7MnYGlIX 6q09BOUEF7N705HUY2MALY3b0oKflSg8SRcuNEsI9hKCLBVQ4qVyuzj0uKtm3opyBcXT5r CjmVwnsJKbR6bGedW6qQ+stg+vjfzGJF9dF5xuEuGr0SCYmGPbpR8svV413CiA== X-Migadu-Spam-Score: -3.66 X-Spam-Score: -3.66 X-Migadu-Queue-Id: D729D209D0 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=c0x0o.me header.s=protonmail header.b=P253tFBh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: H7etPs52WlSN > On Feb 22, 2023, at 13:19, Liliana Marie Prikler wrote: > > Am Dienstag, dem 21.02.2023 um 14:34 +0000 schrieb Zongyuan Li: >> * gnu/packages/containers.scm: New 'docker' output for podman > That ChangeLog looks somewhat incomplete. > >> Signed-off-by: Zongyuan Li > Signed-off-by is for committers signing off the commits. > >> --- >> gnu/packages/containers.scm | 157 +++++++++++++++++++--------------- >> -- >> 1 file changed, 83 insertions(+), 74 deletions(-) >> >> diff --git a/gnu/packages/containers.scm >> b/gnu/packages/containers.scm >> index 272b67c38d..80c4aaa400 100644 >> --- a/gnu/packages/containers.scm >> +++ b/gnu/packages/containers.scm >> @@ -312,83 +312,92 @@ (define-public podman >> (package >> (name "podman") >> (version "4.3.1") >> - (source >> - (origin >> - (method git-fetch) >> - (uri (git-reference >> - (url "https://github.com/containers/podman") >> - (commit (string-append "v" version)))) >> - (modules '((guix build utils))) >> - ;; FIXME: Btrfs libraries not detected by these scripts. >> - (snippet '(substitute* "Makefile" >> - ((".*hack/btrfs.*") ""))) >> - (sha256 >> - (base32 >> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h")) >> - (file-name (git-file-name name version)))) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/containers/podman") >> + (commit (string-append "v" version)))) >> + (modules '((guix build utils))) >> + ;; FIXME: Btrfs libraries not detected by these >> scripts. >> + (snippet '(substitute* "Makefile" >> + ((".*hack/btrfs.*") >> + ""))) >> + (sha256 >> + (base32 >> + >> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h")) >> + (file-name (git-file-name name version)))) > Don't mix style changes with functional ones. `guix style', while > recommended in the manual, often does more harm than good. > >> + (outputs '("out" "docker")) > Since this is a very non-standard output, perhaps try describing it > with a output-synopsis package property. > > Cheers Thanks for the review. I will take a look :) By the way, should I post a new v2 patch in a new thread, or just continue = with this one?