From: Julien Lepiller <julien@lepiller.eu>
To: Oleg Pykhalov <go.wigust@gmail.com>, 33706@debbugs.gnu.org
Subject: [bug#33706] [PATCH] gnu: php: Update to 7.3.0.
Date: Tue, 11 Dec 2018 21:25:07 +0100 [thread overview]
Message-ID: <F6A7FE02-591D-46CF-9301-BDFBB0DC5367@lepiller.eu> (raw)
In-Reply-To: <20181211164214.26945-1-go.wigust@gmail.com>
Hi,
Thanks for the patch! I haven't tested it yet, but I was wondering why update pcre to pcre2 while not stripping pcrelib anymore. Is thc directory not available anymore?
Le 11 décembre 2018 17:42:14 GMT+01:00, Oleg Pykhalov <go.wigust@gmail.com> a écrit :
>* gnu/packages/php.scm (php)[version]: Update to 7.3.0.
>[arguments]: Delete "sapi/cli/tests/upload_2G.phpt" substitution and
>delete "ext/pcre/tests/bug76909.phpt" file.
>[inputs]: Replace 'pcre' with 'pcre2'.
>---
> gnu/packages/php.scm | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
>diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
>index a28cb31e5..491e08481 100644
>--- a/gnu/packages/php.scm
>+++ b/gnu/packages/php.scm
>@@ -53,7 +53,7 @@
> (define-public php
> (package
> (name "php")
>- (version "7.2.12")
>+ (version "7.3.0")
> (home-page "https://secure.php.net/")
> (source (origin
> (method url-fetch)
>@@ -61,7 +61,7 @@
> name "-" version ".tar.xz"))
> (sha256
> (base32
>-
>"1qbz2j9kzqxxp0mmx02zavvz20ji7izqdnri25g1mrwyhz60974q"))
>+
>"1db0lm84hynilrjj3k1s7skp1y2gl4ip1ihr7662i2xgannmq6bx"))
> (modules '((guix build utils)))
> (snippet
> '(with-directory-excursion "ext"
>@@ -74,7 +74,6 @@
> ;;"fileinfo/libmagic" ; This is a patched version of libmagic.
> '("gd/libgd"
> "mbstring/oniguruma"
>- "pcre/pcrelib"
> "sqlite3/libsqlite"
> "xmlrpc/libxmlrpc"
> "zip/lib"))
>@@ -176,11 +175,6 @@
> (substitute* "ext/standard/tests/streams/bug60602.phpt"
> (("'ls'") (string-append "'" (which "ls") "'")))
>
>- ;; The expected output is slightly different from what is
>given,
>- ;; in a section that's not related to the actual test
>- (substitute* "sapi/cli/tests/upload_2G.phpt"
>- (("Test\\\\n") "Test\n\n"))
>-
> ;; Drop tests that are known to fail.
> (for-each delete-file
> '("ext/posix/tests/posix_getgrgid.phpt" ; Requires /etc/group.
>@@ -291,7 +285,10 @@
> "ext/ldap/tests/ldap_set_option_error.phpt"
>
> ;; Sometimes cannot start the LDAP server.
>- "ext/ldap/tests/bug76248.phpt"))
>+ "ext/ldap/tests/bug76248.phpt"
>+
>+ ;; Bug #76909 preg_match difference between
>7.3 and < 7.3
>+ "ext/pcre/tests/bug76909.phpt"))
>
> ;; Skip tests requiring network access.
> (setenv "SKIP_ONLINE_TESTS" "1")
>@@ -324,7 +321,7 @@
> ("oniguruma" ,oniguruma-5)
> ("openldap" ,openldap)
> ("openssl" ,openssl)
>- ("pcre" ,pcre)
>+ ("pcre" ,pcre2)
> ("postgresql" ,postgresql)
> ("readline" ,readline)
> ("sqlite" ,sqlite)
next prev parent reply other threads:[~2018-12-11 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 16:42 [bug#33706] [PATCH] gnu: php: Update to 7.3.0 Oleg Pykhalov
2018-12-11 20:25 ` Julien Lepiller [this message]
2018-12-12 3:04 ` Oleg Pykhalov
2018-12-13 3:01 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F6A7FE02-591D-46CF-9301-BDFBB0DC5367@lepiller.eu \
--to=julien@lepiller.eu \
--cc=33706@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).