unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret <dev@jpoiret.xyz>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: "50563@debbugs.gnu.org" <50563@debbugs.gnu.org>
Subject: [bug#50563] [PATCH [0/2] gnu: GDM: Add Wayland support
Date: Fri, 01 Oct 2021 08:56:21 +0000	[thread overview]
Message-ID: <EFDLsErTowu_-9L8iNXNX3bzVoRTnELojRmKLBDBqcmdhL7tkFRzAl3-LwouNx3NZ_25dvE_KphxphCb00bixPmDQcytM1ApbkgCR7R2rPE=@jpoiret.xyz> (raw)
In-Reply-To: <875yuhqjp0.fsf_-_@gnu.org>

Hello,

On Friday, October 1st, 2021 at 9:37 AM, Mathieu Othacehe <othacehe@gnu.org> wrote:
> I'm not sure to get perfectly the role of this wrapper, could you
> please clarify it?

Simply put, when display managers (on Guix) start an X session, they are all configured to use a generic Guix-specific wrapper script, a `xinitrc`.
This feature predates Guix of course, and is supported by all display managers afaik. `xinitrc` is defined in `gnu/services/xorg.scm` and is the generic Guix wrapper.
Notice that most importantly, it runs the window manager inside a login shell, which thus inherits the right environment variables that are set by default in `/etc/profile` (unless of course `/etc/profile` isn't sourced by the login shell, but then the user is on his own).

So we would like to do the same with Wayland, however since Wayland compositors are just single programs that need to be launched, most display managers used to simply start the compositors without doing anything else. This is still the behaviour of GDM, whereas for example SDDM or Slim (at least in Guix) already support wrapping those in some scripts. Here, I just define a generic script that launches sessions inside a login shell, akin to the default `xinitrc`. The check for the `gdm` user is that the GDM graphical display is launched through... GDM itself, and thus is handled like the other Wayland sessions; but since the `gdm` user doesn't have a login shell, this wouldn't work.

> It looks like nix is dealing differently with the session starting,
> without using a dedicated script:
> https://github.com/NixOS/nixpkgs/blob/master/pkgs/desktops/gnome/core/gdm/fix-paths.patch

From my understanding of https://github.com/NixOS/nixpkgs/issues/109546, they're still trying to deal with this generic issue (ie. they haven't patched in wrapper support in GDM).
See https://github.com/NixOS/nixpkgs/issues/109542 for an example of a bug that stems from it.

Josselin




  reply	other threads:[~2021-10-01  8:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  7:35 [bug#50563] [PATCH [0/2] gnu: GDM: Add Wayland support Josselin Poiret
2021-09-13  7:45 ` [bug#50563] [PATCH 1/2] gnu: Add Wayland support for GDM Josselin Poiret via Guix-patches via
2021-09-13  7:49 ` [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script Josselin Poiret via Guix-patches via
2021-09-13  8:13 ` [bug#50563] [PATCH 1/2] gnu: Add Wayland support for GDM Josselin Poiret
2021-09-13  8:15 ` [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script Josselin Poiret
2021-09-13 18:14   ` Maxime Devos
2021-10-01  7:37   ` [bug#50563] [PATCH [0/2] gnu: GDM: Add Wayland support Mathieu Othacehe
2021-10-01  8:56     ` Josselin Poiret [this message]
2021-10-01  9:16       ` Mathieu Othacehe
2021-10-02 16:51         ` Josselin Poiret
2021-10-02 17:29           ` bug#50563: " Mathieu Othacehe
2021-09-13 15:43 ` [bug#50563] (No Subject) Josselin Poiret via Guix-patches via
2021-09-14  2:02   ` Jack Hill
2021-09-14 21:45 ` [bug#50563] Re: [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script Josselin Poiret
2021-09-15  9:47   ` Maxime Devos
2021-09-29 11:20 ` [bug#50563] [PATCH [0/2] gnu: GDM: Add Wayland support Mathieu Othacehe
2021-09-29 12:10   ` Mathieu Othacehe
2021-09-29 22:10     ` Josselin Poiret
2021-09-30  9:41       ` Mathieu Othacehe
2021-09-30 14:27         ` Josselin Poiret
2021-10-01  7:33           ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='EFDLsErTowu_-9L8iNXNX3bzVoRTnELojRmKLBDBqcmdhL7tkFRzAl3-LwouNx3NZ_25dvE_KphxphCb00bixPmDQcytM1ApbkgCR7R2rPE=@jpoiret.xyz' \
    --to=dev@jpoiret.xyz \
    --cc=50563@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).