unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Benoit Joly <benoit@benoitj.ca>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>,
	57149@debbugs.gnu.org
Subject: [bug#57149] [PATCH] gnu: Add font-nerd-fonts-firacode
Date: Fri, 12 Aug 2022 08:30:48 -0400	[thread overview]
Message-ID: <E20632FA-F3F0-4D23-9777-2424CE888A64@benoitj.ca> (raw)
In-Reply-To: <e97530768cf6c9f906d9b7ea29435f17ca49344a.camel@ist.tugraz.at>

[-- Attachment #1: Type: text/plain, Size: 3497 bytes --]

Hi, 

I'll have a look on the licensing. It's not worth the effort if this is non free.

Thanks for the feedback!

Benoit 

On August 12, 2022 5:51:09 AM EDT, Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> wrote:
>Am Freitag, dem 12.08.2022 um 00:23 -0400 schrieb Benoit Joly:
>> * gnu/packages/fonts (font-nerd-fonts-firacode): New variable.
>> ---
>>  gnu/packages/fonts.scm | 35 +++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
>> 
>> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
>> index 20b55bce96..0ce9ba8414 100644
>> --- a/gnu/packages/fonts.scm
>> +++ b/gnu/packages/fonts.scm
>> @@ -51,6 +51,7 @@
>>  ;;; Copyright © 2021 Liliana Marie Prikler
>> <liliana.prikler@gmail.com>
>>  ;;; Copyright © 2022 Jose G Perez Taveras <josegpt27@gmail.com>
>>  ;;; Copyright © 2022 Hilton Chain <hako@ultrarare.space>
>> +;;; Copyright © 2022 Benoit Joly <benoit@benoitj.ca>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -2795,3 +2796,37 @@ (define-public font-chiron-hei-hk
>>  Kong variant of Adobe’s Source Han Sans.  The font aims at providing
>> a modern,
>>  region-agnostic glyph set adopting the “modern” glyph style that is
>> similar to
>>  prevalent typefaces in Traditional Chinese regions.")))
>> +
>> +(define-public font-nerd-fonts-fira-code
>> +  (package
>> +   (name "font-nerd-fonts-fira-code")
>> +   (version "2.1.0")
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri
>> +      (string-append
>> +       "https://github.com/ryanoasis/nerd-fonts/releases/download/v"
>> +       version
>> +       "/FiraCode.zip"))
>> +     (sha256
>> +      (base32
>> +       "1rx7zrkq0584k6hrh6dx30xrnz5nq379xyw73pfd4gxaxnh9mpi1"))))
>Use (uri (string-append "..."
>                        "...")
>> +   (build-system font-build-system)
>> +   (arguments
>> +    `(#:phases
>> +      (modify-phases %standard-phases
>> +        (add-before 'install 'make-files-writable
>> +          (lambda _
>> +            (for-each
>> +             make-file-writable
>> +             (find-files "." ".*\\.(otf|otc|ttf|ttc)$"))
>> +            #t)))))
>Why do the files need to be made writable for install?
>
>> +   (home-page "https://www.nerdfonts.com/")
>> +   (synopsis "Nerd fonts variant of FiraCode font")
>> +   (description
>> +    "Nerd fonts variant of FiraCode font.  Nerd Fonts is a project
>> that patches
>> +developer targeted fonts with a high number of glyphs (icons). 
>> Specifically to
>> +add a high number of extra glyphs from popular 'iconic fonts' such
>> as Font
>> +Awesome, Devicons, Octicons, and others.")
>> +   (license license:silofl1.1)))
>The description should consist of full sentences.  Note that Nerd fonts
>pulls in icons that are licensed under CC BY-NC-ND, which makes them
>unfree.  I'm not sure if those icons are present in the default
>distribution, but I'd hazard a guess that they are.
>
>More concerningly, the patches that can be applied via nerd fonts are
>directly coded into their font-patcher, rather than, say, distributed
>as a json file to be read separately.  As far as I'm aware, this makes
>nerd-fonts (the tool) itself NG.
>
>Cheers

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[-- Attachment #2: Type: text/html, Size: 4830 bytes --]

  reply	other threads:[~2022-08-12 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  4:23 [bug#57149] [PATCH] gnu: Add font-nerd-fonts-firacode Benoit Joly
2022-08-12  9:51 ` Liliana Marie Prikler
2022-08-12 12:30   ` Benoit Joly [this message]
2022-08-21 14:30 ` Benoit Joly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E20632FA-F3F0-4D23-9777-2424CE888A64@benoitj.ca \
    --to=benoit@benoitj.ca \
    --cc=57149@debbugs.gnu.org \
    --cc=liliana.prikler@ist.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).