unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: <pkill9@runbox.com>
To: pkill9 <pkill9@runbox.com>
Cc: 34523 <34523@debbugs.gnu.org>
Subject: [bug#34523] Add tetrinet
Date: Tue, 26 Feb 2019 15:44:44 +0000 (GMT)	[thread overview]
Message-ID: <E1gyeuS-0005Lw-SS@rmmprod05.runbox> (raw)
In-Reply-To: <E1gvcri-0006jX-4B@rmmprod05.runbox>

[-- Attachment #1: Type: text/plain, Size: 2996 bytes --]

Here is a patch that:
 - Removes the full stop after 'no tests'
 - Changes the synopsis from "Multiplayer tetris" to "Multiplayer tetris game".
 - Replaces the description with what you (swedebugia) suggested.

> As an aside I did not find a working server anywhere ... There is a possibility to host your own server with jetrix though.

Oh I realised you meant a server program - the tetrinet package builds one called 'tetrinet-server', I tested it just now by running these commands in separate terminals:

`tetrinet-server`
`tetrinet player1 localhost`
`tetrinet player2 localhost`

Sending messages as the two different players shows up correctly in each tetrinet client, so I think the server works fine.

On Tue, 26 Feb 2019 15:20:28 +0000 (GMT), <pkill9@runbox.com> wrote:

> Hi Swedebugia,
> 
> > having looked it up online I prefer the WP synopsis:
> > "TetriNET is a console multiplayer online Tetris game for up to six people."
> > 
> > There is a gnome version also. We should state clearly that this is a
> > console/text-mode client.
> 
> What does 'WP' mean?
> 
> > As an aside I did not find a working server anywhere and the homepage of
> > the project is dead. There is a possibility to host your own server with
> > jetrix though.
> 
> I played Tetrinet with someone over a server, but I can't remember what the address was.
> 
> You can't access the homepage of the project? I can access http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in ages?
> 
> > There could be trademark issues with the name/game also see
> > https://en.wikipedia.org/wiki/The_Tetris_Company
> 
> Regarding the potential trademark issues, both FSF-approved distros Parabola and PureOS have Tetrinet in their repositories[1][2], so I think it would be acceptable to add it to Guix. And if a copyright claim is made in the future it can always be removed.
> 
> [1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
> [2] Tetrinet in PureOS - https://software.pureos.net/search_pkg?term=tetrinet
> 
> Thanks
> 
> On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net> wrote:
> 
> > On 2019-02-23 10:26, swedebugia wrote:
> > > For the sake of making it easy to find when searching synopsies I
> > > suggest you add "game" to the end of yours.
> > > -- 
> > > Sent from my k-9 mail for Android.
> > 
> > having looked it up online I prefer the WP synopsis:
> > "TetriNET is a console multiplayer online Tetris game for up to six people."
> > 
> > There is a gnome version also. We should state clearly that this is a
> > console/text-mode client.
> > 
> > As an aside I did not find a working server anywhere and the homepage of
> > the project is dead. There is a possibility to host your own server with
> > jetrix though.
> > 
> > There could be trademark issues with the name/game also see
> > https://en.wikipedia.org/wiki/The_Tetris_Company
> > 
> > -- 
> > Cheers Swedebugia



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2726 bytes --]

From 2957b371e121b7cc8ee9eb63382c331cab305ebc Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Tue, 26 Feb 2019 15:37:30 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..d716f91ba 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris game")
+    (description "TetriNET is a console multiplayer online Tetris game for
+up to six people.")
+    (license license:public-domain)))
-- 
2.20.1


  parent reply	other threads:[~2019-02-26 15:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  6:57 [bug#34523] Add tetrinet pkill9
2019-02-18 10:36 ` Ricardo Wurmus
2019-02-18 14:11   ` Tobias Geerinckx-Rice
2019-02-18 14:41     ` Danny Milosavljevic
2019-02-23  9:23       ` swedebugia
2019-02-19  7:51     ` pkill9
2019-02-23  9:26       ` swedebugia
2019-02-23  6:23         ` swedebugia
2019-02-26 15:20           ` pkill9
2019-02-26 20:45             ` swedebugia
2019-02-27  7:10               ` pkill9
2021-08-06  3:20       ` bug#34523: " Maxim Cournoyer
2019-02-26 15:44 ` pkill9 [this message]
2019-02-26 20:40   ` [bug#34523] " swedebugia
2019-02-27  7:01     ` pkill9
2019-02-27 14:11 ` pkill9
2019-02-28  4:03   ` swedebugia
2019-03-02 20:10     ` pkill9
2019-03-31 11:44     ` pkill9
2019-04-10 13:07 ` pkill9
2019-06-30  9:33 ` pkill9

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1gyeuS-0005Lw-SS@rmmprod05.runbox \
    --to=pkill9@runbox.com \
    --cc=34523@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).