From: <pkill9@runbox.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34497 <34497@debbugs.gnu.org>
Subject: [bug#34497] Add odamex
Date: Thu, 21 Feb 2019 13:04:51 +0000 (GMT) [thread overview]
Message-ID: <E1gwo1z-0006LE-36@rmmprod05.runbox> (raw)
In-Reply-To: <87bm365gsb.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
Here is an updated patch.
On Wed, 20 Feb 2019 21:47:00 +0100, Ricardo Wurmus <rekado@elephly.net> wrote:
>
> Hi pkill9,
>
> > * gnu/packages/games.scm (odamex): New variable.
> […]
> > + (uri (string-append
> > + "mirror://sourceforge/odamex/Odamex/"
> > + version
> > + "/odamex-src-"
> > + version
> > + ".tar.gz"))
>
> Please put this on fewer lines.
>
> > + (sha256
> > + (base32
> > + "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> > + (build-system cmake-build-system)
> > + (arguments `(#:tests? #f)) ;; No tests
>
> Please use just one semicolon.
>
> > + (inputs
> > + `(("sdl" ,(@ (gnu packages sdl) sdl))
> > + ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> > + ("zlib" ,(@ (gnu packages compression) zlib))
> > + ("libpng" ,(@ (gnu packages image) libpng))
> > + ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))
>
> This is not okay. Please just use the plain variable names.
>
> > + (home-page "https://odamex.net/")
> > + (synopsis "Multiplayer Doom port")
> > + (description "Odamex is a free, cross-platform modification of the Doom
> > +engine that allows players to easily join servers dedicated to playing Doom
> > +online.")
>
> Please remove “free” — all software in Guix is Free Software.
>
> > + (license license:gpl2)))
>
> Looks like this is actually gpl2+ as evidenced by files like this:
>
> https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12
>
> Could you please send an updated patch?
>
> --
> Ricardo
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-odamex.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-odamex.patch", Size: 1638 bytes --]
From 353f9444cd71c1e93978cf9b113e3f8743f385a8 Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Thu, 21 Feb 2019 13:02:07 +0000
Subject: [PATCH] gnu: Add odamex.
* gnu/packages/games.scm (odamex): New variable.
---
gnu/packages/games.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 6d9e63c4e..bec38dd41 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -5378,6 +5378,34 @@ Strife, Chex Quest, and fan-created games like Harmony, Hacx and Freedoom.")
"file://dumb/licence.txt"
"Dumb license, explicitly GPL compatible.")))))
+(define-public odamex
+ (package
+ (name "odamex")
+ (version "0.8.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://sourceforge/odamex/Odamex/" version "/"
+ "odamex-src-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
+ (build-system cmake-build-system)
+ (arguments `(#:tests? #f)) ; no tests.
+ (inputs
+ `(("sdl" ,sdl)
+ ("sdl-mixer" ,sdl-mixer)
+ ("zlib" ,zlib)
+ ("libpng" ,libpng)
+ ("alsa-lib" ,alsa-lib)))
+ (home-page "https://odamex.net/")
+ (synopsis "Multiplayer Doom port")
+ (description "Odamex is a modification of the Doom engine that
+allows players to easily join servers dedicated to playing Doom
+online.")
+ (license license:gpl2+)))
+
(define-public fortune-mod
(package
(name "fortune-mod")
--
2.20.1
next prev parent reply other threads:[~2019-02-21 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 6:04 [bug#34497] Add odamex pkill9
2019-02-17 10:25 ` Efraim Flashner
2019-02-17 14:28 ` pkill9
2019-02-20 20:47 ` Ricardo Wurmus
2019-02-21 13:04 ` pkill9 [this message]
2019-03-23 20:57 ` bug#34497: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1gwo1z-0006LE-36@rmmprod05.runbox \
--to=pkill9@runbox.com \
--cc=34497@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).