[bug#66547] [PATCH 0/2] Update `notmuch' package to support sexp queries

[bug#66547] [PATCH 0/2] Update `notmuch' package to support sexp queries

[Sergio Pastor Pérez]

This opens a patch series containing the `sfsexp' package required by
`notmuch' to compile with support for sexp queries. The other patch modifies
the `notmuch' package to include the `sfsexp' library as a native input so its
path is picked up by the build system.

Sergio Pastor Pérez (2):
  gnu: Add sfsexp.
  gnu: notmuch: Update to support sexp queries.

 gnu/packages/c.scm    | 23 +++++++++++++++++++++++
 gnu/packages/mail.scm |  5 ++++-
 2 files changed, 27 insertions(+), 1 deletion(-)


base-commit: 3d0cdf963820da665d71987c15cae6e503efc701
-- 
2.41.0

[bug#66547] [PATCH 1/2] gnu: Add sfsexp.

[Sergio Pastor Pérez]

* gnu/packages/c.scm (sfsexp): New variable.
---
 gnu/packages/c.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index ea58c68262..0a63b81188 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -571,6 +571,29 @@ (define-public libwuya
       ;; clarified (see: https://github.com/WuBingzheng/libwuya/issues/2).
       (license license:gpl2+))))
 
+(define-public sfsexp
+  (package
+    (name "sfsexp")
+    (version "1.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mjsottile/sfsexp")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03srnpc7p1j7ygd0wx9gybcxhqm50kjzkybh1xs75nwz97q3y2dq"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
+    (home-page "https://github.com/mjsottile/sfsexp")
+    (synopsis "Small Fast S-Expression Library")
+    (description
+     "Sfsexp provides an interface to manipulate (read, parse, modify, and
+create) symbolic expressions from C or C++ programs.  A symbolic expression,
+or s-expression, is essentially a LISP-like expression such as (a (b c)).")
+    (license license:gpl2)))
+
 (define-public packcc
   (package
     (name "packcc")
-- 
2.41.0

[bug#66547] Review

[Wicki Gabriel (wicg)]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

Thanks for your patches! They look good to me, except for the fact that you state "GPL 2" as the license even though in the repo they say LGPL2.1 (or is it LGPL2.1+).

Please send us a corrected version of your patches.

[-- Attachment #2: Type: text/html, Size: 1017 bytes --]

[bug#66547] [PATCH v2] gnu: Add sfsexp.

[Sergio Pastor Pérez]

* gnu/packages/c.scm (sfsexp): New variable.
---
Corrected license.

 gnu/packages/c.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index ac83336ba5..29b89c5cb1 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -572,6 +572,29 @@ (define-public libwuya
       ;; clarified (see: https://github.com/WuBingzheng/libwuya/issues/2).
       (license license:gpl2+))))
 
+(define-public sfsexp
+  (package
+    (name "sfsexp")
+    (version "1.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mjsottile/sfsexp")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03srnpc7p1j7ygd0wx9gybcxhqm50kjzkybh1xs75nwz97q3y2dq"))))
+    (build-system gnu-build-system)
+    (native-inputs (list autoconf automake libtool))
+    (home-page "https://github.com/mjsottile/sfsexp")
+    (synopsis "Small Fast S-Expression Library")
+    (description
+     "Sfsexp provides an interface to manipulate (read, parse, modify, and
+create) symbolic expressions from C or C++ programs.  A symbolic expression,
+or s-expression, is essentially a LISP-like expression such as (a (b c)).")
+    (license license:lgpl2)))
+
 (define-public packcc
   (package
     (name "packcc")

base-commit: 06f25a9a85be1bbe7a709e58ce41c1a834e5f1ae
-- 
2.41.0