From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KAazHjR3/2F80AAAgWs5BA (envelope-from ) for ; Sun, 06 Feb 2022 08:22:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2PlnGzR3/2GsrgAAauVa8A (envelope-from ) for ; Sun, 06 Feb 2022 08:22:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8250F1121D for ; Sun, 6 Feb 2022 08:22:27 +0100 (CET) Received: from localhost ([::1]:58520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGbsO-0002SC-Ie for larch@yhetil.org; Sun, 06 Feb 2022 02:22:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGbr4-0002Hz-Tw for guix-patches@gnu.org; Sun, 06 Feb 2022 02:21:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGbr4-0003FT-KR for guix-patches@gnu.org; Sun, 06 Feb 2022 02:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGbr4-0005dk-Gu for guix-patches@gnu.org; Sun, 06 Feb 2022 02:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53583] [PATCH] gnu: Add ncdu-ng. Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Feb 2022 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53583 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 53583@debbugs.gnu.org Received: via spool by 53583-submit@debbugs.gnu.org id=B53583.164413200421602 (code B ref 53583); Sun, 06 Feb 2022 07:21:02 +0000 Received: (at 53583) by debbugs.gnu.org; 6 Feb 2022 07:20:04 +0000 Received: from localhost ([127.0.0.1]:36257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGbq4-0005br-0h for submit@debbugs.gnu.org; Sun, 06 Feb 2022 02:20:04 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:17909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGbq1-0005be-9m for 53583@debbugs.gnu.org; Sun, 06 Feb 2022 02:19:58 -0500 Date: Sun, 06 Feb 2022 07:19:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1644131990; bh=zBYiP93Ld64QNaQ5ssaERlGzq7Msmzo+w1bwWVleol0=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=ZigVbFw4bZeLVUNhnBP6jtYpHVI8NC1vbE/ZCOJxNBfzMibNcxTw+6d2TmLNJQOTn s5TGsAsqYgVIWhhi+NkHJ96N6TbD9ZOi9EGsbS92IqImguzgKFwAremxjccd/qhqMv qLBJU/E5jFoIf4UDGQdG5YZ1h9inM+lflrJBuf3rYVXD6kPw6sKUyi3CX3/LFwOmK7 YLOX8K2tuQoOwVOF8WZmriEB4kbwWvXpI4m0KmanOHVxjIS9LiB81ejMP2RcnTsLRI mJEBTy8kzPtD5soEV8J/pu1qgKkCP5Z1DAxaDYvk577GPW+4qJXszjL1YZbyg2kGyo InPvnBcP/eXLA== Message-ID: In-Reply-To: References: <6vXo33nNBkLPCf4VQTY3L-RrWG8JHPVjtgprEQk8vcmVXfDXty5cr6Dyj_qkc21iYmzHrVTKJukBnNWkx6FebmPZJyUZk3KBHaG5b2DksCM=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches From: phodina via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644132147; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zBYiP93Ld64QNaQ5ssaERlGzq7Msmzo+w1bwWVleol0=; b=Xdui83zLLrezSvT7kNlpfuASuYsnvI/thDGcjkkUSd3/KwrzhYR4cqCzBrXBHtInFziokY /EUzunouPf3M4ppN28/CKIU/fUpmXTHi1TD3dwKjNlQSgwzrMAKrwXGr6f3zvDm/NLKa4e XLiJKSgiU9F5DqoduemJY4XshZbWQmO1XeFiKdnvTdMpnst61NxzPNjYQvPJkSji7iecGr 1FSu13hmd+1qa5PegwV+0WI9v7+0LC8Sf8Vt3AVMBQ87iuFuKwQZP0X5ysVUP63x07zGma QkzppIAKNQaXqBOScdm3cmgXlrLQi5lRxuDzP6sOuxpsq8QPlV/hvgYkeYdT5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644132147; a=rsa-sha256; cv=none; b=uTVV9fR4vbxbGDIAopLGZ6aJWfGv/v4BR3Sl9TvV+nOrgZzR+AvbPfwsN0U6tEltAJB6SL Qwjgp1HfZUmCEcahGfJ6LfZXzLeVBNwbAdm8ElUvspc8qOTkDzBosdy25l7mUYeHA4tgPo 5LDgsLPViBpNfNI47wr40zS5hnv/fRzXiHww1+0ccqY7Dzgd/94DB0pLQyYglIhYERwd9A fcHjavo5JS3OBC7dupMRbbJbrMF8aFejtudZy4JSks0XbcRRf9isUB2MUYqpS+7E0t8RNI qVexxzUpwjnuI6loNDDkvHTCv3jUZPL0UyLBadYPmdG0iBDBW2iC1TRmEUXrEw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=ZigVbFw4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=ZigVbFw4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8250F1121D X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: wNWRmTLgQbym Hi Efraim, Sent with ProtonMail Secure Email. ------- Original Message ------- On Tuesday, February 1st, 2022 at 12:03 PM, Efraim Flashner wrote: > On Thu, Jan 27, 2022 at 02:22:58PM +0000, phodina via Guix-patches via wr= ote: > > > Hello, > > > > here is a patch for the ncdu. As version 2.0.* are based on Zig I decid= ed to create a new variable instead of updating the old one. > > > > FIY this is my first encounter with Zig and I just briefly swept throug= h the documentation and I don't know if cross-compilation won't be an issue= since the previous versions are just plain C. > > > > If you think there is no need to do this and we can just simply update = let me know and I'll send updated patch. > > I also packaged ncdu@2 locally, to try out packaging a zig program. I > > was unable to build zig for aarch64 due to the memory requirements > > during the linking stage, so for now I agree it makes sense to have a > > separate zig version and not just upgrade to the new version. > > Also I'm attaching my copy if you want to take a look and see about > > merging the two. > > > Petr > > > From 3e6ad4ef4f928314bd69cae18a05be317e1b26ab Mon Sep 17 00:00:00 2001 > > > > From: Petr Hodina phodina@protonmail.com > > > > Date: Thu, 27 Jan 2022 14:56:39 +0100 > > > > Subject: [PATCH] gnu: Add ncdu-ng. > > > > - gnu/packages/ncdu.scm (ncdu-ng): New variable. > > > > diff --git a/gnu/packages/ncdu.scm b/gnu/packages/ncdu.scm > > > > index d6e4522bf0..01084976f0 100644 > > > > --- a/gnu/packages/ncdu.scm > > > > +++ b/gnu/packages/ncdu.scm > > > > @@ -1,6 +1,7 @@ > > > > ;;; GNU Guix --- Functional package management for GNU > > > > ;;; Copyright =C2=A9 2014 John Darrington jmd@gnu.org > > > > ;;; Copyright =C2=A9 2018=E2=80=932021 Tobias Geerinckx-Rice me@tobias.= gr > > > > +;;; Copyright =C2=A9 2022 Petr Hodina phodina@protonmail.com > > > > ;;; > > > > ;;; This file is part of GNU Guix. > > > > ;;; > > > > @@ -20,8 +21,10 @@ > > > > (define-module (gnu packages ncdu) > > > > #:use-module (gnu packages) > > > > #:use-module (gnu packages ncurses) > > > > - #:use-module (gnu packages zig) > > > > #:use-module (guix licenses) > > > > #:use-module (guix packages) > > - #:use-module (guix utils) > > > > #:use-module (guix download) > > > > #:use-module (guix build-system gnu)) > > > > @@ -49,3 +52,32 @@ (define-public ncdu > > > > (string-append "https://g.blicky.net/ncdu.git/plain/COPYING?id=3Dv" > > > > version))) > > > > (home-page "https://dev.yorhel.nl/ncdu"))) > > > > + > > > > +(define-public ncdu-ng > > > > - (package > > - (inherit ncdu) > > - (name "ncdu-ng") > > - (version "2.0.1") > > - (source (origin > > - (method url-fetch) > > > > > > - (uri (string-append "https://dev.yorhel.nl/download/nc= du-" > > > > > > - version ".tar.gz")) > > > > > > - (sha256 > > > > > > - (base32 > > > > > > - "0j3w8xixz1zkzcpk0xrh6y3r7sii3h3y31lbvs5iqc5q7q6day9= g")))) > > > > > > - (arguments > > - `(#:tests? #f > > > > > > - #:make-flags > > > > > > - (list (string-append "PREFIX=3D" > > > > > > - (assoc-ref %outputs "out")) > > > > > > - ,(string-append "CC=3D" > > > > > > - (cc-for-target))) > > > > > > - #:phases > > > > > > - (modify-phases %standard-phases > > > > > > - (add-after 'unpack 'set-home-dir > > > > > > - (lambda* _ > > > > > > - ;; Zig caches build > > > > > > - (setenv "HOME" "/tmp"))) > > > > > > - (delete 'configure)))) > > > > > > - (native-inputs (list zig)) > > - (inputs (list ncurses)))) > > > > -- > > > > 2.34.0 > > -- > > Efraim Flashner efraim@flashner.co.il =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 > > GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 > > Confidentiality cannot be guaranteed on emails sent or received unencrypt= ed I've reviewed and tested your patch on x86_64 machine and it build successf= ully. I also wasn't able to build Zig on my ARM machines (Raspberry and PBP= ) so it should definitely have it's own definition (at least for now). I agree with keeping a note why there number 2 in the name. Thanks for the phase with setting ZIG_GLOBAL_CACHE_DIR as this what helpful= in my understanding of Zig. Otherwise the patch LGTM. ---- Petr