From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHB4JaYvzV/8RwAA0tVLHw (envelope-from ) for ; Sun, 06 Dec 2020 19:23:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IF9GIaYvzV+IbQAAB5/wlQ (envelope-from ) for ; Sun, 06 Dec 2020 19:23:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39A5F94030E for ; Sun, 6 Dec 2020 19:23:17 +0000 (UTC) Received: from localhost ([::1]:54564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klzcq-0002Tk-Vf for larch@yhetil.org; Sun, 06 Dec 2020 14:23:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klzcc-0002So-PW for guix-patches@gnu.org; Sun, 06 Dec 2020 14:23:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klzcc-0002IK-Ie for guix-patches@gnu.org; Sun, 06 Dec 2020 14:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klzcc-0000GS-FZ for guix-patches@gnu.org; Sun, 06 Dec 2020 14:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45011] [PATCH] add emacs-project and dependency Resent-From: Jonathan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45011 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 45011@debbugs.gnu.org Received: via spool by 45011-submit@debbugs.gnu.org id=B45011.1607282561975 (code B ref 45011); Sun, 06 Dec 2020 19:23:02 +0000 Received: (at 45011) by debbugs.gnu.org; 6 Dec 2020 19:22:41 +0000 Received: from localhost ([127.0.0.1]:51341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzcH-0000Fd-B1 for submit@debbugs.gnu.org; Sun, 06 Dec 2020 14:22:41 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:43565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzcF-0000FR-M0 for 45011@debbugs.gnu.org; Sun, 06 Dec 2020 14:22:40 -0500 Received: by mail-qk1-f193.google.com with SMTP id u4so10677541qkk.10 for <45011@debbugs.gnu.org>; Sun, 06 Dec 2020 11:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=PBN+VoXikI1YDcGMQ97n/fkbSC4KUEOxfid9RLety78=; b=HyJ2lbt8lgraPK30Vv4gR5nIJog8LOJpnr0o0U9AOESYtqEc4Yw/TeEAw8MIliZiVS O3TcFcGPwvIvldI6eSJajAhZnGMxBm77auP3bBu7vCcUHVlnB3blwj+PpSrFVxcpyogJ LU5ICeBI5+FjV6WO9MOmuoSOzeA8liBkKhJHSl3CeOr1ahc6N3UbJwosr4cj0mOpL2gG A+zHucsr25iYunPzbfLYZCtGjV/qaaO7ykpDj/ddkprfXV4tC29dqP6mK4MuLg1gVkNc LS/qQO8nMeQ9t0yP9UuYKwjZ4MJDImyqmBXmv/peMAmjKS/VWKYz9X/G1zLX2dg+m2W8 nx+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=PBN+VoXikI1YDcGMQ97n/fkbSC4KUEOxfid9RLety78=; b=MuD6Am+jy3dzMy1i1B1dZTYTny1yOU8sCCnNzJXAtuTGInI2YFY7PGKIWe/32t9uXK xE41Pq2xpsskZk88Z0RS3FzwC2zYZfexZalXcjoY4P8Jtcu/h276RBYkeFX2f5WhLtL/ vg7RRGhnEC2gfGXfgLE+OSlRQ4NSxbKEpDDE+EvasiSQmxK9EYpYpO0ZhLXMcT0Cq8F3 ohC1CQ9pe1Wv/apMANyRlDA19zw27ckpoIXzM1uOwGShGjPsuqwz4m/EKZ5AAIbru1Mc BQKGtT4KXYF4ITFXdhQrfGjjFpgnpyYoQW6qr4gBqhXGBhPr/kkz9clk9Cp4V7enqUpA +6Pg== X-Gm-Message-State: AOAM532eaLk+d/cycfDx6Zc1i3NuzmGDtNGP3UQFe9bWSyS/LIvPoMuJ VORi8Wqdi0hdxBg9CLc4xqU/ovCPIyA= X-Google-Smtp-Source: ABdhPJzE9aBEHignhzBYZBy4tyMv44cf2z4SnwzfKkDO1uZsA2sTyqIbhtCC8a5Iz/qGUXTgjHMPIA== X-Received: by 2002:a37:b94:: with SMTP id 142mr7672928qkl.318.1607282554012; Sun, 06 Dec 2020 11:22:34 -0800 (PST) Received: from [192.168.0.143] ([186.77.204.218]) by smtp.gmail.com with ESMTPSA id f8sm10040506qtp.91.2020.12.06.11.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 11:22:33 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Jonathan Mime-Version: 1.0 (1.0) Date: Sun, 6 Dec 2020 13:22:31 -0600 Message-Id: References: <874kkz0yw7.fsf@nicolasgoaziou.fr> In-Reply-To: <874kkz0yw7.fsf@nicolasgoaziou.fr> X-Mailer: iPhone Mail (18B92) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.70 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=HyJ2lbt8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 39A5F94030E X-Spam-Score: -0.70 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: la8oTI9wmFKK Hello Nicolas Thanks for the feedback. My bad if my tone in the email sounds dry... it=E2=80= =99s not my intention.=20 This is my first ever Guix contribution and I=E2=80=99m following from what I= saw in the website=E2=80=99s video tutorials. I kindly ask that you have so= me patience with me.=20 The only thing I need clarified now is how do I send the commits? I thought g= it format-patch included the commit? Do you want me to send two separate ema= ils with the commit message as the subject? I=E2=80=99m not sure how to send= to you the commit info with the patch in the email.=20 I did see those commit messages on the project repo but I was not sure I nee= ded to add a newline after the main message. Do you want me to send the patc= hes=E2=80=99 commit message like the one you just typed in the email? =20 All the best > On Dec 6, 2020, at 08:53, Nicolas Goaziou wrote: >=20 > =EF=BB=BFHello, >=20 > Jonathan writes: >=20 >> The descriptions are the ones found in their project's homepage. >=20 > Well, sometimes, even upstream descriptions need to be reworded. >=20 >> I can't think of a better synopsis for Project since it provides >> several functions to operate on a project directory... Do you have >> a suggestion?. >=20 > Unfortunately, no. My concern is that I don't know what this package is > about, and the synopsis doesn't help me finding it out. Maybe the term > "project" is too vague. >=20 > Note that the synopsis must fit on a single line, and is not a full > sentence. You may want to run "guix lint" on your package definition. >=20 > Also, I suggest to remove the big note at the beginning of each > description. It may make sense as a foreword in a project home page, but > I don't think it does when describing the software. >=20 >> Which patch do you want first? emacs-xref is needed for emacs-project. Do= >> you want me to send emacs-xref first? >=20 > Sure. >=20 > I see you send new patches. Could you integrate the suggestion above, > and include a proper commit message, like the following: >=20 > gnu: Add emacs-xref. >=20 > * gnu/packages/emacs-xyz.scm (emacs-xref): New variable. >=20 > ? >=20 > Thanks! >=20 > Regards, > --=20 > Nicolas Goaziou