From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 00n7AFLpj2KCwgAAbAwnHQ (envelope-from ) for ; Thu, 26 May 2022 22:55:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SLOHO1Hpj2J1xgAA9RJhRA (envelope-from ) for ; Thu, 26 May 2022 22:55:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C98A4267F for ; Thu, 26 May 2022 22:55:45 +0200 (CEST) Received: from localhost ([::1]:44470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuKWG-0007uE-Iw for larch@yhetil.org; Thu, 26 May 2022 16:55:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKVb-0007ts-HA for guix-patches@gnu.org; Thu, 26 May 2022 16:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuKVa-0001lB-J1 for guix-patches@gnu.org; Thu, 26 May 2022 16:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuKVa-0005rz-Cy for guix-patches@gnu.org; Thu, 26 May 2022 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55663] [PATCH] Image API: add FAT32 support Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 May 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 55663@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 55663@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165359849422537 (code B ref -1); Thu, 26 May 2022 20:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2022 20:54:54 +0000 Received: from localhost ([127.0.0.1]:60165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKVR-0005rR-Tc for submit@debbugs.gnu.org; Thu, 26 May 2022 16:54:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:51958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuKVP-0005rD-QD for submit@debbugs.gnu.org; Thu, 26 May 2022 16:54:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKVP-0007tM-D4 for guix-patches@gnu.org; Thu, 26 May 2022 16:54:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKVN-0001kF-99 for guix-patches@gnu.org; Thu, 26 May 2022 16:54:51 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 760165C0193; Thu, 26 May 2022 16:54:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 26 May 2022 16:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1653598488; x=1653684888; bh=BxI/DT3j/7 clPswdEjlavrCB5aRbkD2pjWhBbT+aXgw=; b=mVts17JdIyClLSijnS2SmMyK04 XtPQnO09AB7KgWP/ao1/aVhf4rToHs/7KfqeZUJIbqefoLt+lWrz1VKOE8HSueSF 7aNLY6pTIjXd3qyAiiGjeuKYKwyj57EGGuIDmjDz4Faal4myq/URwkBvgymphTY8 Eb5GKoJQiPnCsbs6G3NkoYDcvzlt9fPMjqzm/6N4juVWARVyL7+Z54Xcanhuc4le GwmNpyO41JMFgw2I+AwyuNG7HcnLREW2rb7Ge7s/xkyPW3V57RcezztBedFZm/T9 F2AXE1QP7+zIGhswDpD0dgjVXvU3bGQrMnyF/qYB82PTKWIq8EiAFvSANaVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653598488; x=1653684888; bh=BxI/DT3j/7clPswdEjlavrCB5aRb kD2pjWhBbT+aXgw=; b=DNYYi3dE1hRnDcc/lUff97mFaqpDI3Rs0eYBT/guSPPG 3/hQghpfwPMDgL9EMEdzqOIsTeQA4E+q5uoP1sudnXHkEiSek9RtuqG+TtAycOJa hpe7BBH8wCPJhAxaNsm+uiU2RVciNRz0UnNELgTTE4xfFEMRGVN9PEVzV8HmGkW5 t3BNq2oRdUwtnEwPl6BL8qv6py8o2sQfUKsnGLDyVs7HRVKJtUoggaqmdTCuiz1X oVOeZwi5+vqcDbBS7ynAeNsbq3cExGlky5VEnQaawKRiufrwXSHpIzeYq5P5ymni H/qzVOfnYxEkrlyyjO8dQzY1TczxhtxyLkjYFxqNxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeejgdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhkfgtggfuffgjvefvfhfosehmtd hmrehhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhes phgrnhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpeekgeekkeekfeetveekhe fhjedtudfgueelhefhueeghfefieduhfetlefgieefleenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrh igrdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 26 May 2022 16:54:47 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Date: Thu, 26 May 2022 23:54:45 +0300 In-Reply-To: <87bkvk6tp0@nckx> References: <3EE7299C-64ED-4062-BA31-ADF3A6AD6A37@pantherx.org> <87bkvk6tp0@nckx> X-Mailer: Apple Mail (2.3696.100.31) Received-SPF: pass client-ip=66.111.4.25; envelope-from=p.shlyak@pantherx.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653598545; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BxI/DT3j/7clPswdEjlavrCB5aRbkD2pjWhBbT+aXgw=; b=UI0T2BK0jz1yk/70/GtdviYWDbytzHFoHTQ9j23qhddiwNbQIyQyGz9iWqQ5lD9WhaIuIg vqTu8to0UIXi1wt0skhdz9GtWBTerCCSMfMdhyiEKSGP3fy/xXNeoPMrH12yMaNZea6TKS WmRgWO+1Qc3XRH7tFP5GztHQMYFfOA8PTUTwUGwDs1ZyMNBjPZZO77q5uKduIyciFj1p8d yuHNk4jd9msDjIDq9eqR/ks+UW9XmApzO3aVLo6jdpsUdnMb7Kv8remZlRlFtORL8uKug5 uffJ4JzwTpoq9Sl/3lwYFuVdUh1vL/p7SbhLUCKNWpYgFybpmJqQn2RriuhxLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653598545; a=rsa-sha256; cv=none; b=IVjIyB1ID6AvwjjVUhCQcn3WJvTnbqNfvhTUHq/1bCIoryJBOK9QHWnD6ChOW1t5f3TUeX 1OkaEiCcBPPRSOzjKwe9010qO889OsET8yyPP3tNw+3+986h6QnSlKvFcL3SQd+hTWYova pySJwpCtvVHE69NbM6IXBiUvCe6uJtMVI/bArN58sneEyNpYeqPRa9EevJS2rIzOPzR+lB qduuR9xjzOEZrejNubBrhe4CX8zfBUPHtZGqGs0Hzlv1bQ1m5qYhdsTqmOYUMr5fTVZ45e JWyj4TqEV3D9MghfPhjrvJJYPJJp4DHBrq+ltI5sO4ykVZi09zUg0lEZZf5BbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=mVts17Jd; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=DNYYi3dE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.66 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=mVts17Jd; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=DNYYi3dE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6C98A4267F X-Spam-Score: 2.66 X-Migadu-Scanner: scn1.migadu.com X-TUID: Cd3w1LT/wpK8 --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thank you for a quick response! I have changed it according to your recommendations. I hope it=E2=80=99s = better now. --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Disposition: attachment; filename=0001-Image-API-support-FAT32-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Image-API-support-FAT32-partitions.patch" Content-Transfer-Encoding: quoted-printable =46rom=208128aa174f76646eedbf94c3f03cf1cff0f304d0=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Thu,=2026=20May=202022=2021:00:51=20+0300=0ASubject:=20[PATCH]=20= Image=20API:=20support=20FAT32=20partitions=0A=0A---=0A=20= gnu/build/image.scm=20=20|=2010=20++++++----=0A=20gnu/system/image.scm=20= |=20=209=20+++++++--=0A=202=20files=20changed,=2013=20insertions(+),=206=20= deletions(-)=0A=0Adiff=20--git=20a/gnu/build/image.scm=20= b/gnu/build/image.scm=0Aindex=203e8b94e2d6..d1398144a5=20100644=0A---=20= a/gnu/build/image.scm=0A+++=20b/gnu/build/image.scm=0A@@=20-95,12=20= +95,12=20@@=20(define*=20(make-ext-image=20partition=20target=20root=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(estimate-partition-size=20root)=0A=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20size)))))))=0A=20=0A= -(define*=20(make-vfat-image=20partition=20target=20root)=0A+(define*=20= (make-vfat-image=20partition=20target=20root=20fs_bits)=0A=20=20=20= "Handle=20the=20creation=20of=20VFAT=20partition=20images.=20=20See=20= 'make-partition-image'."=0A=20=20=20(let=20((size=20(partition-size=20= partition))=0A=20=20=20=20=20=20=20=20=20(label=20(partition-label=20= partition)))=0A=20=20=20=20=20(invoke=20"fakeroot"=20"mkdosfs"=20"-n"=20= label=20"-C"=20target=0A-=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20"16"=20= "-S"=20"1024"=0A+=20=20=20=20=20=20=20=20=20=20=20=20"-F"=20= (number->string=20fs_bits)=20"-S"=20"1024"=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20(size-in-kib=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20(if=20= (eq?=20size=20'guess)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(estimate-partition-size=20root)=0A@@=20-120,8=20+120,10=20@@=20= (define*=20(make-partition-image=20partition-sexp=20target=20root)=0A=20=20= =20=20=20(cond=0A=20=20=20=20=20=20((string-prefix?=20"ext"=20type)=0A=20= =20=20=20=20=20=20(make-ext-image=20partition=20target=20root))=0A-=20=20= =20=20=20((string=3D?=20type=20"vfat")=0A-=20=20=20=20=20=20= (make-vfat-image=20partition=20target=20root))=0A+=20=20=20=20=20((or=20= (string=3D?=20type=20"vfat")=20(string=3D?=20type=20"fat16"))=0A+=20=20=20= =20=20=20(make-vfat-image=20partition=20target=20root=2016))=0A+=20=20=20= =20=20((string=3D?=20type=20"fat32")=0A+=20=20=20=20=20=20= (make-vfat-image=20partition=20target=20root=2032))=0A=20=20=20=20=20=20= (else=0A=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(&message=0Adiff=20--git=20a/gnu/system/image.scm=20= b/gnu/system/image.scm=0Aindex=20dd32e58c2d..7e45f750d9=20100644=0A---=20= a/gnu/system/image.scm=0A+++=20b/gnu/system/image.scm=0A@@=20-312,7=20= +312,8=20@@=20(define=20(partition->dos-type=20partition)=0A=20=20=20=20=20= =20=20=20=20(cond=0A=20=20=20=20=20=20=20=20=20=20((member=20'esp=20= flags)=20"0xEF")=0A=20=20=20=20=20=20=20=20=20=20((string-prefix?=20= "ext"=20file-system)=20"0x83")=0A-=20=20=20=20=20=20=20=20=20((string=3D?=20= file-system=20"vfat")=20"0x0E")=0A+=20=20=20=20=20=20=20=20=20((or=20= (string=3D?=20file-system=20"vfat")=20(string=3D?=20file-system=20= "fat16"))=20"0x0E")=0A+=20=20=20=20=20=20=20=20=20((string=3D?=20= file-system=20"fat32")=20"0x0C")=0A=20=20=20=20=20=20=20=20=20=20(else=0A= =20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A@@=20-329,7=20+330,11=20= @@=20(define=20(partition->gpt-type=20partition)=0A=20=20=20=20=20=20=20=20= =20(cond=0A=20=20=20=20=20=20=20=20=20=20((member=20'esp=20flags)=20"U")=0A= =20=20=20=20=20=20=20=20=20=20((string-prefix?=20"ext"=20file-system)=20= "L")=0A-=20=20=20=20=20=20=20=20=20((string=3D?=20file-system=20"vfat")=20= "F")=0A+=20=20=20=20=20=20=20=20=20(=0A+=20=20=20=20=20=20=20=20=20=20= (or=20(string=3D?=20file-system=20"vfat")=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(string=3D?=20file-system=20"fat16")=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(string=3D?=20file-system=20"fat32")=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20)=20"F")=0A=20=20=20=20=20=20=20=20=20=20= (else=0A=20=20=20=20=20=20=20=20=20=20=20(raise=20(condition=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(&message=0A--=20=0A2.32.1=20= (Apple=20Git-133)=0A=0A= --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 26 =D0=BC=D0=B0=D1=8F 2022 =D0=B3., =D0=B2 21:07, Tobias = Geerinckx-Rice =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > Hi Pavel, >=20 > Pavel Shlyak =E5=86=99=E9=81=93=EF=BC=9A >> I believe it is an important change as Raspberry PI (and I suppose = some other boards) cannot boot with fat16 boot partitions.=20 >=20 > LGTM in principle. >=20 > The FS_BITS argument should be a regular number. You can coerce it = with number->string in the command line. >=20 > On the subject of being explicit is good: we should add "fat16" type = and treat "vfat" as a softly deprecated alias. But that can be done in = a later patch. >=20 > Kind regards, >=20 > T G-R --Apple-Mail=_2E6922ED-680E-4C45-B1C2-6EEBB686F909--