unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 49521@debbugs.gnu.org
Subject: [bug#49521] [PATCH] gnu: java-xz: Update to 1.9.
Date: Mon, 12 Jul 2021 08:42:32 -0400	[thread overview]
Message-ID: <DCEB9207-D860-4F69-AF1C-57EC3BEF29AB@lepiller.eu> (raw)
In-Reply-To: <YOw3tqZeN8dQxv4x@3900XT>

Le 12 juillet 2021 08:38:14 GMT-04:00, Efraim Flashner <efraim@flashner.co.il> a écrit :
>On Sun, Jul 11, 2021 at 12:08:35PM -0400, Julien Lepiller wrote:
>> Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner
><efraim@flashner.co.il> a écrit :
>> >* gnu/packages/java-compression.scm (java-xz): Update to 1.9.
>> >[arguments]: Build with openjdk9.
>> >---
>> > gnu/packages/java-compression.scm | 6 ++++--
>> > 1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/gnu/packages/java-compression.scm
>> >b/gnu/packages/java-compression.scm
>> >index 19b11954c1..033b55c988 100644
>> >--- a/gnu/packages/java-compression.scm
>> >+++ b/gnu/packages/java-compression.scm
>> >@@ -4,6 +4,7 @@
>> > ;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com>
>> > ;;; Copyright © 2018 Mark H Weaver <mhw@netris.org>
>> > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr>
>> >+;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il>
>> > ;;;
>> > ;;; This file is part of GNU Guix.
>> > ;;;
>> >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache
>> >@code{CBZip2InputStream} /
>> > (define-public java-xz
>> >   (package
>> >     (name "java-xz")
>> >-    (version "1.6")
>> >+    (version "1.9")
>> >     (source (origin
>> >               (method url-fetch/zipbomb)
>> > (uri (string-append "https://tukaani.org/xz/xz-java-" version
>".zip"))
>> >               (sha256
>> >                (base32
>> >-               
>> >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x"))))
>> >+               
>> >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi"))))
>> >     (build-system ant-build-system)
>> >     (arguments
>> >      `(#:tests? #f; no tests
>> >+       #:jdk ,openjdk9
>> >        #:phases
>> >        (modify-phases %standard-phases
>> >          (add-before 'install 'generate-pom
>> >
>> >base-commit: 7760d28920a920791645c4485f1345af45ee7787
>> 
>> Looks good, but building dependents will likely cause issues if they
>still use openjdk8. At the very least, we'll see a warning.
>
>Is that a problem? Starting with 1.9 they added some code that needs
>java 9 to compile. I test built the 4 packages which directly depend on
>java-xz and they built without problems.
>
>¹https://git.tukaani.org/?p=xz-java.git;a=blob;f=NEWS;h=d18a53b23efdae4b7d2911ef7898189462fac689;hb=HEAD

If dependents build fine, it should work.




  reply	other threads:[~2021-07-12 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-11 11:48 [bug#49521] [PATCH] gnu: java-xz: Update to 1.9 Efraim Flashner
2021-07-11 16:08 ` Julien Lepiller
2021-07-12 12:38   ` Efraim Flashner
2021-07-12 12:42     ` Julien Lepiller [this message]
2021-07-12 13:57       ` bug#49521: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCEB9207-D860-4F69-AF1C-57EC3BEF29AB@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=49521@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).